173 replies to this topic

[The_Raven]

1. Ah ok, a feature!

2. I check again and report, thx for testing.

[The_Raven]

Tested and something is strange...

If i go to "Einstellungen" -> "Aufnahmepfade" (in english i think recording path) i can not change anything.

Selecting an entry works, but after that i can not edit.

Can you edit this things?

[ims]

If a plugin requires a restart to work, the plugin is broken.

Do you want tell, that there is theoretical possibility, that when is plugin changed, then must not be restarted GUI and there does exist way for reload plugin's code only ?

[MiLo]

After installing a plugin, there is no reason whatsoever to reboot. There's nothing to justify that.

Once loaded, it's quite hard to unload a Python plugin. Existing objects will also keep modules referenced, so all existing references will keep using the code that was present when they loaded.

To re-load a module after changing it, you'll have to get rid of all references (also in sys.modules) first. For simple plugins that are activated via menu items, this is doable.

[The_Raven]

But some plugins need a restart, otherwise they don't work. Manual fan control for example. The menu entry is only there after a gui restart.

[MiLo]

That's a bug in the plugin then. That's the message I'm trying to get accross. If it needs a reboot to work, it's broken. Contact the author and complain about it.

[littlesat]

The plugin must tell if a restart of enigma2 is required... As most plugins do not need this...

[MiLo]

Totally disagree. A plugin must NEVER require a reboot. There shouldn't even be an interface to require it.

[Pedro_Newbie]

But sometimes when you install a plugin it doesn't show up in the plugin list but only after you refresh the list, by for instance pushing the red button for remove and then immediately closing this screen, then it shows up.

Is there a clever way during install to accomplish this e.g. in a postinst script?

[MiLo]

That sounds like a bug in the plugin list - it should refresh when you install a new one.

[The_Raven]

Checked again and if a NFS-Share is mounted, recording to internal harddisk is not working! Are you absolutely sure it works for you? Have you tried with a NFS-Share or with a CIFS?

[MiLo]

Maybe you set the "Replace HDD" option?

[The_Raven]

Ha! MiLo you are great!

If the option "Replace HDD" under network is set to "no" it does not work (message "Switching to channel for recording" or something (i can tell you the message in german if it helps), but no recording, maybe because the NFS-Share is RO), but if it's set to "yes" the recording starts to HDD!!! And if it's set to "no" and i edit the timer i see the recording path points to my NAS!

I'm really sure this is not since the beginning, i never had this problem before (if i remember it appears since 3-4 months)

[Rob van der Does]

Totally disagree. A plugin must NEVER require a reboot. There shouldn't even be an interface to require it.

And what about plugins that install system files? Or bring dependencies that do?

[Rob van der Does]

And even more: why would this have been committed if not required?
 

Commit: 367c104e1d3716861c87905575d0bc729342d79c [367c104]
Parents: 33e4aeedec
Author: acid-burn <acid-burn@opendreambox.org>
Date: 7 February 2011 13:15:40 GMT

PluginSystem: implement new PluginDescriptor option "needsRestart" to define if a plugin needs an enigma2 restart after installation.
Now new installed plugins are only direct accessible after installation if needsRestart=False is defined inside the plugins PluginDescriptor.
fixes #670
 

And see here: http://sourceforge.n...DBurn/plugin.py: you use it yourself!

Edited by SatKiekerd, 8 April 2014 - 11:49.

[WanWizard]

Author: acid-burn <acid-burn@opendreambox.org>

 

What do you mean by "you use it yourself"? This is clearly third-party stuff, do you expect us to rewrite it?

[Rob van der Does]

Anyway, it's an open plugin on the PLi-feeds.
And what about my two questions?

[WanWizard]

I don't know, I am not a plugin builder.

 

But my 2ct:

 

A plugin should not introduce system files. If it has system dependencies, those system packages should install themselfs. In Linux the only reason for a reboot is a swap of kernel version. Everything else can be done without reboot. I agree with Milo that if it can't, it's a design or development issue either of the plugin, or the package it depends on.

[Rob van der Does]

A plugin should not introduce system files.

If you would have said 'A plugin should not change existing system-files' I would fully agree.
But not being allowed to introduce system-files would prevent a lot of plugins from adding functionality. Which after all is the very reason to use a plugin in the first place.

If it has system dependencies, those system packages should install themselfs.

They do, if they are dependencies. That's the way installing a plugin works. And dependencies often introduce system-files.

And as system-files are being loaded on boot time (or at E2 start) a reboot (or E2 restart) is required in those cases.

If you would like no plugin to introduce any system-file at all, you should act upon every request from any plugin-builder to add system-files to your default image.

[MiLo]

If you install (for example) a new NFS server version, the package will stop the running server before installing new files, and start the server when done.