Jump to content


Photo

E2 failing to hide a hidden bouquet


  • Please log in to reply
40 replies to this topic

Re: E2 failing to hide a hidden bouquet #21 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 23 January 2015 - 19:04

Because it is not needed at all at this moment as hidden bouquets and services are hidden....

 

The bug when the first bouquet was hidden is solved yesterday night....

 

I checked it here in several ways.... hidden is working - so this work-a-round patch not required anymore. I would recommend to check it yourself.

 

The why you could read in the revert commit.....


Edited by littlesat, 23 January 2015 - 19:08.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #22 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 23 January 2015 - 19:11

Yes the first bouquet fix was necessary but without this commit my bouquets.tv posted above will not work.



Re: E2 failing to hide a hidden bouquet #23 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 23 January 2015 - 19:12

It does works fine here for 100% as I tested it.... So patch is not required...

When it is not working for you something else is wrong....

Hidden is checked in cpp and it hides those bouquets...


Edited by littlesat, 23 January 2015 - 19:21.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #24 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 23 January 2015 - 19:32

Ok, thanks for the fix. I have to wait for a build so I can test.



Re: E2 failing to hide a hidden bouquet #25 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 23 January 2015 - 19:53

Sorry when the comments on the revert were not clear.....

 

The issue with the bouquet at the start of the topic was that the first service was hidden.... To not include it in the list load was in fact an work-a-round. I hope I now solved it at the 'core' of the issue... ;)


Edited by littlesat, 23 January 2015 - 19:55.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #26 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 23 January 2015 - 22:18

Littlesat, please can you post a link to the commit.



Re: E2 failing to hide a hidden bouquet #27 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 23 January 2015 - 22:53

The revert commjt or the real fix...

I did make the rewl fix in two stages... One was the fix... But I could make ik a bit less complicated so I needed a second one...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #28 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 23 January 2015 - 22:58

This is the first commit...
http://sourceforge.n...6e32881039f6ee/

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #29 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 24 January 2015 - 01:26

The revert commjt or the real fix...

I did make the rewl fix in two stages... One was the fix... But I could make ik a bit less complicated so I needed a second one...

Well so far it has worked fine in my tests.



Re: E2 failing to hide a hidden bouquet #30 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 02:31

Because it is not needed at all at this moment as hidden bouquets and services are hidden....

This is absolutely still needed otherwise the hidden bouquets will show in OpenWebIF.



Re: E2 failing to hide a hidden bouquet #31 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 6 February 2015 - 07:37

Sorry... this is a change that should be made in OpenWebIF.... OpenWebIF should handle hiden services and bouquets and it seems it doesn't :(. It should also handle hiden numbered markers...

 

We should goal for a structured way and not for yet another work-a-round...


Edited by littlesat, 6 February 2015 - 07:40.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #32 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 07:59

Also, for me, hidden bouquets are showing in EPG without the line in ChannelSelection. Not sure if this affects OpenPLi.

Re: E2 failing to hide a hidden bouquet #33 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 6 February 2015 - 11:03

What do you mean?

 

When I checked hiden bouquets here I do simply do not see them in ChannelSelection... 

 

it could be in some EPG lists or GMEPG hidden services must still be hiden... :D

 

Note until know only 'hacking' 3rd party plugins do use hidden bouquets and hidden services...

 

I always wanted to change the way parental lock is coded... I want to get rid of those white and black lists and just add a flag to a service... But when I change this we get incompatible with those settings editors (and the current settings).... Therefore I did not make this yet...


Edited by littlesat, 6 February 2015 - 11:07.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #34 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 14:14

The hidden flag method was available, so the bouquet creation plugins used it. I don't see anything wrong with that. Personal opinion is it is nicer than how than how Fastcan does it with a blank space. What's the point in having an entry in the list that doesn't work?



Re: E2 failing to hide a hidden bouquet #35 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 14:30

Here's a screen grab. Note channel 31 doesn't exist for this provider so is completely missing from the list. IMO much more user friendly then a big block of visible markers wherever there is a gap in the provider's list.

Attached Files

  • Attached File  grab.jpg   86.25KB   1 downloads

Edited by Huevos, 6 February 2015 - 14:31.


Re: E2 failing to hide a hidden bouquet #36 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 6 February 2015 - 15:06

That is how it should be.... Just set hide number markers to Yes.....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #37 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 15:56

Ok, but I still don't understand why you think it is a hack to use a feature that is built in to the image?



Re: E2 failing to hide a hidden bouquet #38 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 6 February 2015 - 17:07

Sorry I cannot follow/understand what you are meaning right now....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #39 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 6 February 2015 - 18:30

I saw in openvix you bought back the do not load hidden bouquets hack... Please note in fact this should be solved of course in the OpenWebif itself...


Edited by littlesat, 6 February 2015 - 18:30.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: E2 failing to hide a hidden bouquet #40 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 6 February 2015 - 19:42

I saw in openvix you bought back the do not load hidden bouquets hack... Please note in fact this should be solved of course in the OpenWebif itself...

Littlesat, I was mistaken about that (lack of sleep). I reinstated that line of code to fix G-EPG not hiding the hidden bouquets. It does not cure the problem in OpenWebIF. This problem has always been there in OpenWebIF, just no one realized before.

 

Needs to be fixed in ./controllers/models/services.py -> getBouquets()




1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users