Jump to content


Photo

Parental Control


  • Please log in to reply
6 replies to this topic

#1 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 12 April 2015 - 10:42

I apologize if this has been discussed somewhere, but with serch, I did not find such a topic.

 

I do not have the original openpli enigma, but as far as I understand in original is the same.

 

When you first time open the Parental control be visible only choice: "Change PIN".

It is misleading to many users. They think that parental control does not work.

Maybe it would be better, if parental control not enabled, display choice: "Enable parental control".
Something like this:

--- a/lib/python/Screens/ParentalControlSetup.py
+++ b/lib/python/Screens/ParentalControlSetup.py
@@ -65,9 +65,12 @@ class ParentalControlSetup(Screen, ConfigListScreen, ProtectedScreen):
   self.changePin = None
   self.reloadLists = None
   self.list = []
-  self.changePin = getConfigListEntry(_("Change PIN"), NoSave(ConfigNothing()))
-  self.list.append(self.changePin)
-  if config.ParentalControl.servicepin[0].value:
+  if not config.ParentalControl.servicepin[0].value:
+   self.changePin = getConfigListEntry(_("Enable parental control"), NoSave(ConfigNothing()))
+   self.list.append(self.changePin)
+  else:
+   self.changePin = getConfigListEntry(_("Change PIN"), NoSave(ConfigNothing()))
+   self.list.append(self.changePin)
    self.list.append(getConfigListEntry(_("Protect services"), config.ParentalControl.servicepinactive))
    if config.ParentalControl.servicepinactive.value:
     self.list.append(getConfigListEntry(_("Remember service PIN"), config.ParentalControl.storeservicepin))

Attached Files


Edited by Taapat, 12 April 2015 - 10:43.


Re: Parental Control #2 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 12 April 2015 - 11:25

Sounds reasonable....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Parental Control #3 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 12 April 2015 - 16:04

And maybe when changing the pin code, in addition to "Please enter the new PIN code", should add a warning that the default code 0000 disable parental control.



Re: Parental Control #4 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 12 April 2015 - 18:24

And yet, in this commit: http://sourceforge.n...77bfe199bdb4f1/ has introduced a bug that does not allow to add plugins entries in menu, if parental contral not enabled (for example CutListEditor).
 
Parental control code: be after plugin append code: http://sourceforge.net/p/openpli/enigma2/ci/8d08bb1a6750c47260f1a7b066a1937e5ea66aa2/tree/lib/python/Screens/MovieSelection.py#l403


Edited by Taapat, 12 April 2015 - 18:28.


Re: Parental Control #5 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 12 April 2015 - 21:18

Sorry I don't understand...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Parental Control #6 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 12 April 2015 - 21:43

https://bitbucket.or...eacc1253efe3dc2

Without this plugins with where = PluginDescriptor.WHERE_MOVIELIST are not available in movielist menu if parental control not enabled.



Re: Parental Control #7 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 12 April 2015 - 22:39

Now i see....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users