15 replies to this topic

[Dimitrij]

Plugin to move/hide menu items.
The basis is taken MenuSort schwerkraft.elitedvb.net

[littlesat]

As this one is based on schwerkraft's we cannot use it... The author from this plugin notified us that it is intended for DMM use only.... (And it is bad made... when made I would prefer 'hotkey' style).

Edited by littlesat, 20 June 2015 - 20:20.

[Rob van der Does]

(And it is bad made... when made I would prefer 'hotkey' style).

Hehe, what are you waiting for? It would indeed be a very good idea to embed this functionality in E2.
As it is now, lacking a better option, I do use 'MenuSort' to hide menu entries I never use and to change the order of several entries.

[littlesat]

Time is sometimes a factor...

In addition I do not see why you should customize the menu??? So motivation is a different factor.

 

Hide menu enigma2 already supports via the level (expert etc...) -and/or- using the parental locked feature. But why should you hide options in the first place? And why should you change the order.

I think it is better to define an extra leavel instead... 

 

Look at the code and you directly do see why it is actually rubish (sorry that I used that word)...

 

From the other hand I already demonstrated with hotkey how it can be done... and also in the extensionmenu, and also plugin menu you can change orders in approx. that way. The same could be used in menu's.... Why should I made it? I think I already demonstrated a style that could work....

Edited by littlesat, 21 June 2015 - 09:45.

[Dimitrij]

Why reinvent the wheel?
Just use this plugin and all .

[littlesat]

We need to reinvent the wheel in the firsr place! As the author of the plugin does not allow to use it on non dmm boxes!!! He personally notified us several years ago....

[Rob van der Does]

Hide menu enigma2 already supports via the level (expert etc...)....

'Level' (menu weight) is the most inflexible way you can think of. It lets the image builder decide what entries you can see.

Let me give you an example: as I never use a (hard)CAM I'm not interested in the CI-interface; so I hide it. The same applies to 'parental lock' and more.
In the GUI of MenuSort you can easily decide which entries you want to hide; this can't be compared with any 'level'.

[littlesat]

Let me give you an example: as I never use a (hard)CAM I'm not interested in the CI-interface; so I hide it. 

->

If you made this correctly... No CI inserted.... Just do not give this option.... No need to manually hide...

 

'Level' (menu weight) is the most inflexible way you can think of. It lets the image builder decide what entries you can see.

->

Exactly..... but in fact you need a custom level.... but this method is never flexible. To make it flexible you should be able to change the order like e.g. we do in hotkey/plugin list/extension (move with < >) and add an option to hide it... and then use a config (per menu) what should be shown (E.g. a ! before the description hide it) and in what order. And only store it when you change it... 

 

Sorry at the moment I have a big lack of time... so I'm not suitable of implementing it.

Edited by littlesat, 22 June 2015 - 15:56.

[Rob van der Does]

Hide menu enigma2 already supports via the level (expert etc...)....

'Level' (menu weight) is the most inflexible way you can think of. It lets the image builder decide what entries you can see.

Let me give you an example: as I never use a (hard)CAM I'm not interested in the CI-interface; so I hide it. The same applies to 'parental lock' and more.
In the GUI of MenuSort you can easily decide which entries you want to hide; this can't be compared with any 'level'.

 
 

If you made this correctly... No CI inserted.... Just do not give this option.... No need to manually hide...

Hehe, then the obvious question is: why hasn't this been made 'correctly' in PLi?

But anyway: this was just an example. Other examples are 'Parental control" and 'Factory reset".
So now that sorting of plugins & extensions has been implemented (very good indeed) I still have the desire to be able to hide entries.
And as long as this has not been implemented, I still need to use the plugin 'MenuSort'.

PS: It would be nice to have adjustable sort options for and in menu's as well.

[littlesat]

The most and quick solution for you is to add a user level that hide the menu's topics you want...

All this level stuff and priority stuff was not a good idea from the beginning....

To make it in a goot way you completely need to rewrite the menu stuff... Which also makes plugins etc not compatible. That is also a factor we have to think about...

In addition hiding menu option is something I think should have low priority...

[Rob van der Does]

Let me give you an example: as I never use a (hard)CAM I'm not interested in the CI-interface; so I hide it. The same applies to 'parental lock' and more.
In the GUI of MenuSort you can easily decide which entries you want to hide; this can't be compared with any 'level'.

If you made this correctly... No CI inserted.... Just do not give this option.... No need to manually hide...

Hehe, then the obvious question is: why hasn't this been made 'correctly' in PLi?

To be more correct: it has only partially been implemented in PLi:
1- If no CAM is inserted, only 'Slot 1' shows (empty of course).
2- If only one CAM has been inserted the slot shows obviously, and now the second, empty slot also shows.

In other words: when one or two slots are empty, the CI-Menu always shows one slot too many.

[Rob van der Does]

Let me give you an example: as I never use a (hard)CAM I'm not interested in the CI-interface; so I hide it.
[/quote]

If you made this correctly... No CI inserted.... Just do not give this option.... No need to manually hide...
[/quote]
Hehe, then the obvious question is: why hasn't this been made 'correctly' in PLi?
[/quote]
 
As it is now there's always at least one CI-slot visual in the menu. On a box with 2 slots this results in:
1- When no CAM has been inserted, slot 1 show in the menu
2- When a CAM has been inserted in slot 1, slot 2 also shows.

So there is some kind of hide-functionality, but it doesn't fully work.

Any chance you improve this?

[Rob van der Does]

See
 CI-slots 1.jpg   69.17KB   1 downloads

after accepting this pull request: https://github.com/l...-PLiHD/pull/422

[littlesat]

Merged....

But just a suggestion....please next time try to avoid the word tweak....

Try to describe whar you change.... Make the list larger in the ci setup screen or so.... Tweak is so general. It only forces you to give a description where you change stuff... Not what and why it is changed....

I'm aware that on the other images it is used many times.... But iat least hear I try to avoid it.... And note I'm also not always good in describing my patches.... includinf typo's and some times describing the incorrect thing...

At least many thanks for the merge suggestion.... Very appreciated!

Edited by littlesat, 17 September 2015 - 06:31.

[Rob van der Does]

Well, I did describe it in full in the comment I made; you could have used that text for the commit.

PS: Next pull request done.

Edited by Rob van der Does, 17 September 2015 - 06:34.

[Rob van der Does]

Please merge https://github.com/l...-PLiHD/pull/423