Jump to content


Photo

Bug in pli


  • Please log in to reply
97 replies to this topic

Re: Bug in pli #81 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 28 January 2016 - 12:48

I think my suggestion is not ugly....

 

You do not want that hidden configs are change for you... so when you toggle something back it stayed as it was.... Autochanges is uggly... (try it you can feel it is not good).... e.g. change something by accident and change it back and then you can re-configure a whole list is not nice at all...

Not true.
In this case, the user knows exactly what it includes settings.
And is responsible for it.

 

And who can not push extra buttons, such as it causes irritation to him, he just lazy people.


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #82 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 January 2016 - 13:42

Then we differ from meaning.... 

 

I still would recommend not to auto change this config and leave it as it is... The value makes no sense at all when hidden... so also totally no reason to change it...

 

the user knows exactly what it includes settings.

->Not agree as when you change per accident you automatically change other stuff and you need to revert two thinks.... Not recommended....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #83 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 28 January 2016 - 13:59

OK, what should I remove in patch?


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #84 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 January 2016 - 14:03

First the message to info is a good idea... ;)

 

Then just add the check as I did in the example for the config...

 

But very first I recommend just to wait a bit....

 

When you miss the reload stuff you can better call the function from your new sources after you change the flag...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #85 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 28 January 2016 - 22:50

[code]
def protectService(self, service):   if not self.blacklist.has_key(service):     self.serviceMethodWrapper(service, self.addServiceToList, self.blacklist) -    if config.ParentalControl.hideBlacklist.value and not self.sessionPinCached: +    if config.ParentalControl.hideBlacklist.value and not self.sessionPinCached and config.ParentalControl.storeservicepin.value != "never":       eDVBDB.getInstance().addFlag(eServiceReference(service), 2)

Correct this bug.


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #86 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 January 2016 - 07:28

Sure! That is a "bug"...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #87 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 29 January 2016 - 07:38

thanks


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #88 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 January 2016 - 07:43

Now we can discuss...

 

1. hide bouquets (try if that invisible flag might be a solution).

2. I understood you want to make a "smart" editor. (just show all, mark e.g. services with OK or color buttons, at the end call the function that hides the services included a reload service list - poobably needed a parameter to that hide function that forces unhide all)


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #89 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 29 January 2016 - 08:00

 

 

1. hide bouquets (try if that invisible flag might be a solution).

 

Yes, this flag it would be a good solution.

Just how competently to change the flag, there is a big question :) .


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #90 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 January 2016 - 09:25

It may need some changes in cpp.... I did not look at it really yet...

 

[offtopic]

I also need a function to stop streams (to other DMM boxes)... to "safe" recordings...


Edited by littlesat, 29 January 2016 - 09:28.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #91 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 8 February 2016 - 09:19

littlesat
	def searchNumber(self, number, firstBouquetOnly=False, bouquet=None):
		bouquet = bouquet or self.servicelist.getRoot()
		service = None
		serviceHandler = eServiceCenter.getInstance()
		if not firstBouquetOnly:
			service = self.searchNumberHelper(serviceHandler, number, bouquet)
		if config.usage.multibouquet.value and not service:
			bouquet = self.servicelist.bouquet_root
			bouquetlist = serviceHandler.list(bouquet)
			if bouquetlist:
				bouquet = bouquetlist.getNext()
				while bouquet.valid():
-					if bouquet.flags & eServiceReference.isDirectory:
+					if bouquet.flags & eServiceReference.isDirectory and not bouquet.flags & eServiceReference.isInvisible:
						service = self.searchNumberHelper(serviceHandler, number, bouquet)
						if service:
							playable = not (service.flags & (eServiceReference.isMarker|eServiceReference.isDirectory)) or (service.flags & eServiceReference.isNumberedMarker)
							if not playable:
								service = None
							break
						if config.usage.alternative_number_mode.value or firstBouquetOnly:
							break
					bouquet = bouquetlist.getNext()
		return service, bouquet

GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #92 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 8 February 2016 - 09:20

To avoid when a number is typed you till can zap to a hidden service?


Edited by littlesat, 8 February 2016 - 09:21.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #93 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 8 February 2016 - 10:16

To avoid when a number is typed you till can zap to a hidden service?

yes.hidden bouquet


Edited by Dimitrij, 8 February 2016 - 10:30.

GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #94 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 8 February 2016 - 17:32

https://github.com/O...nigma2/pull/187


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #95 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 8 February 2016 - 17:36

D.o.n.e.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #96 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 8 February 2016 - 17:46

littlesat

next step(problem)

 

see this:

	def channelSelected(self, doClose = True):
		playingref = self.session.nav.getCurrentlyPlayingServiceOrGroup()
		if config.usage.channelselection_preview.value and (playingref is None or self.getCurrentSelection() and self.getCurrentSelection() != playingref):
			doClose = False
		if not self.startServiceRef and not doClose:
			self.startServiceRef = playingref
		ref = self.getCurrentSelection()
		if self.movemode and (self.isBasePathEqual(self.bouquet_root) or "userbouquet." in ref.toString()):
			self.toggleMoveMarked()
		elif (ref.flags & eServiceReference.flagDirectory) == eServiceReference.flagDirectory:
			if Components.ParentalControl.parentalControl.isServicePlayable(ref, self.bouquetParentalControlCallback, self.session):
				self.enterPath(ref)
				self.gotoCurrentServiceOrProvider(ref)
				self.revertMode = None

if Components.ParentalControl.parentalControl...

 

What does the bouquet of parental control?

 

 
 
What we have is the logic?

1) block all services of the bouquet

2)block the entrance to the bouquet or no?

 

if #2 is  no, this code not need

else need add same number zap/change bouquet/ChannelSelectionEPG

 

maybe this

-			if Components.ParentalControl.parentalControl.isServicePlayable(ref, self.bouquetParentalControlCallback, self.session):

Edited by Dimitrij, 8 February 2016 - 17:47.

GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Bug in pli #97 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 8 February 2016 - 17:51

Sorry I cannot follow this anymore at the moment.... So I've to fully trust you here when you suggested changes... Over the coming days I do not have much time to spend on this...

Principally in enigmaw the channelselection and parental locked is badly designed so the code is really a mess.... It is somehow in a stage of redesign... That is my meaning... But redesigning it is also not possible as plugins may fall too...

Please do not try to change too much here...

When you block a userbouquet I could advice only to block the entrence.... To block all services of a bouquet I think we need to create a different (new) function...

Edited by littlesat, 8 February 2016 - 17:53.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Bug in pli #98 Dimitrij

  • PLi® Core member
  • 9,963 posts

+334
Excellent

Posted 8 February 2016 - 19:13

Now it works block all services of a bouquets.

 

I think it is not necessary:

		self.toggleMoveMarked()
		elif (ref.flags & eServiceReference.flagDirectory) == eServiceReference.flagDirectory:
			if Components.ParentalControl.parentalControl.isServicePlayable(ref, self.bouquetParentalControlCallback, self.session):

all services userbouquet and so are included in the parental control


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users