94 replies to this topic

[Huevos]

During testing both parts were found to be needed. A explanation of the conflicts and test results is given in the thread I linked to.

Sorry if this isn't useful to you.

[littlesat]

The whole thing is a bit cryptic.... So lets see if we need that tuner part....
U
The first patch with the timer ended ai think we wolve it smarter to look at the timer starus... No timer or time needed... (Only build a new list is not really required).... But as tuner ended are now removed from the list I suppose the tuner stuff is not required anymore as far I read the complete story...

Edited by littlesat, 7 February 2016 - 10:20.

[Dimitrij]

Each timer is assigned to the index.

self.nrep_eventlist.extend([(timer.begin,self.bflag,idx),(timer.end,self.eflag,idx)])

 

Then, with this index, a timer is taken from the list.

		for event in self.nrep_eventlist:
			cnt += event[1]
			if event[2] == -1: # new timer
				timer = self.newtimer
			else:
				timer = self.timerlist[event[2]]

timer = self.timerlist[event[2]]

 

And if the timer is not in the self.nrep_eventlist list, then the order of the index is broken.

 

I just fixed it

Please see

 +		self.check_timerlist = []
+		for timer in self.timerlist:
+			 if not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString() and timer.state < TimerEntry.StateEnded:
+				self.check_timerlist.append(timer)
+		self.timerlist = self.check_timerlist[:]
 		idx = 0
 		for timer in self.timerlist:
-			if timer != self.newtimer and not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString():
+			if timer != self.newtimer:
 				if timer.repeated:
 					rflags = timer.repeated
 					rflags = ((rflags & 0x7F)>> 3)|((rflags & 0x07)<<4)

[littlesat]

So creating the new timerlist is mandatory?

 

so 

-            if timer != self.newtimer and not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString():
+            if timer != self.newtimer and not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString() and timer.state < TimerEntry.StateEnded:

is not sufficient?

Edited by littlesat, 7 February 2016 - 12:38.

[Dimitrij]

So creating the new timerlist is mandatory?

 

so 

-            if timer != self.newtimer and not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString():
+            if timer != self.newtimer and not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString() and timer.state < TimerEntry.StateEnded:

is not sufficient?

I did the patch, I hope everything will be ok

https://github.com/O...nigma2/pull/184

[Taapat]

Without going into nuances, but looking only changes I think that create two loop one after the other, with the same large number of checks, definitely is not what can be called a good and optimal solution.

[Dimitrij]

It is simply necessary.
Without this, we will get the wrong timers on the index.
And we can not change the real timer list.

[littlesat]

OK I see... this is about the index... and that is why it is required.... 

Thanks!!!

But can also someone look at this one...

 

https://github.com/O...870657b62d109ea

 

The GML:1 we do not need at all... This is fixed direrently...

 

But about the GML:2.... As far I understood this might fix the overlap tuners when it can be tuned by one and the same tuner.... 

Edited by littlesat, 7 February 2016 - 15:54.

[Dimitrij]

Without going into nuances, but looking only changes I think that create two loop one after the other, with the same large number of checks, definitely is not what can be called a good and optimal solution.

Maybe so, but I'm not sure ....

--- a/TimerSanityCheck.py
+++ b/TimerSanityCheck.py
@@ -81,48 +81,33 @@

-		rflags = self.newtimer.repeated
-		rflags = ((rflags & 0x7F)>> 3)|((rflags & 0x07)<<4)
-		if rflags:
-			begin = self.newtimer.begin % 86400 # map to first day
-			if (self.localtimediff > 0) and ((begin + self.localtimediff) > 86400):
-				rflags = ((rflags >> 1)& 0x3F)|((rflags << 6)& 0x40)
-			elif (self.localtimediff < 0) and (begin < self.localtimediff):
-				rflags = ((rflags << 1)& 0x7E)|((rflags >> 6)& 0x01)
-			while rflags: # then arrange on the week
-				if rflags & 1:
-					self.rep_eventlist.append((begin, -1))
-				begin += 86400
-				rflags >>= 1
-		else:
-			self.nrep_eventlist.extend([(self.newtimer.begin,self.bflag,-1),(self.newtimer.end,self.eflag,-1)])
 
 ##################################################################################
 # now process existing timers
-		self.check_timerlist = []
-		for timer in self.timerlist:
-			 if not timer.disabled and timer.conflict_detection and timer.service_ref and '%3a//' not in timer.service_ref.ref.toString() and timer.state < TimerEntry.StateEnded:
-				self.check_timerlist.append(timer)
-		self.timerlist = self.check_timerlist[:]
 		idx = 0
 		for timer in self.timerlist:
-			if timer != self.newtimer:
-				if timer.repeated:
-					rflags = timer.repeated
-					rflags = ((rflags & 0x7F)>> 3)|((rflags & 0x07)<<4)
-					begin = timer.begin % 86400 # map all to first day
-					if (self.localtimediff > 0) and ((begin + self.localtimediff) > 86400):
-						rflags = ((rflags >> 1)& 0x3F)|((rflags << 6)& 0x40)
-					elif (self.localtimediff < 0) and (begin < self.localtimediff):
-						rflags = ((rflags << 1)& 0x7E)|((rflags >> 6)& 0x01)
-					while rflags:
-						if rflags & 1:
-							self.rep_eventlist.append((begin, idx))
-						begin += 86400
-						rflags >>= 1
-				else:
-					self.nrep_eventlist.extend([(timer.begin,self.bflag,idx),(timer.end,self.eflag,idx)])
-			idx += 1
+			count = idx
+			if timer == self.newtimer:
+				count = -1
+			elif timer.disabled or not timer.conflict_detection or not timer.service_ref or '%3a//' in timer.service_ref.ref.toString()) or timer.state == TimerEntry.StateEnded:
+				self.timerlist.remove(timer)
+				continue
+			if timer.repeated:
+				rflags = timer.repeated
+				rflags = ((rflags & 0x7F)>> 3)|((rflags & 0x07)<<4)
+				begin = timer.begin % 86400 # map all to first day
+				if (self.localtimediff > 0) and ((begin + self.localtimediff) > 86400):
+					rflags = ((rflags >> 1)& 0x3F)|((rflags << 6)& 0x40)
+				elif (self.localtimediff < 0) and (begin < self.localtimediff):
+					rflags = ((rflags << 1)& 0x7E)|((rflags >> 6)& 0x01)
+				while rflags:
+					if rflags & 1:
+						self.rep_eventlist.append((begin, count))
+					begin += 86400
+					rflags >>= 1
+			else:
+				self.nrep_eventlist.extend([(timer.begin, self.bflag, count),(timer.end, self.eflag, count)])
+		idx += 1
 
 ################################################################################
 # journalize timer repeations

[littlesat]

Does the double looping slows it down extremely.... .?

[Dimitrij]

Does the double looping slows it down extremely.... .?

No, not slowing down.
But,i will solve it in the next few days.
Let's wait for checks on users.

[Rob van der Does]

I'm on a very long camping trip in Portugal, so largely off-line (and even when on-line not able to update STB).

So sorry for not chipping in for the time being.

[Frenske]

We will do our best to continue our developing and board activities during your absence Rob.
Enjoy your holiday.

[Europalette]

Good evening everybody,

 

did the option "Enable timer conflict detection" get his "conflict-information" from the "PDC"-information, send by the respective TV-channel?

 

 

Many thanks in advance!

[Europalette]

What means that you integrate the external plugin "VPS-Plugin" to the OpenPLi-Image...