Jump to content


Photo

Enigma2 next-master crashes on dm8000.


  • Please log in to reply
53 replies to this topic

Re: Enigma2 next-master crashes on dm8000. #21 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 24 May 2016 - 12:11

WhenI get a merge request on github I can push it for you... i only have an ipad now...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Enigma2 next-master crashes on dm8000. #22 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 24 May 2016 - 13:03

Well I can make a clone off the master-next and master-for-gcc5

 

Then change the recipes :

 

enigma2.bb

 

to

PV = "2.7+git${SRCPV}"
PKGV = "2.7+git${GITPKGV}"

ENIGMA2_BRANCH ?= "next-master"
GITHUB_URI ?= "git://github.com"
SRC_URI = "${GITHUB_URI}/OpenPLi/${BPN}.git;branch=${ENIGMA2_BRANCH}"

Then change the file :

 

openpli-enigma2-image.bb

 

to

ENIGMA2_PLUGINS = " \
	enigma2-plugin-extensions-audiosync \
	enigma2-plugin-extensions-autobackup \
	enigma2-plugin-extensions-cutlisteditor \
	enigma2-plugin-extensions-graphmultiepg \
	enigma2-plugin-extensions-mediaplayer \
	enigma2-plugin-extensions-mediascanner \
	enigma2-plugin-extensions-moviecut \
	enigma2-plugin-extensions-openwebif \
	enigma2-plugin-extensions-pictureplayer \
	enigma2-plugin-extensions-ppanel \
	\
	enigma2-plugin-pli-softcamsetup \
	\
	enigma2-plugin-systemplugins-fastscan \
	enigma2-plugin-systemplugins-hotplug \
	enigma2-plugin-systemplugins-networkbrowser \
	enigma2-plugin-systemplugins-positionersetup \
	enigma2-plugin-systemplugins-satfinder \
	enigma2-plugin-systemplugins-skinselector \
	enigma2-plugin-systemplugins-softwaremanager \
	enigma2-plugin-systemplugins-videomode \
	enigma2-plugin-systemplugins-videotune \
	enigma2-plugin-systemplugins-osdpositionsetup \
	\
	${@base_contains("MACHINE_FEATURES", "3dtv", "enigma2-plugin-systemplugins-osd3dsetup" , "", d)} \
	${@base_contains("MACHINE_FEATURES", "dvb-c", "enigma2-plugin-systemplugins-cablescan" , "", d)} \
	${@base_contains("MACHINE_FEATURES", "hdmicec", "enigma2-plugin-systemplugins-hdmicec" , "", d)} \
	${@base_contains("MACHINE_FEATURES", "wlan", "enigma2-plugin-systemplugins-wirelesslan", "", d)} \
	\
	${@base_contains('OPENPLI_FEATURES', 'ci', 'enigma2-plugin-systemplugins-commoninterfaceassignment', '', d)} \
	${@base_contains('OPENPLI_FEATURES', 'dvd', 'enigma2-plugin-extensions-cdinfo enigma2-plugin-extensions-dvdplayer', '', d)} \
	${@base_contains('OPENPLI_FEATURES', 'fan', 'enigma2-plugin-systemplugins-tempfancontrol', '', d)} \
	"

If boxes are reflashed after those changes all ok.

 

If users just upgrade the dm8000 or any box which did not had the :

${@base_contains("MACHINE_FEATURES", "osdposition", "enigma2-plugin-systemplugins-osdpositionsetup" , "", d)}

will have to manually install :

opkg install enigma2-plugin-systemplugins-osdpositionsetup

testers and developpers anyway now how. and the image is not an official beta yet so no problem .



Re: Enigma2 next-master crashes on dm8000. #23 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 24 May 2016 - 13:48

I do not think that the right solution is only remove osdposition check in openpli-enigma2-image.bb.
1. The user can manually uninstall osdpositionsetup plugin.
2. If the receiver lack the necessary proc entries, the plugin does not work and does not make sense to install them.

 

I think that right would be in the StartWizard add extra test:

if OverscanWizard is not None:
          wizardManager.registerWizard(OverscanWizard, config.misc.do_overscanwizard.value, priority = 10)


Re: Enigma2 next-master crashes on dm8000. #24 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 24 May 2016 - 18:27

The plug-in should work without the procs...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Enigma2 next-master crashes on dm8000. #25 mx3L

  • Senior Member
  • 616 posts

+79
Good

Posted 24 May 2016 - 18:44

Maybe I'm wrong but I think if it's a plugin and not a part of enigma, enigma2 shouldn't know about it. So it's not imported in StartWizard and registered as wizard, but plugin itself should register as wizard.



Re: Enigma2 next-master crashes on dm8000. #26 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 08:04

The plug-in should work without the procs...

Yes but on for example we do have the overscan which runs only one time after that box is flashed.

 

Later on not anymore but we do not have the wizard into menu systemsettings . So I'm unable to test if it really works or not on dm8000 whitout the proc entry



Re: Enigma2 next-master crashes on dm8000. #27 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 25 May 2016 - 08:56

You can run the plugin any time... When the procs are not there it selects a skin that does not write in the overscan.

Once installed by default it is always there.... So when we ensure it is always fhere I suggest we fully fixed it.

Edited by littlesat, 25 May 2016 - 08:57.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Enigma2 next-master crashes on dm8000. #28 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 09:07

@Littlesat

 

Yes I just find how to make the plugin also avbl in menu since plugin works now whitout proc entry no problem.

 

@mx3L

plugin is an enigma2 systemplugin belonging to pli-e2 not an external.

 

@Taapat

plugin does well work on boxes whitout the proc entry (that is now covered in plugin self).



Re: Enigma2 next-master crashes on dm8000. #29 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 09:24

@Littlesat

 

if You wish I send requests :

1) for oe master-next and master-for-gcc5 like said on :

  http://forums.openpl...ndpost&p=549462

 

2) Included a patch for next-master e2 to show overscanwizard in menu on all stb's. Since it works for all stb's now.

 

 

 

Attached Files



Re: Enigma2 next-master crashes on dm8000. #30 mx3L

  • Senior Member
  • 616 posts

+79
Good

Posted 25 May 2016 - 09:29

@christophecvr

I know that, but it is a "plugin" so it can be not available, for example if you uninstall it as @Taapat mentioned.

 

I was thinking something like this.

https://gist.github....4e8bc63a5b5be20

 

Or we can use instead of wizardManager.registerWizard PluginDescriptor with WHERE_WIZARD.

 

Otherwise very handy utility :)



Re: Enigma2 next-master crashes on dm8000. #31 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 09:54

@mx3L

It's better like Littlesat wan't to have it by default in next-master. It is for pli5 ?

 

You're well right that user may decide to uninstall the plugin then troubles.

for that it needs to be protected , then I would do like @Taapat told.

 

Then we do have:

 

1) the plugin tool always on all stb's by default very useful and it will avoid the question off users who encountering problems with there tv or just new tv. Wathever stb.

2) User may decide to remove the plugin , it will not be loaded anymore and not needed for e2 start



Re: Enigma2 next-master crashes on dm8000. #32 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 10:22

@Littlesat

 

Here with correction the e2 next-master patch should the user uninstall the position setup plugin.

Then it works no crash anymore by default it's installed. If uninstalled no problems.

 

if You wich I make and send the pull requests

Attached Files


Edited by christophecvr, 25 May 2016 - 10:27.


Re: Enigma2 next-master crashes on dm8000. #33 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 11:31

@Littlesat pull request for e2 next-master send.

 

The oe master-next master-for-gcc adaptation will follow If You wan't it . (not required for this e2 next master patch the crash is resolved by this anyway).



Re: Enigma2 next-master crashes on dm8000. #34 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 11:50

@Littlesat I sended all pull requests also for oe-core master-next and master-for-gcc5



Re: Enigma2 next-master crashes on dm8000. #35 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 25 May 2016 - 12:00

I also think that in addition need to make changes that offer mx3L.

 

It seems to me logical that everything related to the plugin, it is best to locate in plugin, rather than in the enigma.


Edited by Taapat, 25 May 2016 - 12:01.


Re: Enigma2 next-master crashes on dm8000. #36 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 12:23

I also think that in addition need to make changes that offer mx3L.

 

they are not required anymore .

 

It seems to me logical that everything related to the plugin, it is best to locate in plugin, rather than in the enigma

 

.This is the case . Start up is from enigma2 and the check to launch the wizard at e2 start is on the right place where all other stuff is.

 But we only launch it if the plugin is installed. And it is Littlesat wishes to have the plugin be default installed he's is right in my opinion.

 However user may uninstall it.



Re: Enigma2 next-master crashes on dm8000. #37 mx3L

  • Senior Member
  • 616 posts

+79
Good

Posted 25 May 2016 - 12:49

@christophecvr

 

Start up is from enigma2 and the check to launch the wizard at e2 start is on the right place where all other stuff is

Not "all other stuff" is there, there are system plugins which register as wizard and are not in StartWizard:

marko@ openpli-enigma2 $grep -E -Irs "registerWizard|WHERE_WIZARD" lib/python/Plugins/SystemPlugins/
lib/python/Plugins/SystemPlugins/OSDPositionSetup/plugin.py:wizardManager.registerWizard(OverscanWizard, config.misc.do_overscanwizard.value, priority = 10)
lib/python/Plugins/SystemPlugins/Videomode/plugin.py:		list.append(PluginDescriptor(name=_("Video wizard"), where = PluginDescriptor.WHERE_WIZARD, needsRestart = False, fnc=(0, VideoWizard)))
lib/python/Plugins/SystemPlugins/NetworkWizard/plugin.py:		list.append(PluginDescriptor(name=_("Network wizard"), where = PluginDescriptor.WHERE_WIZARD, needsRestart = False, fnc=(25, NetworkWizard)))
lib/python/Plugins/SystemPlugins/SoftwareManager/ImageWizard.py:	wizardManager.registerWizard(ImageWizard, backupAvailable, priority = 10)
And it is Littlesat wishes to have the plugin be default installed he's is right in my opinion

Nobody is questioning it.



Re: Enigma2 next-master crashes on dm8000. #38 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 25 May 2016 - 12:56

Thanks!! All merged....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Enigma2 next-master crashes on dm8000. #39 christophecvr

  • Senior Member
  • 3,131 posts

+140
Excellent

Posted 25 May 2016 - 13:07

@mx3L

 

 

Not "all other stuff" is there, there are system plugins which register as wizard and are not in StartWizard:

 

Ok then there are two ways which are used but how I did is one of them generally used in e2 and its safe in the mean time pushed ;)

 

other oe's then openpli-oe-core who uses pli e2 (next-master) can decide self to add the plugin be default or not at start.

 

By e2 it will now be default when using openpli-oe-core  master-next or master-for-gcc5 . Also next-master e2 is default now by openpli-oe-core master-next or master-for-gcc5.



Re: Enigma2 next-master crashes on dm8000. #40 Taapat

  • PLi® Core member
  • 2,332 posts

+120
Excellent

Posted 25 May 2016 - 13:25

It is very strange that in OverscanWizard import is used exception that set OverscanWizard = None.
But, after is used registerWizard that causes error if OverscanWizard == None :wacko:.

 

If we ignore the fact that the user can uninstall the plugin, set to the default settings and get gsod on the restart, then use try in OverscanWizard import does not matter.

Especially if that causes an error anyway.

 

Perhaps if any changes is made, we can discuss and do everything properly and not prevent a single mistake, but leaving others.




1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users