53 replies to this topic

[christophecvr]

It is very strange that in OverscanWizard import is used exception that set OverscanWizard = None.
But, after is used registerWizard that causes error if OverscanWizard == None .

 

If we ignore the fact that the user can uninstall the plugin, set to the default settings and get gsod on the restart, then use try in OverscanWizard import does not matter.

Especially if that causes an error anyway.

 

Perhaps if any changes is made, we can discuss and do everything properly and not prevent a single mistake, but leaving others.

No if the plugin is uninstalled, the plugin will not be used code is away. Then there can not be any gsod anymore.

The startwizard will not try to load to register the overscan wizard as we will run into the exception. and then the OverscanWizard is None.

The Overscanwizard will not be in menu since there is no plugin.

 

p.s. it is already merged in next-master but if You wan't to try on a version next-master from before and apply a patch by You during build it is the patch mentioned on

http://forums.openpl...ndpost&p=549588 which must be used and not the one which was set before. !!

[littlesat]

There is a try/except above that makes a value to None when the plugin is not installed... This was not available previously when the Wizards were initiated... Now this is checked...

[christophecvr]

There is a try/except above that makes a value to None when the plugin is not installed... This was not available previously when the Wizards were initiated... Now this is checked...

Indeed that's why we can't have a gsod

[Taapat]

Now this is checked...

And exactly which commit corrects this?

 

 

@christophecvr I'm not talking about the changes that are merged.
To those changes I myself have pointed out here.

 

I'm talking about the fact that the need to make additional changes offered by mx3L.

If you think that gsod not possible then try uninstal plugin, set to default settings and after the restart to make a start wizard.
I'll be very surprised if you will not get gsod.

[christophecvr]

 

Now this is checked...

And exactly which commit corrects this?

 

 

@christophecvr I'm not talking about the changes that are merged.
To those changes I myself have pointed out here.

 

I'm talking about the fact that the need to make additional changes offered by mx3L.

If you think that gsod not possible then try uninstal plugin, set to default settings and after the restart to make a start wizard.
I'll be very surprised if you will not get gsod.

 

No negatif I did tried that it does work perfect no gsod anymore

 

we do not have gsod when instal and or uninstall plugin see next-master e2

https://github.com/O...its/next-master

[Taapat]

Oh, I missed that you add check in StartWizard.

 

But this check is the first that came to my mind, therefore reading mx3L proposals I agree with him that this stuff would be better to move in the OSDPositionSetup plugin.

[christophecvr]

Oh, I missed that you add check in StartWizard.

 

But this check is the first that came to my mind, therefore reading mx3L proposals I agree with him that this stuff would be better to move in the OSDPositionSetup plugin.

Actually it was You're proposal to have that start check wizard and I directly tried and it worked out. Just a little rule extra Which as the matter off fact uses an already inserted code.

 

p.s. I had that already set before mx3L proposal but then was away for work after I that I just needed to first solve the showing off plugin in menu self for stb's whitout the proc entry.

Edited by christophecvr, 25 May 2016 - 16:05.

[Erik Slagter]

Littlesat, as mx3l already suggests, I think it shouldn't be a plugin in the first place. A plugin is for OPTIONAL functionality. Just embed it into enigma and all problems are solved, in a GOOD way. We shouldn't make things into plugins for the sake of it being a plugin. And then the relevant machine_features can be cleaned up as well. In the next release we will have no receivers left with SoC's that can't do OSD scaling, anyway, maybe the Wetek.

[littlesat]

You're right... but there are even (historically) more 'plugins"  that should be migrated.... 

[Erik Slagter]

Well I guess we have to start "somewhere". Volunteers?

[littlesat]

I prefer to go a bit forward.... and not fix something from the past ....

Note e.g. openvix already migrated GMEPG... is also still a plugin... But in between we fixed more in the existing stuff...

The border between plugin and actual code is weak...

[Erik Slagter]

You can do that up to a certain point where everything is such a mess you'll have to start all over completely. I prefer to keep code on a maintainable level.

 

But maybe someone else would like to volunteer. I guess it isn't such a big job.

[littlesat]

But for the UI interface it does not have really added value...But I can try when I have time to start with the GMEPG and this System plugin... And also e.g. MediaPlayer, AVsetiup, etc....

Or start with just one of them, so the community has an example... and could help us here...

Most of it is of course copy and paste...

Edited by littlesat, 29 May 2016 - 09:43.

[Erik Slagter]

Or start with just one of them, so the community has an example... and could help us here...

Something like that