←  [EN] Third-Party Development

Forums

»

Parental Control

Taapat's Photo Taapat 12 Apr 2015

I apologize if this has been discussed somewhere, but with serch, I did not find such a topic.

 

I do not have the original openpli enigma, but as far as I understand in original is the same.

 

When you first time open the Parental control be visible only choice: "Change PIN".

It is misleading to many users. They think that parental control does not work.

Maybe it would be better, if parental control not enabled, display choice: "Enable parental control".
Something like this:

--- a/lib/python/Screens/ParentalControlSetup.py
+++ b/lib/python/Screens/ParentalControlSetup.py
@@ -65,9 +65,12 @@ class ParentalControlSetup(Screen, ConfigListScreen, ProtectedScreen):
   self.changePin = None
   self.reloadLists = None
   self.list = []
-  self.changePin = getConfigListEntry(_("Change PIN"), NoSave(ConfigNothing()))
-  self.list.append(self.changePin)
-  if config.ParentalControl.servicepin[0].value:
+  if not config.ParentalControl.servicepin[0].value:
+   self.changePin = getConfigListEntry(_("Enable parental control"), NoSave(ConfigNothing()))
+   self.list.append(self.changePin)
+  else:
+   self.changePin = getConfigListEntry(_("Change PIN"), NoSave(ConfigNothing()))
+   self.list.append(self.changePin)
    self.list.append(getConfigListEntry(_("Protect services"), config.ParentalControl.servicepinactive))
    if config.ParentalControl.servicepinactive.value:
     self.list.append(getConfigListEntry(_("Remember service PIN"), config.ParentalControl.storeservicepin))

Attached Files


Edited by Taapat, 12 April 2015 - 10:43.
Quote

littlesat's Photo littlesat 12 Apr 2015

Sounds reasonable....
Quote

Taapat's Photo Taapat 12 Apr 2015

And maybe when changing the pin code, in addition to "Please enter the new PIN code", should add a warning that the default code 0000 disable parental control.

Quote

Taapat's Photo Taapat 12 Apr 2015

And yet, in this commit: http://sourceforge.n...77bfe199bdb4f1/ has introduced a bug that does not allow to add plugins entries in menu, if parental contral not enabled (for example CutListEditor).
 
Parental control code: be after plugin append code: http://sourceforge.net/p/openpli/enigma2/ci/8d08bb1a6750c47260f1a7b066a1937e5ea66aa2/tree/lib/python/Screens/MovieSelection.py#l403


Edited by Taapat, 12 April 2015 - 18:28.
Quote

littlesat's Photo littlesat 12 Apr 2015

Sorry I don't understand...
Quote

Taapat's Photo Taapat 12 Apr 2015

https://bitbucket.or...eacc1253efe3dc2

Without this plugins with where = PluginDescriptor.WHERE_MOVIELIST are not available in movielist menu if parental control not enabled.

Quote

littlesat's Photo littlesat 12 Apr 2015

Now i see....
Quote