Er zijn 8 reacties in dit onderwerp

[LraiZer]

I have enigma2 crash if i select option to stop and delete an instant stream recording.

 

It currently expects stop and delete of an instant stream recording to be ext .ts but mine is .stream instead.

 

I've added a quick temporary hack to my box to fallback to ext .stream to workaround this issue and stop the GSOD for now, until one of the devs can look into fixing this correctly.

 

MovieSelection.py

def createMoveList(serviceref, dest):
	#normpath is to remove the trailing '/' from directories
	src = isinstance(serviceref, str) and serviceref + ".ts" or os.path.normpath(serviceref.getPath())
	if not os.path.exists(src):
		src = isinstance(serviceref, str) and serviceref + ".stream" or os.path.normpath(serviceref.getPath())

Replicate:

[ActionMap] Keymap 'InfobarInstantRecord' -> Action = 'instantRecord'

[TIMER] Filename calculated as: '/media/usb/movie/20210126 1210 - ITV - instant record'

[eMP3ServiceRecord] prepare filename /media/usb/movie/20210126 1210 - ITV - instant record.stream

[TIMER] start recording on tuner: (fallback) stream

[ActionMap] Keymap 'InfobarInstantRecord' -> Action = 'instantRecord'
[Screen] Warning: Skin is missing element 'autoresize' in <class 'Screens.MessageBox.MessageBox'>(Stop and delete recording: - instant record).
[ActionMap] Keymap 'MsgBoxActions' -> Action = 'ok'.


[TIMER] stop recording on tuner: (fallback) stream
[eMP3ServiceRecord] stop recording
instantRecord stop and delete recording:  instant record

DEBUG: working now with hack!

[MovieSelection] DEBUG moved: ('/media/usb/movie/20210126 1210 - ITV - instant record.stream', '/media/usb/movie/.Trash/20210126 1210 - ITV - instant record.stream')
[MovieSelection] DEBUG moved: ('/media/usb/movie/20210126 1210 - ITV - instant record.stream.meta', '/media/usb/movie/.Trash/20210126 1210 - ITV - instant record.stream.meta')

[betacentauri]

Please post crash log

[WanWizard]

I can't reproduce it, what exactly was recorded? If I make an instant recording, I get:

-rw-r--r--    1 root     root           174 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.eit
-rw-r--r--    1 root     root      22332520 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.ts
-rw-r--r--    1 root     root           416 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.ts.ap
-rw-r--r--    1 root     root            12 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.ts.cuts
-rw-r--r--    1 root     root           280 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.ts.meta
-rw-r--r--    1 root     root         11856 Jan 26 14:25 20210126_1425_-_ITV_HD_-_NEW__JUDGE_RINDER.ts.sc

no problem?

[LraiZer]

As reported [eMP3ServiceRecord] records my streamed channel and saves the recording with the filename ext .stream, not as occurs with a normal channel recording which saves the recording with the ext .ts

 

[MovieSelection] attempts to delete this streamed recording with the assumption that every recording always has a filename ext .ts when this is not the case. Streamed recordings by [eMP3ServiceRecord] have ext .stream

 

 

 

Bijgevoegde Bestanden

•  enigma2_crash.log   30,31K   8 Aantal bijlagen

[WanWizard]

Ah, it is recording a stream, not a DVB broadcast.

[betacentauri]

Not very easy to solve. The RecordTimerEntry includes the filename without the extension (.ts, .stream). Adding the extension to the filename is easy, but that can have several side effects. So better don't go this way even it's the nicer one.

 

Then in MovieSelection a ".ts" is added to the filename:
https://github.com/O...lection.py#L149

How to find out, that it is a .stream and no .ts file? Use a "file exists" function?

 

Or maybe better add a new field to the timer entry with the extension of the file? But then you also need to change some functions which might cause trouble in some plugins...

 

@littlesat: Do you have a good idea?

Veranderd door betacentauri, 27 januari 2021 - 18:22

[Dimitrij]

Maybe startswith serviceref...

or

'%3a//' in serviceref

Veranderd door Dimitrij, 27 januari 2021 - 19:59

[betacentauri]

No, don’t work. When instant recording is stopped and the file should be deleted, the createMoveList is called with a string (even if the variable is called serviceref). And the string contains the filename without the extension.
Maybe add a third parameter “filename_extension” in the procedure createMoveList with default value “.ts”. Or similar...

[LraiZer]

Maybe just add similar to the current createMoveList code that checks for ext candidate ('.ap', '.cuts', '.meta', '.sc') and simply check file exits for the currently known candidates as src_ext ('.ts', '.stream') and default to '.ts'. This is similar to the workaround example shown in post #1 which has temporarily fixed it for me at the moment.