23 replies to this topic

[scriptmelvin †]

I tried a repeating PiP zap timer today. I noticed two issues:

1. In Single EPG, the line on which the timer is set is blank
2. The zap happens, but without PiP

I tracked down 1:

• There is a list of pixmaps to display for timers in Components.EpgList.py
• An index into this list is calculated in RecordTimer.py:isInTimer
• In my case, the index was 49, but the list is only 35 long

So a bunch of PiP pixmaps is missing (5x repeating PiP zap, 5x repeating PiP zap & record, 5x repeating PiP record).

 

I duplicated the last five pixmaps in Components.EpgList.py three times, and the lines became visible in Single EPG. And new repeating PiP zap timers worked properly (so 2 also solved).

 

What would be the best way to handle this?

• Create the missing pixmaps (I could do them for skin_default and PLi-Full(Night)HD, but obviously not for all skins)
• Catch IndexError so at least the timer works properly
• Do both of the above
• Do nothing because nobody uses it anyway

Edited by scriptmelvin, 1 June 2022 - 21:54.

[Dimitrij]

PiP is used if available.

There is a free tuner or not.

Show this code.

[scriptmelvin †]

PiP is used if available.

No, it is not, because RecordTimer.py:isInTimer throws an IndexError
 

There is a free tuner or not.

Yes, there is a free tuner. If I open a PiP manually to the same service it works.
 

Show this code.

What do you mean?

[Dimitrij]

https://github.com/O...dTimer.py#L1267

Edited by Dimitrij, 2 June 2022 - 10:23.

[scriptmelvin †]

Yes, type_offset = 30 now.

 

Then, this line, type_offset = 45 now.

 

Then, this line, type_offset = 49 now, and the pixmap list is only 35 long.

[Dimitrij]

https://github.com/O...dTimer.py#L1267

-if x.pipzap:
+if x.pipzap and not x.repeated:				
    type_offset = 30

 

 

[scriptmelvin †]

That works

 

But it shows the repeated-zap icon:  repzapclock.png   441bytes   1 downloads

 

Not the (non-existant) repeated-PiP-zap icon.

 

Good enough for me though. Thanks!

Edited by scriptmelvin, 2 June 2022 - 11:37.

[Dimitrij]

[RecordTimer] isInTimer - fix not visible icons pipzap repeat

[PartnerboxEPGList] isInTimer - fix not visible icons pipzap repeat

[WanWizard]

Merged.

[scriptmelvin †]

PiP zap only works in the same session in which the timer was created. When enigma2 is restarted, it zaps without PiP again. The cause is that self.InfoBarInstance = None in this line.

 

That seems to be caused by the fact that when the timer list is read from timers.xml at enigma2 startup, InfoBar is not yet instantiated, so self.InfoBarInstance is set to None here.

[scriptmelvin †]

No takers?

[WanWizard]

Appearently not . It is far above my pay grade, so I have to pass...

[Dimitrij]

PiP zap only works in the same session in which the timer was created. When enigma2 is restarted, it zaps without PiP again. The cause is that self.InfoBarInstance = None in this line.

 

That seems to be caused by the fact that when the timer list is read from timers.xml at enigma2 startup, InfoBar is not yet instantiated, so self.InfoBarInstance is set to None here.

How to check it (example)?

[littlesat]

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

Edited by littlesat, 18 June 2022 - 07:31.

[Dimitrij]

test

[ims]

 I also personally do not see a real added value in a pip zap timer..

I am using it time from time ...

[Dimitrij]

[RecordTimer] always check InfoBarInstance

[scriptmelvin †]

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

 
IMHO a feature should either work properly, or be removed. Added value is to be determined by users. I find it quite useful.
 

%5BRecordTimer%5D always check InfoBarInstance

Thank you, that is more or less how I implemented it . The import is not needed though, already present here.

[Pr2]

Sounds like this was never implemented in the right way…. I also personally do not see a real added value in a pip zap timer..

 

One of the idea behind PiP zap was that TV show never starts at the expected time, so by having a PiP zap you can keep an eye on your future TV show and really zap to it when it effectively start.

[Erik Slagter]

Yeah, I understand