domi-sat

Hey, kein Problem.

Ich freue mich, dass meine Änderungen akzeptiert wurden und hoffe, dass diese bald in die Versionen portiert werden.

Vielen Dank!

I removed the "doSave" stuff because it was only used by the two lines you added after "pip = InfoBar.instance.session.pip" during the (over)refactoring of the https://github.com/O...b0ae44374759877 commit.

My IDE (IntelliJ) and manual search confirmed that there is no usage, so I thought it is safe to remove.

I understand the idea and information of https://github.com/O...93022f724457c09 and still use this workaround.

Yes, I can do a merge request.

Please be patient as I am going to sleep now

I understood that, but it seems that you didn't understand my code.

I do NOT use the "hide" method and my code does not change the size to 0x0 pixels! The code of https://forums.openp...dpost&p=1618477 still uses your workaround with resizing and moving to 16x16px.

The fix is not just for my ET9000. It is also for my Vu+ Duo4K and the GBQuad4k of @Jork.

Please see picture from here: https://forums.openp...dpost&p=1615157

Which side effects do you mean?

Was it no mistake that you refactored the code to use the resize method that also calls "setSizePosMainWindow"? I think it must be a mistake.

The resize does not resize the PiP to hidePosition size if PiP is not "standard" or "cascade". Please review your commit from 2017 and you will see it.

The call of "setSizePosMainWindow" is the problem here. It increases the main window to fullscreen after was minimized to MiniTV what causes the problem on my and @Jork s recievers.

I think it would be easier if you do it on your own with your tools, but ok, here you go.

As you see I didn't change much and don't use other methods than before but just reverted parts of your commit and fixed the problems.

The new method I added is just there to make clear that you may not use the other "move" method in this specific case.

FYI:

You removed the lines "self["video"].instance.move(ePoint(x, y))" and "pip["video"].instance.move(ePoint(x, y))" in your commit and that was correct and important.

With this lines you get other position problems.