9 replies to this topic

[hw9258]

This commit adds VOD number seek when there are VOD channels with URLs ending in mp4 or mkv.

 

https://github.com/O...8d7c44d4ad8ee17

		seekable = self.getSeek()
		if seekable:
			length = seekable.getLength() or (None, 0)
			if length[1] > 0:
				key = int(number)
				time = (-config.seek.selfdefined_13.value, False, config.seek.selfdefined_13.value,
					-config.seek.selfdefined_46.value, False, config.seek.selfdefined_46.value,
					-config.seek.selfdefined_79.value, False, config.seek.selfdefined_79.value)[key - 1]

				time = time * 90000
				seekable.seekRelative(time < 0 and -1 or 1, abs(time))
				return

The problem is that when an IPTV channel URL is down either occasionally or permanently, then zapping out of the black screen with numbers is not possible. It was also discussed here https://forums.openp...is-not-working/

 

The detection for VOD is in https://github.com/O...cemp3.cpp#L1212

RESULT eServiceMP3::isCurrentlySeekable()
{
	int ret = 3; /* just assume that seeking and fast/slow winding are possible */

	if (!m_gst_playbin)
		return 0;

	return ret;
}

which just assumes that all URLs are seekable, perhaps a better solution would be to check if the 4097 URL ends with mp4 or mkv but I don't have enough cpp knowledge to fix it.

Since VOD is not useful for the current use case, the VOD number seek is commented out in Screens/InfoBarGenerics.py.

Thanks in case someone has the time and expertied to look into it.

 

[Dimitrij]

What exactly needs to be fixed?

[Dimitrij]

Reinstate option to enable/disable VOD skip buttons

[littlesat]

That seems only to change the left and right button..... but when it is VOD and this is included in the channels list then indeed the number buttons become the step skip buttons... That is indeed how it works now... then you indeed 'offer' the number zap... In addition there is no way to determine if a 'stream' might be step-skippable.

 

Maybe a better way to keep the numberzap.... and find a 'way' when it is VOD and could be skippable... that you have a way to put it in a 'skippable' mode instantly by a kind of button press....

Edited by littlesat, 1 November 2024 - 11:36.

[DimitarCC]

The main idea of VoD items to be in main channels list is horrible....

That is not the place where VoD should be in general.....

[littlesat]

+1

[hw9258]

Thank you all for the replies and the contributions to the image!

What exactly needs to be fixed?

For example, userbouquet.favourites.tv

#NAME Favourites
#SERVICE 1:0:19:283D:3FB:1:C00000:0:0:0::Das Erste HD
#DESCRIPTION Das Erste HD
#SERVICE 4097:0:1:0:0:0:0:0:0:0:http%3a//distribution.bbb3d.renderfarming.net/video/mp4/bbb_sunflower_1080p_60fps_normal.mp4:bbb_sunflower_1080p_60fps_normal.mp4
#DESCRIPTION bbb_sunflower_1080p_60fps_normal.mp4

Channel number 1 is 19.2 east satellite channel Das Erste HD and number 2 is a VOD file with a URL ending in mp4.

The first problem is that if you select number 2, then you can seek within the streaming mp4 with 1,4,7 and 3,6,9 like a recording and you can no longer press number 1 to go back to Das Erste HD. It is acceptable for those that have VOD on their channel lists but for those that do not, it overrides default zapping behaviour.

A second problem is that because the code in servicemp3.cpp assumes all 4097 URLs are seekable, if you zap to an IPTV channel which is not working, you can no longer zap to another channel using number buttons but only with channel selection up/down arrow buttons.

 

Possible solutions could be either

• disable VOD number seek entirely
• Move it to long button press but it could be annoying to long press 3, 6 or 9 multiple times to seek
• Move it to the two << REW/FFW >> buttons only and use middle time skip config.seek.selfdefined_46.value
• Make it a configurable option defaulting to disabled so that those that have VOD on channel lists can enable
• Improve detection of VOD in channel service reference either in InfoBarGenerics.py or servicemp3.cpp maybe by searching for channel 4097 URLs ending in mp4/mkv.

 

In addition there is no way to determine if a 'stream' might be step-skippable.

Usually VOD end in .mp4 or .mkv like this

#SERVICE 4097:0:1:0:0:0:0:0:0:0:http%3a//distribution.bbb3d.renderfarming.net/video/mp4/bbb_sunflower_1080p_60fps_normal.mp4:bbb_sunflower_1080p_60fps_normal.mp4

so maybe by detecting channel service reference 4097 URLs ending in mp4/mkv.

[littlesat]

In general doing vod in normal channel lists is not done… better ‘put’ them in a movie list or plugin etc….

Edited by littlesat, 3 November 2024 - 08:51.

[hw9258]

I agree littlesat, VOD seem to be present only in channel lists supplied by "special" IPTV providers.

 

The side effect of VOD number button seek is mainly that when a publicly available IPTV channel in a bouquet is down, then you can only exit the black screen using UP/DOWN and OK which are not familiar steps to some users, they are used to press 1 to go back to the first channel.

 

So if others do not mind, maybe the commit https://github.com/O...8d7c44d4ad8ee17 could be reverted to restore universal number zapping.

Edited by hw9258, 3 November 2024 - 18:06.

[Huevos]

I agree littlesat, VOD seem to be present only in channel lists supplied by "special" IPTV providers.

 

The side effect of VOD number button seek is mainly that when a publicly available IPTV channel in a bouquet is down, then you can only exit the black screen using UP/DOWN and OK which are not familiar steps to some users, they are used to press 1 to go back to the first channel.

 

So if others do not mind, maybe the commit https://github.com/O...8d7c44d4ad8ee17 could be reverted to restore universal number zapping.

If you use M3UIPTV plugin the VoD will not be in channel lists.

 

Any hijacking of number keys in channel list for VoD should be removed. It is a horrible hack.