44 replies to this topic

[Dimitrij]

I have long wanted to ask why when we press the HELP button, I see a lot of duplicate lines, many of them are simply not on the remote control?

Attached Files

•  1.jpg   103.72KB   0 downloads
•  2.jpg   103.81KB   0 downloads

Edited by Dimitrij, Yesterday, 06:58.

[ims]

I have long wanted to ask why when we press the HELP button, I see a lot of duplicate lines, many of them are simply not on the remote control?

Because a long time ago, one person, who was completely impossible to reason with (constantly getting offended and demanding apologies), changed it to this form without listening to other opinions on the matter. I once wrote here what is needed for it, but I'm too lazy to look for it, as it was at least 3-4 years ago, and I don't remember it anymore.

[Dimitrij]

 

but I'm too lazy to look for it,

Maybe you remember ?

 

This? https://github.com/O...c4877fb49b631e7

Edited by Dimitrij, Yesterday, 08:34.

[DimitarCC]

Help system is kind of fu**ed up in Pli unfortunately...

Besides there are duplications there are a lot of missing help support in screens.

Well i compare it with OE-A build where there are much more help entries and no duplications....

[littlesat]

Some tried to optimize it and it wasn’t me… and this is the result…
Maybe we better remove it totally as actually it does not have a real added value at all… and use the help key for something new… a real feature…

Edited by littlesat, Yesterday, 08:43.

[ims]

 

 

but I'm too lazy to look for it,

Maybe you remember ?

 

This? https://github.com/O...c4877fb49b631e7

 

yes ...

[ims]

The problem is that this person started displaying all options for a given function, regardless of whether the remote control being used even has the corresponding button.

So, to exaggerate, if a given function is assigned to 10 different buttons on 10 different boxes, we see all 10 options in the HELP.

 

Before this changes it worked standardly...

Edited by ims, Yesterday, 09:17.

[Huevos]

Some tried to optimize it and it wasn’t me… and this is the result…
Maybe we better remove it totally as actually it does not have a real added value at all… and use the help key for something new… a real feature…

You really can't be serious.

[Huevos]

Like @DimitarCC says, help is completely screwed in PLi. In other distros it works properly, but like I said in the other thread PLi never merges from other images and just sits around waiting for PR's.

 

In other distros it looks like this:

 

Attached Files

•  1.jpg   85.35KB   0 downloads
•  2.jpg   78.15KB   0 downloads

[littlesat]

It looks like this doesn't really work anymore...

 

https://github.com/O...0ff036bc7fe394a

[littlesat]

Like @DimitarCC says, help is completely screwed in PLi. In other distros it works properly, but like I said in the other thread PLi never merges from other images and just sits around waiting for PR's.

In other distros it looks like this:

 

->

 

Yes it is screwed up.. But at least at OpenATV it looks now extreme complicated... Maybe these days images could work better together and somehow merge these days so we can free-up some time...

 

And from the other point all forked here and only a few (including you) merge back.... again a fork that is going on their own is an disadvantage of Open Source...

 

Sorry my time and patience is now limited... As far I analyze it the 'exist' stuff cannot work anymore for some reason...

 

E.g. below an example what is compared now in exist... Mayby IMS can look at that?

 

  ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('mainMenu', 'Enter main menu...')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('showEventInfo', 'Show EPG...'), ('showEventInfoSingleEPG', 'Show single service EPG')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('instantRecord', 'Instant recording')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('audioSelection', 'Audio options...')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('activateRedButton', 'Red button...')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('timerSelection', 'Timer selection...')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('vmodeSelection', 'Letterbox zoom')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('subserviceSelection', 'Subservice list...')]

    ('displayHelp', <Tools.BoundFunction.boundFunction object at 0xb126f520>) [('nextSubservice', 'Switch to next sub service'), ('prevSubservice', 'Switch to previous sub service')]

Edited by littlesat, Yesterday, 10:41.

[FRAP]

Hello now I have updated my old duo2 and it is not loading.The big and small spinner is spinning in turn.I rolled back to an earlier version.Something is broken....

[Huevos]

 

Like @DimitarCC says, help is completely screwed in PLi. In other distros it works properly, but like I said in the other thread PLi never merges from other images and just sits around waiting for PR's.

In other distros it looks like this:

 

->

 

Yes it is screwed up... And maybe images could work better together and somehow merge these days so we can free-up some time...

 

That is a major change. So you need to forget about it for PLi-9.1.

[ims]

It looks like this doesn't really work anymore...

 

https://github.com/O...0ff036bc7fe394a

It can't either, as it was later corrupted/reworked...

[littlesat]

It can't either, as it was later corrupted/reworked...

-> 

Likely later and it looks like the big mapping stuff was changed afterwards... Maybe already partly adjusted to the forks...

[littlesat]

Wierd... when I compare Vix's ActionMap.py with hours... there is not  really much difference...

 

https://github.com/O...ts/ActionMap.py

https://github.com/O...ts/ActionMap.py

Edited by littlesat, Yesterday, 11:28.

[Dimitrij]

Wierd... when I compare Vix's ActionMap.py with hours... there is not  really much difference...

 

https://github.com/O...ts/ActionMap.py

https://github.com/O...ts/ActionMap.py

only

Vix'

		if not type(contexts) is list:
			contexts = [contexts]

PLi

		if isinstance(contexts, str):
			contexts = [contexts]

Edited by Dimitrij, Yesterday, 11:36.

[littlesat]

I have it working with the OpenVix help screen stuff here, except for the arrow at the remote control. It only doesn't work with our default skins as the screen changes (at least it does not crash). It does work for the e2os skin.

 

B.t.w. HelpMenuList.py is in OpenVix in Sources... not in the Components root, which is somehow wrong...

And it is still kind of strange that the key you press the system jumps to... You can not really navigate... so work-in-progress...

 

I can merge, it does not crash.... But I'm afraid to close to the release.

Edited by littlesat, Yesterday, 12:18.

[littlesat]

I merged something... but these are the things I currently observe as an 2do

 

1. We need a new screen in the default skins as now it only works in the E2OS skin (but no crash)

2. The Arrow on the remote is missing here. 

3. Up/Down/left/Right does go to the 'key' and not navigate

 

Maybe those who made it can help to get a quick fix... Otherwise for 9.1 we could still revert this one.

 

Sorry I cannot do it completely alone  Time is gone...

Edited by littlesat, Yesterday, 12:35.

[littlesat]

As far I can see I now get it fully working... except for a missing picture I could not find:

 

"yellow_circle23x23.png"

 

Then on the remote we also see circles + it look like we can remove all the 'legacy stuff' in the skins in regards to the helpscreen (also for the E2OS skin).

 

I also adjusted the standard default skin.