52 replies to this topic

[WanWizard]

Hello OpenWeather weather in version 8.3 works very well. But in version 9.0 and in night builds it doesn't want to work.

 

Don't hijack someone elses topic. If you have something to report, open a new topic for it,

[littlesat]

But maybe related as we might have more plugins… especially those that did cover configs not on a standard way (they included tricks) that may behave deviates due to the config changes.

[littlesat]

Real solition for this issue just merged. Which also demonstrates less code can do more as only lines (32) were removed.
https://github.com/O...0b84962a9c117eb
And actualy even not all features are used here as there are stil even more lines that can be removed…

Edited by littlesat, 11 December 2024 - 08:38.

[Stan]

Thanks for fhat.

 

Is the REWIND / FORWARD navigation related?

 

With FORWARD you get to the last option of the selected list element. That's fine.

You would expect REWIND doing the opposite. But it jums to first element in the listbox instead...

[Stan]

[...] Which also demonstrates less code can do more as only lines (32) were removed.

 

Unfortunately, it also demonstrates, that when removing code, you break things if not properly tested.

 

By removing the line

			"ok": self.keyOK,

the file/folder selection.is gone.

Edited by Stan, 11 December 2024 - 11:30.

[littlesat]

There is an issue with the new configuratie. Ok is now toffel/select list…so somehow the ok key Needs to be defined to another key somehow or made a different way.

Edited by littlesat, 11 December 2024 - 21:38.

[Stan]

Maybe we can workaround without re-assigning the OK button.

 

After this morning's patch, instead of file/folder selection the keyboard for manual entering the path comes up. This surely can be adapted.

For further code optimization, the myFileList module could be removed from the plugin, as a similar module is already in Enigma.

- from .myFileList import FileList as myFileList
+ from Components.FileList import FileList as myFileList

[Beeker]

Thanks for fhat.

 

Is the REWIND / FORWARD navigation related?

 

With FORWARD you get to the last option of the selected list element. That's fine.

You would expect REWIND doing the opposite. But it jums to first element in the listbox instead...

 

Removing KEY_REWIND from NavigationActions addresses the issue.

diff --git a/data/keymap.xml b/data/keymap.xml
index 9183e0194..fd55710ad 100644
--- a/data/keymap.xml
+++ b/data/keymap.xml
@@ -41,7 +41,6 @@
        </map>
 
        <map context="NavigationActions">
-               <key id="KEY_REWIND" mapto="top" flags="m" />
                <key id="KEY_CHANNELUP" mapto="pageUp" flags="mr" />
                <key id="KEY_UP" mapto="up" flags="mr" />
                <key id="KEY_REWIND" mapto="first" flags="m" />

File in:

/usr/share/enigma2/

Attached Files

•  keymap.xml   39.99KB   1 downloads

Edited by Beeker, 12 December 2024 - 08:46.

[Stan]

Thanks.

 

I suppose, for consistency, the entry

		<key id="KEY_FASTFORWARD" mapto="bottom" flags="m" />

should be removed too from keymap.mxl...

[littlesat]

The keymap indeed might need additional upgrades.

[Stan]

The issue was introduced with this commit.

 

https://github.com/O...61dc1035834f182

 

@littlesat Can you revert it? (only the changes to keymap.xml)

Edited by Stan, 13 December 2024 - 10:23.

[littlesat]

No, I cannot revert it as this is mandatory for other changes in Enigma2 itself..

 

I'm also lost with this as I do not use this plugin it is also hard for me to test (by developbox does currently not have a display).... Better fix the plugin and adjust the plugin so it will work again.

 

I always hated that plugins were using configs also in a lot of time in other dedicated screens with lots of exceptions and hacks.... I suggest this is a demonstration why I hate this.

Edited by littlesat, 13 December 2024 - 11:03.

[Stan]

It's not just about this plugin. It affects all menues.

 

Try it yourself, for instance the setup screen "Customize".

Edited by Stan, 13 December 2024 - 11:29.

[littlesat]

Resolved I suggest.... and be aware this was wrong for a long long long time. We commented it 'out' in the past and it was re-enabled.... while it should be assigned to different keys.

 

https://github.com/O...eacae0e1062ba78

Edited by littlesat, 13 December 2024 - 12:04.

[Stan]

@littlesat, Now KEY_NEXTSONG and KEY_PREVIOUSSONG are assigned twice!

 

I would leave it "commented out", as it was before.

Edited by Stan, 13 December 2024 - 13:07.

[Stan]

... or change it to KEY_PREVIOUS / KEY_NEXT instead.

Edited by Stan, 13 December 2024 - 13:25.

[Stan]

But KEY_PREVIOUS / KEY_NEXT would break text inputs.

 

So, leaving them commented out is the best solution ATM.

[littlesat]

Were do you see the 'SONG' buttons assigned twice.... I tested it here and here it worked.... 

 

OK I see it now.... also crasy me...

 

<key id="KEY_PREVIOUSSONG" mapto="top" flags="m" />

<key id="KEY_REWIND" mapto="first" flags="m" />

<key id="KEY_FASTFORWARD" mapto="last" flags="m" />

<key id="KEY_NEXTSONG" mapto="bottom" flags="m" />

 

 

|< becomes top... go to the first config (previous song)

>| becomes bottom... go to the last config (next song)

>> becomes next last item config, or last in text

<< becomes first item within config or first in text....

 

I will remove the double assignment to next song and previoussong... they were 'hidden' in the keyboard section.

 

At least here it works all fine now...

 

Commented out is not an issue I suggest....

 

https://github.com/O...2e687188f4293f4

 

As in enigma2 'python' it was stored inside a dict it could be somehow pseudo random behavior due to this.

Edited by littlesat, 13 December 2024 - 17:07.

[Stan]

Have you tested KEY_NEXTSONG and KEY_PREVIOUSSONG on a keyboard?

Edited by Stan, 13 December 2024 - 18:37.

[littlesat]

By go to that custumize setup and press rhe |< and >| buttons.