39 replies to this topic

[Stan]

Leaving the setup screen "Customize" with the "Cancel" button, always pops the question "Really close without saving settings?".

That shouldn't be the case if nothing has been changed, right?

[WanWizard]

That should be adressed in the current develop image.

[littlesat]

Leaving the setup screen "Customize" with the "Cancel" button, always pops the question "Really close without saving settings?"

->

I try to verify this... but I cannot confirm this... Here no popup when I do not change anything...  As far I know the issue behind this was also resolved.

To verify it I might need more information... (snapshots from your settings or settings file).

 

Did you try it right after you used the startupwizard... as in code from earlier today not everything was saved and then you might get into this behavior.

Edited by littlesat, 9 December 2024 - 16:08.

[ims]

fixed in develop after help screen code merged

[Stan]

It happens after restoring a backup.

[WanWizard]

Once? Or every time?

 

I can imagine that if you restore settings from an older backup, some values may have changed, which in turn makes config think they were changed interactively. But if that is the case, it shouldn't happen if you enter the setup a second time ( after a restart of Enigma to make sure the settings are saved ).

 

I flash and restore all the time, can't say I've observed this issue.

[ims]

Once? Or every time?

 

I can imagine that if you restore settings from an older backup, some values may have changed, which in turn makes config think they were changed interactively. But if that is the case, it shouldn't happen if you enter the setup a second time ( after a restart of Enigma to make sure the settings are saved ).

 

I flash and restore all the time, can't say I've observed this issue.

As I wrote - when was merged code for Help screens, it works well now (develop) un Customize too.

[Stan]

It works well until I restore the backup. After that it always asks for confirmation. No matter if I save the config and restart Enigma.

 

There must be something in the settings file, that provokes it.

[WanWizard]

I can imagine that if you restore settings from an older backup, some values may have changed, which in turn makes config think they were changed interactively. But if that is the case, it shouldn't happen if you enter the setup a second time ( after a restart of Enigma to make sure the settings are saved ).

 

which (maybe) means that as long as you don't update that specific config value, it doesn't save it, so it happens again next time, until you save it?

 

edit: no clue about the code, I'm juist trying to think logically...

Edited by WanWizard, 9 December 2024 - 18:29.

[Stan]

Right. I think I found the culprit. It's the option "Show setup default values".

 

When it's set to "Don't show default", you can reproduce the issue.

[littlesat]

Need to check if settings are saved after a restore…

[Stan]

The settings are saved. But this particular option had no value:: "config.usage.setupShowDefault="

Edited by Stan, 9 December 2024 - 20:25.

[Stan]

So it's not saved correctly...

Edited by Stan, 9 December 2024 - 20:43.

[littlesat]

And what line was it in your backup?
Thanks for your patience!

Edited by littlesat, 9 December 2024 - 21:19.

[Stan]

The line in the backup (settings-file) was "config.usage.setupShowDefault=" (without value!)

 

You can generate it by setting "Show setup default values" to "Don't show default" in the Costumize menu.

 

[Stan]

The parameter was implemented with this commit:

 

https://github.com/O...0c852541c200dbe

[littlesat]

Thanks… now I can investigare. First wierd thing is in setup it does not have a value why you have a value.

Edited by littlesat, 10 December 2024 - 00:03.

[littlesat]

One option in the config list is an empty string… I’m afraid that cannot work… this results in an empty string at the config. This should have Some string at least….

[Dimitrij]

	config.usage.setupShowDefault = ConfigSelection(default="spaces", choices=[
		("", _("Don't show default")),
		("spaces", _("Show default after description")),
		("newline", _("Show default on new line"))

need set

default=""

 

or rename value,e.g.

("empty", _("Don't show default"))

[littlesat]

Indeed something like that.