39 replies to this topic

[littlesat]

FYI https://github.com/O...b62d3cf9923eb3f (resolved... but you might get it still just once due the so called chicken/egg syndrome).

+ https://github.com/O...c8271fbfa4f0b86

Edited by littlesat, 10 December 2024 - 08:44.

[Stan]

I would choose the other way to fix it:

	config.usage.setupShowDefault = ConfigSelection(default="", choices=[
		("", _("Don't show default")),

Because this is the way it's done with ALL settings. (when a value is the default, there's no need to save it in the settings file)

Edited by Stan, 10 December 2024 - 08:52.

[Stan]

And in addition, it's compatible with the current settings or backups. It will work right away - no need to change and save once.

[Dimitrij]

I advise you never to use an empty value.

It can cause potential problems.

 

Empty value example:

config.usage.show_second_infobar = ConfigSelection(default="0", choices=[("", _("None"))] + choicelist + [("EPG", _("EPG"))])

https://github.com/O...geConfig.py#L87

Edited by Dimitrij, 10 December 2024 - 09:15.

[Stan]

Thanks Dimitrij for clarification. And thanks littlesat for the fix.

[Dimitrij]

	audio_language_choices = [
		("", _("None")),

But here it is a default.

[Stan]

And does it cause problems?

[littlesat]

FYI

 

https://github.com/O...7b322684584f0c0

[littlesat]

When it is the default it indeed seems not to cause issues....

 

Maybe we could 'better' search for a solution in config....

Edited by littlesat, 10 December 2024 - 09:37.

[Stan]

I'd suggest, not to change it then. It will create a mess in terms of compatibility and continuity.

 

And better implement the fix from #22 and move on.

Edited by Stan, 10 December 2024 - 09:42.

[ims]

Using

config.usage.setupShowDefault = ConfigSelection(default="", choices=[
		("", _("Don't show default")),

should not be problematic. Problematic is only with loading from settings.

[Dimitrij]

FYI

 

https://github.com/O...7b322684584f0c0

maybe need

and config.usage.show_second_infobar.value not in ("no", "EPG")

[Stan]

Using

config.usage.setupShowDefault = ConfigSelection(default="", choices=[
		("", _("Don't show default")),

should not be problematic. Problematic is only with loading from settings.

 

Why woult it be problematic? If it's the default, it is not stored in settings,right?

Edited by Stan, 10 December 2024 - 10:05.

[ims]

 

Using

config.usage.setupShowDefault = ConfigSelection(default="", choices=[
		("", _("Don't show default")),

should not be problematic. Problematic is only with loading from settings.

 

Why woult it be problematic? If it's the default, it is not stored in settings,right?

 

I meant the subsequent comparison when you go to Customize.

[Stan]

@littlesat

After the elaboration, I think it's better stick to the Enigma conventions.

Could you please revert the commits and go with:

config.usage.setupShowDefault = ConfigSelection(default="", choices=[

and

config.usage.show_second_infobar = ConfigSelection(default="", choices=[("", _("None"))] + choicelist + [("EPG", _("EPG"))])

instead.

 

Thanks

Edited by Stan, 10 December 2024 - 10:58.

[Stan]

... or alternatively correct the commit:

	config.usage.show_second_infobar = ConfigSelection(default="no", choices=[("no", _("None"))] + choicelist + [("EPG", _("EPG"))])

Thanks

 

[Stan]

Sorry, forget what I posted above... mixed something up...

[littlesat]

EPG is fetched in the if earlier but with an extra isStandardInfoBar check.... when this was wrong somehow it was wrong for a longer time.....

 

and config.usage.show_second_infobar.value not in ("no", "EPG")

[Abu Baniaz]

And does it cause problems?

Yes it does. See the language thread.

[littlesat]

What language thread?

 

If so then it was in there for a long time....