Jump to content


Photo

Files not on place and wrong patches

BUG

  • Please log in to reply
6 replies to this topic

#1 fergy

  • Member
  • 22 posts

0
Neutral

Posted 13 November 2010 - 12:55

Hello.
You have some problems with files:
http://www.rytec.be/...8e_20101013.zip
[404 Not Found]
and problem with patch (vusolo build) for gst-plugin-dvbmediasink (probably dreambox is affected too):
This one is wrong:
--- src/gstdvbaudiosink.c.orig    2010-04-18 07:48:45.000000000 +0200
+++ src/gstdvbaudiosink.c    2010-05-03 20:16:48.694819154 +0200
@@ -181,8 +181,19 @@
	    "Felix Domke <tmbinc@elitedvb.net>"
	};
	GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
+    int fd;

-    int fd = open("/proc/stb/info/model", O_RDONLY);
+    int dtspassthrough = 1;
+    fd = open("/var/run/dts_mode", O_RDONLY);
+    if (fd >= 0)
+    {
+	   gchar string[8];
+	   ssize_t rd = read(fd, string, 7);
+	   close(fd);
+	   dtspassthrough = strncasecmp(string, "downmix", 7);
+    }
+
+    fd = open("/proc/stb/info/model", O_RDONLY);
	if ( fd > 0 )
	{
	    gchar string[8] = { 0, };
@@ -198,7 +209,7 @@
			  hwtype = DM8000;
			  GST_INFO ("model is DM8000 set broadcom dts caps");
			  gst_element_class_add_pad_template (element_class,
-				gst_static_pad_template_get (&sink_factory_broadcom_dts));
+				gst_static_pad_template_get (dtspassthrough ? &sink_factory_broadcom_dts : &sink_factory_broadcom));
		   }
		   else if ( !strncasecmp(string, "DM800", 5) ) {
			  hwtype = DM800;
@@ -210,7 +221,7 @@
			  hwtype = DM500HD;
			  GST_INFO ("model is DM500HD set broadcom dts caps", string);
			  gst_element_class_add_pad_template (element_class,
-				gst_static_pad_template_get (&sink_factory_broadcom_dts));
+				gst_static_pad_template_get (dtspassthrough ? &sink_factory_broadcom_dts : &sink_factory_broadcom));
		   }
	    }
	    close(fd);

and this one pass:
--- src/gstdvbaudiosink.c 
+++ src/gstdvbaudiosink.c 
@@ -180,8 +180,19 @@
	    "Felix Domke <tmbinc@elitedvb.net>"
	};
	GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
+    int fd;
	
-    int fd = open("/proc/stb/info/model", O_RDONLY);
+    int dtspassthrough = 1;
+    fd = open("/var/run/dts_mode", O_RDONLY);
+    if (fd >= 0)
+    {
+	   gchar string[8];
+	   ssize_t rd = read(fd, string, 7);
+	   close(fd);
+	   dtspassthrough = strncasecmp(string, "downmix", 7);
+    }
+
+    fd = open("/proc/stb/info/model", O_RDONLY);
	if ( fd > 0 )
	{
	    gchar string[8] = { 0, };
@@ -197,7 +208,7 @@
			  hwtype = DM8000;
			  GST_INFO ("model is DM8000 set broadcom dts caps");
			  gst_element_class_add_pad_template (element_class,
-				gst_static_pad_template_get (&sink_factory_broadcom_dts));
+				gst_static_pad_template_get (dtspassthrough ? &sink_factory_broadcom_dts : &sink_factory_broadcom));
		   }
		   else if ( !strncasecmp(string, "DM800", 5) ) {
			  hwtype = DM800;
@@ -209,7 +220,7 @@
			  hwtype = DM500HD;
			  GST_INFO ("model is DM500HD set broadcom dts caps", string);
			  gst_element_class_add_pad_template (element_class,
-				gst_static_pad_template_get (&sink_factory_broadcom_dts));
+				gst_static_pad_template_get (dtspassthrough ? &sink_factory_broadcom_dts : &sink_factory_broadcom));
		   }
	    }
	    close(fd);

Faculty of Electrical Engineering and Computing, University of Zagreb, Croatia Linux Development Department

Re: Files not on place and wrong patches #2 xener

  • Senior Member
  • 264 posts

0
Neutral

Posted 13 November 2010 - 19:33

whats a problem with this patch? it must apply both way, its only a offset.
for rytec try to find actual filename on rytec site and apply to your preferred version.

Re: Files not on place and wrong patches #3 fergy

  • Member
  • 22 posts

0
Neutral

Posted 13 November 2010 - 21:22

M8, I don't understand You. This is wrong offset and it is in officiall version so, really don't know why You overreacting? Simply,this original patch not work and that not affected Me but other users, so I was just put thigh here because, maybe was someone make mistake.
So please, cool down.
Faculty of Electrical Engineering and Computing, University of Zagreb, Croatia Linux Development Department

Re: Files not on place and wrong patches #4 xener

  • Senior Member
  • 264 posts

0
Neutral

Posted 13 November 2010 - 23:09

i don`t know about what you are talking here, gst-plugin-dvbmediasink patch and compile without errors for all but you.

NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC: started
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_fetch: started
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_fetch: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_unpack: started
NOTE: Unpacking /work/sources/dvbmediasink_cvs.schwerkraft.elitedvb.net__20101006UTC.tar.gz to /work/planb/build-dm800/tmp/work/gs
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_unpack: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_patch: started
NOTE: Applying patch 'dtspatch.diff'
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_patch: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_configure: started
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_configure: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_compile: started
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_compile: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_install: started
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_install: completed
NOTE: package gst-plugin-dvbmediasink-0.10+20101006UTC-r5: task do_package: started

Re: Files not on place and wrong patches #5 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 13 November 2010 - 23:17

'patch' is robust enough to deal with offset shifts, and lots more in fact.

Re: Files not on place and wrong patches #6 fergy

  • Member
  • 22 posts

0
Neutral

Posted 13 November 2010 - 23:38

'patch' is robust enough to deal with offset shifts, and lots more in fact.


Yes, I know that patch is robust but somehow problem persist.
I don't want any fight here, just asking....
Faculty of Electrical Engineering and Computing, University of Zagreb, Croatia Linux Development Department

Re: Files not on place and wrong patches #7 xener

  • Senior Member
  • 264 posts

0
Neutral

Posted 14 November 2010 - 08:54

please post your error message you got with this patch.



Also tagged with one or more of these keywords: BUG

1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users