It seems latest updates to enigma2 code broke the display of external text subtitles (SRT etc) or text subtitles inside MKV container. I have to roll back some versions to find out when it broke, but it is definitely broken now. Tested in ET9000 and DM500HD.
External subtitles on media player don't work
Started by malakudi, 01 Jul 2011 12:01
17 replies to this topic
Re: External subtitles on media player don't work #2
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 1 July 2011 - 12:52
This is indeed currently known. This is since the deadlock commit.
Re: External subtitles on media player don't work #3
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 1 July 2011 - 14:53
we know which revision broke it. But that revision fixes a deadlock, so we have to choose between two bads 
Re: External subtitles on media player don't work #4
-
- Senior Member
- 1,449 posts
+69
Good
Posted 1 July 2011 - 16:41
we know which revision broke it. But that revision fixes a deadlock, so we have to choose between two bads
When was the deadlock happening? When seeking the file? And why this patch breaks subtitle display?
Is anyone testing it? I could take a look.
Re: External subtitles on media player don't work #5
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 1 July 2011 - 18:24
indeed, seeking deadlocked.
So the rev releases the subtitle lock while seeking.
Probably the new m_seeking variable is causing subtitles to be dropped.
So the rev releases the subtitle lock while seeking.
Probably the new m_seeking variable is causing subtitles to be dropped.
Re: External subtitles on media player don't work #6
-
- PLi® Core member
- 13,625 posts
+212
Excellent
Posted 1 July 2011 - 18:39
what means "does not work with srt" ? I can display SRT subtitle with my avi files well (DM800SE).
Problem is only, if is seek in played file - sometimes subtitles are discovered , sometime dont.
Problem is only, if is seek in played file - sometimes subtitles are discovered , sometime dont.
Kdo nic nedělá, nic nezkazí!
Re: External subtitles on media player don't work #7
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 1 July 2011 - 19:47
Playback in e2 always starts with a seek to 0 (don't ask), I think that is what is responsible for the subtitles to stop working.
Probably timing related, so it might work for you most of the time, as long as you don't seek.
Probably timing related, so it might work for you most of the time, as long as you don't seek.
Re: External subtitles on media player don't work #8
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 1 July 2011 - 21:31
I'm currently experimenting with the appsink in sync mode.
Advantage is we do not have to keep a m_subs_to_pull count, which is very dangerous.
If we get the count wrong, the next pull-buffer might block forver.
That's why the count is heavily protected with a mutex.
And because a seek triggers new appsink buffers immediately, the mutex was held during the seek.
Which on its turn gives a potential deadlock, because the gst message pump is blocking trying to deliver the appsink notifications.
My idea is to use the messagepump we already introduced, and loose the mutex alltogether.
And to avoid the appsink from delivering 1000ths of subs right away, and redelivering them after each seek, we put the appsink in sync mode.
Advantage is we do not have to keep a m_subs_to_pull count, which is very dangerous.
If we get the count wrong, the next pull-buffer might block forver.
That's why the count is heavily protected with a mutex.
And because a seek triggers new appsink buffers immediately, the mutex was held during the seek.
Which on its turn gives a potential deadlock, because the gst message pump is blocking trying to deliver the appsink notifications.
My idea is to use the messagepump we already introduced, and loose the mutex alltogether.
And to avoid the appsink from delivering 1000ths of subs right away, and redelivering them after each seek, we put the appsink in sync mode.
Re: External subtitles on media player don't work #9
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 1 July 2011 - 22:32
The principle works very nicely.
However, sometimes the text sink complete looses track of time after a seek.
It seems it's not synced with the playbin2 at all...
Then, after another seek, it might suddenly jump back to the playbin2 time.
I'll try and find out whether this is something that was introduced by switching the sink to sync mode, or this was the case before I started messing with it.
If this has been the case all the time, there's no more reason not to switch to sync mode.
But if this is a new problem, it seems we cannot use sync mode.
However, sometimes the text sink complete looses track of time after a seek.
It seems it's not synced with the playbin2 at all...
Then, after another seek, it might suddenly jump back to the playbin2 time.
I'll try and find out whether this is something that was introduced by switching the sink to sync mode, or this was the case before I started messing with it.
If this has been the case all the time, there's no more reason not to switch to sync mode.
But if this is a new problem, it seems we cannot use sync mode.
Re: External subtitles on media player don't work #10
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 2 July 2011 - 10:02
Isn't it possible to add a not synched detector?
Re: External subtitles on media player don't work #11
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 2 July 2011 - 10:50
Isn't it possible to add a not synched detector?
yes, if you receive subtitles too late (and they are then dropped), you know you're out of sync. But then what?
There is no way to restore the synchronisation.
But the other way around also occurs, you start receiving subtitles from the beginning of the movie, whilst you're almost at the end.
So nothing will be shown, nothing will be dropped.
Re: External subtitles on media player don't work #12
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 2 July 2011 - 13:19
I just saw you revert the "deadlock" commit....
So in fact we have to deal here with "Ghost-ware"... and there should be stuff partly rewritten...
So in fact we have to deal here with "Ghost-ware"... and there should be stuff partly rewritten...
Re: External subtitles on media player don't work #13
-
- PLi® Core member
- 32,766 posts
+245
Excellent
Posted 2 July 2011 - 13:37
??
no, this is a gstreamer bug, while it exists we cannot use sync mode on the text sink
no, this is a gstreamer bug, while it exists we cannot use sync mode on the text sink
Re: External subtitles on media player don't work #14
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 3 July 2011 - 10:47
Indeed a gstreamer bug... I started to read here: https://bugzilla.gno...g.cgi?id=610904 and here https://bugzilla.gno...g.cgi?id=600648 ......
Re: External subtitles on media player don't work #15
-
- Senior Member
- 1,449 posts
+69
Good
Posted 8 July 2011 - 15:11
Rolling back the deadlock didn't fix the subtitles, at least on ET9000. Haven't checked yet on my other boxes.
I'll try to find an older version that worked.
I'll try to find an older version that worked.
Re: External subtitles on media player don't work #16
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 8 July 2011 - 15:39
The subtitles do work now... but most times you need one stepskip to enable them....
Re: External subtitles on media player don't work #17
-
- Senior Member
- 1,449 posts
+69
Good
Posted 8 July 2011 - 16:44
The subtitles do work now... but most times you need one stepskip to enable them....
I tried several mkv's with internal subs, they don't work on my ET9000 (same files used to work - there are small video samples that I use to test the box).
Re: External subtitles on media player don't work #18
-
- PLi® Core member
- 56,303 posts
+691
Excellent
Posted 8 July 2011 - 18:28
THen could you please such mkv somewere?
I know this is a really fight there regards servicemp3.cpp and gstreamer.
I know this is a really fight there regards servicemp3.cpp and gstreamer.
1 user(s) are reading this topic
0 members, 1 guests, 0 anonymous users
