303 replies to this topic

[awx]

Could you make a diff compaired to our current sources...?

Here are the patches and the merged source for verification
Please do not submit any patches until the merged source can be verified, if no one else can do this, I will do this first thing in the new year.

Here is a full list of all changes.


Readd timelines/timelinenow (variables only) to not break skins that use them
Allow setting picon size and back color
Allow setting a preferred picon path
Add param to enable and disable picon in the list
No longer hard code the timeline item height, so we can skin that properly
Add an attribute to set the timeline font
Add attributes to change the fonts in the list
Initial add of customization of path for picons
Always draw the service name but trim it to 14 chars
Always draw the service rect even when drawing the picon
Modify picon searching to only happen once per service list
Initial port of picone
Add service paging using next/prev service buttons
Fix a bug were gaps on the last channel were not being filled
Fix a bug where the clipping rect is not correctly updated
Add add/remove recording button
Make the zap function request a service reference
Change default time epoch to 60
Change the time the grid starts at to be on the half hour or hour
Fix service highlighting when bouquet is changed
Fix zap function
Cache the current bouquet name
Add highlighting for the currently playing service
Add an import and explicit declartion of service_rect
import StaticText
Use cached data to display event details for the current selection
Change where the timeline is calculated and how its size is calculated
Remove a few things that are not needed
Add the ability to skin the color of services
Create dummy records on gaps in event data

Attached Files

•  patches.tar.gz   15.22KB   9 downloads
•  MergedGraphMultiEpg.needs.verification.tar.gz   9.6KB   11 downloads

[theparasol]

Just installed mergedgraphmultiepg.needs.verification

crashlog attached

Attached Files

•  enigma2_crash_1324749214.log   21.07KB   5 downloads

[awx]

Just installed mergedgraphmultiepg.needs.verification

crashlog attached

Thanks for the help
Here is an update that should resolve that error.
I will update a new batch set once everything is confirmed to be fine.
I have rebased the current changes into the proper place.

Attached Files

•  MergedGraphMultiEpg.needs.verification.1.0.1.tar.gz   9.52KB   9 downloads

[littlesat]

How far are these mods workable with other skins???

[awx]

How far are these mods workable with other skins???

That still needs to be checked.
The main things that wouldn't work with other skins are timeline_now and timelines, but they shouldn't break other skins as the one commit reintroduces these objects. However timelines > 5 in a skin will break as the code that changes that was removed. I will reintroduce timelines_now and if it is needed timelines, however I don't really like or find the individual timelines useful.

I don't believe any of the new skin settings I have created need to be set so most skins should be fine in that sense.

[Dimitrij]

I tested your mod infinity-hd.
GraphMultiEpg just does not work.
Everything should be rewritten in the skin .

[awx]

I tested your mod infinity-hd.
GraphMultiEpg just does not work.
Everything should be rewritten in the skin .

Thank for testing, any chance you could provide the crash log and skin.xml?

[littlesat]

This can only be committed when it is compatible with older skins... otherwise we only can get complaints...

But you can do a trick by just use another name for the skin and but basic skin code (without templates) into the sources from the graphic multi EPG itself... That is what I prefer and so it says compatible...

Sorry for the extra work...

[awx]

This can only be committed when it is compatible with older skins... otherwise we only can get complaints...

But you can do a trick by just use another name for the skin and but basic skin code (without templates) into the sources from the graphic multi EPG itself... That is what I prefer and so it says compatible...

Sorry for the extra work...

I agree, it should not be committed until it is compatible.
I will make the needed changes.
I believe I found where the error could be on other skins right now ( I changed the name of some attributes which may cause certain skin values to not be set ), but I would need the crash log to confirm.

[Dimitrij]

Tomorrow I will check it out.

[littlesat]

OK

Edited by littlesat, 25 December 2011 - 13:30.

[awx]

I tested your mod infinity-hd.
GraphMultiEpg just does not work.
Everything should be rewritten in the skin .

Here is an updated version where I have hardcoded some default skin values
And readded a skin attribute check

elif attrib == "ServiceForegroundColor" or attrib == "ServiceNameForegroundColor":

elif attrib == "ServiceBackgroundColor" or attrib == "ServiceNameBackgroundColor":

This should hopefully fix any errors that come from values not being set.

Thanks for the help

Attached Files

•  MergedGraphMultiEpg.needs.verification.1.0.2.tar.gz   9.67KB   7 downloads

Edited by awx, 25 December 2011 - 13:41.

[theparasol]

tested, works great with pli-hd skin.

Names of channels doesn't fit nicely. Maybe the box width needs to be expanded a little?
Or the font a bit smaller and display long channelnames in two lines in the same box.

See screenshot

Attached Files

•  screenshot.jpg   89.95KB   97 downloads

Edited by theparasol, 25 December 2011 - 18:26.

[awx]

tested, works great with pli-hd skin.

Names of channels doesn't fit nicely. Maybe the box width needs to be expanded a little?

See screenshot

Thanks for testing

For the names of the channels, this really depends on the size of the picon and how long the channel name is.
I will create a better solution for display the channel names once some more testing is done, I don't want to add to much more until initial bugs from the merge are resolved.

[littlesat]

Usually within PLi the picons are autoscaling as it is defined in the font.... why not use that...?

[awx]

Usually within PLi the picons are autoscaling as it is defined in the font.... why not use that...?

I wasn't aware that was available.
Which source file should I look in for more information on this?

[awx]

Usually within PLi the picons are autoscaling as it is defined in the font.... why not use that...?

I wasn't aware that was available.
Which source file should I look in for more information on this?

Also I haven't found a function to calculate the font width, which would be very useful. Do you know if one already exists in the source?

[littlesat]

You have to look to our picon renderer to see what you can do... The picons will autofit to the size the skin (or widget it should placed to) will be... (see our picon renderer http://openpli.git.s...2af7390;hb=HEAD, see self.instance.setScale(1))

Edited by littlesat, 25 December 2011 - 19:42.

[awx]

You have to look to our picon renderer to see what you can do... The picons will autofit to the size the skin (or widget it should placed to) will be... (see our picon renderer http://openpli.git.s...2af7390;hb=HEAD, see self.instance.setScale(1))

Thanks, Ill take a look

[littlesat]

You see also there how we search for picons....