Jump to content


Photo

My Modified GraphMultiEpg


  • Please log in to reply
303 replies to this topic

Re: My Modified GraphMultiEpg #141 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 4 January 2012 - 10:03



Latest Update

Changes
---------------------

If a program has ended, flag it as not being the best event to switch to (highlights the correct event)
Fix incorrect background color being set when picon is scaled (only uses colors in the color index, I think)
Change default picon scale background color to white
Fix jump over empty by not adding records on empty channels if set to true


***** Skip empty services is set by default so no records will be shown on channels with no TBA records, to revert to the previous way things were working, please use the config screen and disable Skip empty services ( I could change the default, but as this is a legacy config it would not change anything )

Any feedback on the last version?
What else is needed other than the patches before this can be merged into the image?


Well i didnt find any more glitches. Seems to working correct except....
if the program has ended it hides the title but still select the empty rectangle when navigating up and down instead to select currently playing event!
Also if the EPG data is sent but the title is "" (means empty title is set) it still highlight the rectangle as there is event which i think is not right! If there is no data (or there is but "") it must be show as there is no data or at least as To be determined!
Also the color button labels are correct now but if change the mapping in keymap.xml the names does not change! i think there must be logic to change the names of buttons according to the mapping.
That it i guess!

For your first point is this still an issue with the last release 1.0.15? I have tested and when moving up and down the program that has ended is not selected.
For the empty title, we could fill this with the TBD string, Ill make a chagne for that.
Ill look into changing the labels based on what they are set to in the keymap.
Thanks

Re: My Modified GraphMultiEpg #142 DimitarCC

  • PLi® Contributor
  • 1,573 posts

+70
Good

Posted 4 January 2012 - 10:19




Latest Update

Changes
---------------------

If a program has ended, flag it as not being the best event to switch to (highlights the correct event)
Fix incorrect background color being set when picon is scaled (only uses colors in the color index, I think)
Change default picon scale background color to white
Fix jump over empty by not adding records on empty channels if set to true


***** Skip empty services is set by default so no records will be shown on channels with no TBA records, to revert to the previous way things were working, please use the config screen and disable Skip empty services ( I could change the default, but as this is a legacy config it would not change anything )

Any feedback on the last version?
What else is needed other than the patches before this can be merged into the image?


Well i didnt find any more glitches. Seems to working correct except....
if the program has ended it hides the title but still select the empty rectangle when navigating up and down instead to select currently playing event!
Also if the EPG data is sent but the title is "" (means empty title is set) it still highlight the rectangle as there is event which i think is not right! If there is no data (or there is but "") it must be show as there is no data or at least as To be determined!
Also the color button labels are correct now but if change the mapping in keymap.xml the names does not change! i think there must be logic to change the names of buttons according to the mapping.
That it i guess!

For your first point is this still an issue with the last release 1.0.15? I have tested and when moving up and down the program that has ended is not selected.
For the empty title, we could fill this with the TBD string, Ill make a chagne for that.
Ill look into changing the labels based on what they are set to in the keymap.
Thanks


Well i am testing also with 1.0.15 and still it select the finished event! It could be due to the fact that there is interval for 15 minutes that we round to! My event for example finished before 2 min. and is still selected when moving up and down! If that is the case maybe that interval should be more configurable, forexample 1,2,5,10,15,20,25,30

Edited by DimitarCC, 4 January 2012 - 10:20.

Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)


Re: My Modified GraphMultiEpg #143 ims

  • PLi® Core member
  • 13,781 posts

+214
Excellent

Posted 4 January 2012 - 10:22

I am using this last 1.0.15 and works well. Finished event are not selected.
Kdo nic nedělá, nic nezkazí!

Re: My Modified GraphMultiEpg #144 DimitarCC

  • PLi® Contributor
  • 1,573 posts

+70
Good

Posted 4 January 2012 - 10:28

I am using this last 1.0.15 and works well. Finished event are not selected.


Ahh i was just check! Seems to select corect one but i dont know why before not select it!!! But still that firled is highlighted which i think is not good idead or at least should be differebt color!

Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)


Re: My Modified GraphMultiEpg #145 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 4 January 2012 - 10:38


I am using this last 1.0.15 and works well. Finished event are not selected.


Ahh i was just check! Seems to select corect one but i dont know why before not select it!!! But still that firled is highlighted which i think is not good idead or at least should be differebt color!


firled??

There may be an explaination as to why the selection did not work for you once, but its only a guess if this is what you actually saw.
There is a case where the epg from the dvb stream contains overlapping data, so that one events after another has started. In this case it may look like the incorrect event is selected.

Re: My Modified GraphMultiEpg #146 DimitarCC

  • PLi® Contributor
  • 1,573 posts

+70
Good

Posted 4 January 2012 - 10:42



I am using this last 1.0.15 and works well. Finished event are not selected.


Ahh i was just check! Seems to select corect one but i dont know why before not select it!!! But still that firled is highlighted which i think is not good idead or at least should be differebt color!


firled??

There may be an explaination as to why the selection did not work for you once, but its only a guess if this is what you actually saw.
There is a case where the epg from the dvb stream contains overlapping data, so that one events after another has started. In this case it may look like the incorrect event is selected.


Ahh i was mean "field" but i dont know why i cant edit my post!
It could be right that there is overlapping events! Maybe that was the case since now it select correct! But i think passed events color should be different to not mistake!

Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)


Re: My Modified GraphMultiEpg #147 ims

  • PLi® Core member
  • 13,781 posts

+214
Excellent

Posted 4 January 2012 - 10:51

may be better than change collor for old event, disable jump to old event. May be some as: if current_time > event's end_time then return
Kdo nic nedělá, nic nezkazí!

Re: My Modified GraphMultiEpg #148 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 4 January 2012 - 10:51

We can add a parameter to skin past events, that shouldnt be a problem.

Re: My Modified GraphMultiEpg #149 DimitarCC

  • PLi® Contributor
  • 1,573 posts

+70
Good

Posted 4 January 2012 - 10:54

We can add a parameter to skin past events, that shouldnt be a problem.


Yes good idea and also ims's suggestion is not bad idea also!

Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)


Re: My Modified GraphMultiEpg #150 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 4 January 2012 - 11:01

may be better than change collor for old event, disable jump to old event. May be some as: if current_time > event's end_time then return

Sounds like a good idea, I will look to add a option to do that.

Perhaps before adding all of this we should look to get all the changes integrated to the repo, but I am not sure what would be missing or needed (Other than patches) before that can be done.

Re: My Modified GraphMultiEpg #151 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 4 January 2012 - 21:03

Updated version
--------------------

Add a progressbar so we dont need to lookup event id just to generate this
If an event title is empty fill it with the tbd string
Allow disabling selection of expired events
Set the proper name for buttons based on what the keymap is set to (needs localization testing)
Add compatibility mode, stops filling event object which prevents a lookupEventId on each selection change
Use 1:1 aspect ratio for picons

Attached Files



Re: My Modified GraphMultiEpg #152 DimitarCC

  • PLi® Contributor
  • 1,573 posts

+70
Good

Posted 5 January 2012 - 07:27

Updated version
--------------------

Add a progressbar so we dont need to lookup event id just to generate this
If an event title is empty fill it with the tbd string
Allow disabling selection of expired events
Set the proper name for buttons based on what the keymap is set to (needs localization testing)
Add compatibility mode, stops filling event object which prevents a lookupEventId on each selection change
Use 1:1 aspect ratio for picons


I was just test it! Seems to work all the way! Also i am using another language and localization also work for me (at least on timer button)

Vu+DUO4KSE, DM920UHD, Vu+Uno4KSE, SF8008Mini, 2xPulse4K, Vu+Solo2, Dreambox DM500HD, Triax 78 (7E,9E,13E,19.2E,23.5E) & 2xTriax 78 (39E)


Re: My Modified GraphMultiEpg #153 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 5 January 2012 - 07:36


Updated version
--------------------

Add a progressbar so we dont need to lookup event id just to generate this
If an event title is empty fill it with the tbd string
Allow disabling selection of expired events
Set the proper name for buttons based on what the keymap is set to (needs localization testing)
Add compatibility mode, stops filling event object which prevents a lookupEventId on each selection change
Use 1:1 aspect ratio for picons


I was just test it! Seems to work all the way! Also i am using another language and localization also work for me (at least on timer button)

Thanks, thats good news

Re: My Modified GraphMultiEpg #154 ims

  • PLi® Core member
  • 13,781 posts

+214
Excellent

Posted 7 January 2012 - 01:23

tried v.16 - it seems, for fontsize > 16 is bottom of text cropped (y,p,...)
Kdo nic nedělá, nic nezkazí!

Re: My Modified GraphMultiEpg #155 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 7 January 2012 - 10:23

tried v.16 - it seems, for fontsize > 16 is bottom of text cropped (y,p,...)

You will need to change the even font padding in the skin, to get this to look right.

Re: My Modified GraphMultiEpg #156 ims

  • PLi® Core member
  • 13,781 posts

+214
Excellent

Posted 7 January 2012 - 21:16

little bug - when is zapped to channel, for which is missing picon and you run MultiEPG, then MEPG begin on 1st channel in bouquet always.
Kdo nic nedělá, nic nezkazí!

Re: My Modified GraphMultiEpg #157 mirakels

  • Forum Moderator
    PLi® Core member
  • 7,603 posts

+62
Good

Posted 7 January 2012 - 23:30

Interesting improvements.
Tried it and looks good, but there are a few peculiar things: The service names look horrible (font?). The program info is sometimes limited to a single word. Did you turn off word wrap?

Can you create git patches for each separate enhancement so we can include then in de pli repos (assuming you want the code to be part of pli repository) in a clean and documented way?
Geen wonder... Had slechts een dm7000, maar wel ook een rotor. eigenlijk al een tijdje ook een dm600 en dm7025. Maar nu kijkend met een et9000 en vuduo

Re: My Modified GraphMultiEpg #158 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 8 January 2012 - 10:35

Interesting improvements.
Tried it and looks good, but there are a few peculiar things: The service names look horrible (font?). The program info is sometimes limited to a single word. Did you turn off word wrap?

Can you create git patches for each separate enhancement so we can include then in de pli repos (assuming you want the code to be part of pli repository) in a clean and documented way?

Word wrap is enabled but you need to set serviceFontPadding to be larger for it to wrap. The font for service names is the same as it use to be, the default that is. Perhaps theres something in the skin attributes that I missed.

I have attached the patches.

Attached Files



Re: My Modified GraphMultiEpg #159 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 8 January 2012 - 10:35

little bug - when is zapped to channel, for which is missing picon and you run MultiEPG, then MEPG begin on 1st channel in bouquet always.

I will try to reproduce and fix it. Thanks

Re: My Modified GraphMultiEpg #160 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 8 January 2012 - 11:12

little bug - when is zapped to channel, for which is missing picon and you run MultiEPG, then MEPG begin on 1st channel in bouquet always.

Could you please provide some more details about this? Channel selection is not related to weather or not a cannel has a picon. There must be something else that causes the problem.


8 user(s) are reading this topic

0 members, 8 guests, 0 anonymous users