303 replies to this topic

[mirakels]

rebase was fine you are looking at the wrong parts
The part you reference is from the event note the ev[1], the part that was being changed was from the service portion, which looks like it matches correctly to the PLi source

Ah yes, I see. I looked at the wrong part.
But the other remarks are still valid....

I will not take a look at combining the changes

'not'? is this a typo or are you offended?

[awx]

rebase was fine you are looking at the wrong parts
The part you reference is from the event note the ev[1], the part that was being changed was from the service portion, which looks like it matches correctly to the PLi source

Ah yes, I see. I looked at the wrong part.
But the other remarks are still valid....

I will not take a look at combining the changes

'not'? is this a typo or are you offended?

Ahh... sorry about that, didn't notice that.
I will take a look at it. I am not offend

[mirakels]

ok, that is a relief

Lets work this out together so i it will find its way into the image donwloads.
Oh, and please don't forget to sign-off, so your name will be in the credits!
and code changes can easily be tracked to the author.
And maybe you can add a bit detailed descritpion in the patch commits. One
line with a sort of summary follwoed by an empty line followed by a more detailed
description. e.g:

Add more color options for epg fields.

 
 
Add a few extra variables to allow for more highlightcontrol of colors for 
the specific parts of the events: the color of current events is controlled by
eventCurBackground. etc. etc.

[awx]

ok, that is a relief

Lets work this out together so i it will find its way into the image donwloads.
Oh, and please don't forget to sign-off, so your name will be in the credits!
and code changes can easily be tracked to the author.
And maybe you can add a bit detailed descritpion in the patch commits. One
line with a sort of summary follwoed by an empty line followed by a more detailed
description. e.g:

Add more color options for epg fields.
 
 
 
Add a few extra variables to allow for more highlightcontrol of colors for
the specific parts of the events: the color of current events is controlled by
eventCurBackground. etc. etc.

Will do, I am currently in the process of identifying which changes can be squashed together
Is there a character limit for the first line and each line before wrapping it? Ie. 50 chars per line?

[mirakels]

git uses the first line for general info. E.g. in subject lines when git creates email messages. And I think it is used for the PLi twitter messages. So I guess there is not a real limit, but keep it as short as possible. When reading mail on small width smartphones it looks ugly when subject lines wrap...

[awx]

git uses the first line for general info. E.g. in subject lines when git creates email messages. And I think it is used for the PLi twitter messages. So I guess there is not a real limit, but keep it as short as possible. When reading mail on small width smartphones it looks ugly when subject lines wrap...

Is there a nice way of reorder, squashing and combining all changes?
I keep running into conflicts because a lot of it is tied together.

[mirakels]

git allows to merge commits into one but it may not always work out the way you want.
It might be better to start of with the base pli code and selectively add your patches (or parts of a patch file) in to the code and commit it. Then go onwith the next group.
e.g. patch 2, 31 and part of 8 can be put together and committed.
likewise for patches around toggelRecord (patch 15, 40, 41, 66 and 87) (oh, and maybe rename it to toggleRecord)
Or all the patches for picon stuff (although it might be better the make a few logical commits for that).

And yes this will need some manual work to grep parts of code out of the patches causing patch conflicts later on that need to be fixed again...
But it will make things more readable and easier to review...

[pieterg]

git uses the first line for general info. E.g. in subject lines when git creates email messages. And I think it is used for the PLi twitter messages. So I guess there is not a real limit, but keep it as short as possible. When reading mail on small width smartphones it looks ugly when subject lines wrap...

Is there a nice way of reorder, squashing and combining all changes?
I keep running into conflicts because a lot of it is tied together.

git rebase -i

[awx]

Here is an experimental version with searching function.
Searching function does not work perfectly because the text conversion is broken in enigma2. I am looking into fixing that.
Right now it loops through the given text formats and does the search.

Skinning is not yet available but will be.

Changes
-----------

Change fonts to regular font
Add a few more encodings and a field to display the encoding that matched
Use instant variable instead of hardcoded values
Revert back to using inputbox as there is a problem with virtualkeyboard and special chars
Add pixmaps to properly indicate recordings
Remove the listener on screen close
Use a virtual keyboard instead of a inputbox
Modify episode number regex
Change where we calculate the name padding
Add parsing of the event description for a specific episode number
Merge branch 'release' into search
Workaround for service comparison
Make searching partial and exact titles the same
Fix list checks and add one to toggelRecord
import config
Use pixmap from the default skin
Correct description to match how GraphMultiEpg does it
Set static text when there is no result
Change similar broadcast to use the currently selected one and always set a result set
Add padding around the service name
Correct color pixmap placement
Add the ability to toggel recording of an event and display a record icon
Add different search options
Add the ability to change the search title
Initial add of a search function

Attached Files

•  MergedGraphMultiEpgSearch.1.0.0.tar.gz   16.69KB   4 downloads

[DimitarCC]

On my box search just crash!

[awx]

On my box search just crash!

Do you have a crash log?

[DimitarCC]

What location is the crashlog in E2 Openpli?

[awx]

What location is the crashlog in E2 Openpli?

Mine are usually in /media/hdd
not sure were it would be located if you don't have a hard disk

[DimitarCC]

what i can see from the green screen... it says Attribute "none" is not defined

[DimitarCC]

OK here is crachlog

Attached Files

•  enigma2_crash_1326546008.log   16.88KB   3 downloads

[awx]

OK here is crachlog

Did you put the keymap.xml in the GraphMultiEPG directory?

[DimitarCC]

It seem because i am located the ePG in not default folder... and seems keymap location is hardcoded!!!
It it posible keymap location to get the installed folder location?

Edited by DimitarCC, 14 January 2012 - 14:04.

[awx]

It seem because i am located the ePG in not default folder... and seems keymap location is hardcoded!!!
It it posible keymap location to get the installed folder location?

Most likely, Ill have to look into how to get that path.

[DimitarCC]

I see! After put keymap it works but is not centered on screen maybe becasue skin is missing.

[awx]

I see! After put keymap it works but is not centered on screen maybe becasue skin is missing.

Skin is hardcoded right now and uses the full screen.
This is just an example skin right now