17 replies to this topic

[ambrosa]

Added VID/PID for Leadtek USB DVB-T stick 0x0413 0x6A03

(thanks to djnice)

Attached Files

•  dvb-usb-rtl2832.patch.tar.gz   336.8KB   88 downloads

Edited by ambrosa, 2 January 2012 - 18:00.

[pieterg]

1 files changed, 100513 insertions(+), 100513 deletions(-)

and the number of lines in the patch:

wc linux-etxx00/dvb-usb-rtl2832.patch -l
100563 linux-etxx00/dvb-usb-rtl2832.patch

the diff is huge, seems like a line-ending problem?

[Gennar1]

The DOS line-ending problem was introduced in the previous version:

http://openpli.git.s...932a9a1fed1c524

(note the \r symbols). This new version seems OK.

[Gennar1]

Well, it was not OK. I fixed it with dos2unix and also removed a non UTF8 character (there was a comment saying "Power Level in dBµV").
The fixed version is attached. The functional changes are just 2 lines adding the USB PIDs for the new device.

Attached Files

•  dvb-usb-rtl2832.patch.tar.gz   330.52KB   18 downloads

[ambrosa]

MMhhh I'm very confused.
I don't use Windows systems since years.
In my PC now run Kubuntu 11.10 (previous was Xubuntu 11.10).

I don't know WHERE "\r" is appeared. GitHub ?
Let me recheck my work

It's very strange....

[ambrosa]

BTW before posting the new patch I've recompiled it to see if something went wrong. No errors.
"\r" and non-UTF8 char don't seem to be a problem but I agree with Gennar1: it's better to have a cleaned code.

[Gennar1]

Yes, the "µ" char is not a big problem as it has been present in the original code from the beginning. But several editors complained about it (because they can't automatically recognize the character set) so it's better to replace it with a simple "u".
Maybe the "\r" characters where present also in the original Realtek files: they are automatically hidden in many C editors, and usually the editors can be configured to automatically remove them on open/save.

[ambrosa]

Yes, the "µ" char is not a big problem as it has been present in the original code from the beginning. But several editors complained about it (because they can't automatically recognize the character set) so it's better to replace it with a simple "u".

Yes, I know. I've already changed to 'u' in .c but I forgot to do the same in .h

Maybe the "\r" characters where present also in the original Realtek files: they are automatically hidden in many C editors, and usually the editors can be configured to automatically remove them on open/save.

gedit opened filse as iso-8859-1 and so I have supposed that was fine.


Now I've removed all DOS CR and converted with iconv all files from iso-8859-1 to utf-8. And pushed changes to my GitHub repo.

Attached there is the cleaned-up patch: as you see before there are only 2 changes about a new VID/PID device (LEADTEK)

Attached Files

•  dvb-usb-rtl2832.patch.tar.gz   330.46KB   39 downloads

[pieterg]

thanks guys, I've committed the patch.

[Dimitrij]

@Gennar1
Thank you for the signal level at A835

[Gennar1]

Thanks for the feedback, it's really useful as I don't have an A835.

[malcolm11]

Hi,
Sorry not sure if this is right place to post, could anyone help please. Probably didnt do something propery or Opensuse 11.4 file structure different.
Problems to make
make -C /usr/src/linux-headers-`uname -r` SUBDIRS=/home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0 modules
make: *** /usr/src/linux-headers-3.0.4-2-desktop: No such file or directory. Stop.
make: *** [default] Error 2
created
/usr/src/linux-headers-3.0.4-2-desktop
then
make -C /usr/src/linux-headers-`uname -r` SUBDIRS=/home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0 modules
make[1]: Entering directory `/usr/src/linux-headers-3.0.4-2-desktop'
make[1]: *** No rule to make target `modules'. Stop.
make[1]: Leaving directory `/usr/src/linux-headers-3.0.4-2-desktop'
make: *** [default] Error 2
my cloned directory is here /home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0

Edited by malcolm11, 11 February 2012 - 22:48.

[Gennar1]

You must install the kernel headers package for your distribution, then make sure it is installed in the standard directory (which looks to be `/usr/src/linux-headers-3.0.4-2-desktop' from your log). If they are installed into another place, then you can either create a simlink or edit the makefile with the correct path.

[malcolm11]

Hi Genna,
Thanks, moved on but problem with symlinks. The kernel headers package is here /usr/src/linux-3.0.4-2. created a symlink called linux-headers-3.0.4-2-desktop pointing to it.
Thats ok, but now make is looking for autoconf.h . It is here /usr/src/linux-3.0.4-2-obj/x86_64/desktop/include/generated/autoconf.h, but cannot create symlink because make is looking for it starting from include subdirectory. Cannot create symlink called include, because there is a directory called include already in linux-3.0.4-2. If I create a symlink in /usr/src/linux/include called generate then the module.symvers will be bypassed. Can I copy this into the generated subdirectory. It would be easier to modify the makefile, but dont see where.


file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/Makefile
file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/Module.base
file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/Module.supported
file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/Module.symvers
file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/include
file:///usr/src/linux-3.0.4-2-obj/x86_64/desktop/scripts

[Gennar1]

What about this:

cd /usr/src
ln -s linux-3.0.4-2-obj/x86_64/desktop linux-headers-3.0.4-2-desktop

[malcolm11]

Hi Genna1, thanks for the suggestion. Yes that symlink is working, but now make is looking for include/generated/autoconf.h. I have created a symlink /usr/src/linux-3.0.4-2/include/generated/ , but it is not working.
file:///usr/src/linux-3.0.4-2/include/generated/autoconf.h
Looking at the terminal output, there seems to be a whole lot of differnces between file locations for Opensuse and Ubuntu. What do you think Genna1?

make -C /usr/src/linux-headers-`uname -r` SUBDIRS=/home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0 modules
make[1]: Entering directory `/usr/src/linux-3.0.4-2'

ERROR: Kernel configuration is invalid.
include/generated/autoconf.h or include/config/auto.conf are missing.
Run 'make oldconfig && make prepare' on kernel src to fix it.


WARNING: Symbol version dump /usr/src/linux-3.0.4-2/Module.symvers
is missing; modules will have no dependencies and modversions.

CC [M] /home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0/demod_rtl2832.o
/bin/sh: scripts/basic/fixdep: No such file or directory
make[2]: *** [/home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0/demod_rtl2832.o] Error 1
make[1]: *** [_module_/home/malcolm/DVB-Realtek-RTL2832U-2.2.2-10tuner-mod_kernel-3.0.0/RTL2832-2.2.2_kernel-3.0.0] Error 2
make[1]: Leaving directory `/usr/src/linux-3.0.4-2'
make: *** [default] Error 2

[giamma]

sorry for my lack of knowledge but how can install the patch to openpli image?

[littlesat]

I suggest it is already in... so you do not need to patch - see post #9