203 replies to this topic

[awx]

Did you have a look at this report?
http://openpli.org/f...__fromsearch__1

Any idea what might have broken multi-language epg?

I will take a look and see if I can figure out what is going on.
All though I am a little perplexed by the issue at the moment.

The problem I am having is every time I find an event with no title, next time I try to use it to debug the title is there.

[ims]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

[awx]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

Also you can't count chars that way because utf8 is multibyte so internally a character may be represented by two or 3 bytes

[awx]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

are you able to reproduce the error easily?

[awx]

There is a bug, I am not sure if this causes the problem but it should be fixed
the line

never mind spoke too soon

Edited by awx, 21 January 2012 - 12:59.

[awx]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

so looking at it closer you have a good point here, the length calculation may be wrong.

[ims]

it seems, same ...

are you able to reproduce the error easily?

why not ? CT1, CT2 on 23.5E... 2-3 item in day...

[ims]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

so looking at it closer you have a good point here, the length calculation may be wrong.

I know :-)

for "í" it count 2 chars, but it is as one char only in debug

[awx]

it seems, same ...

are you able to reproduce the error easily?

why not ? CT1, CT2 on 23.5E... 2-3 item in day...

I don't have a dish pointed at that, so I am not easily able to reproduce it but if you are it would be helpful for testing any potential fix

[awx]

eDebug("+++ eventNameUTF8len: %d", eventNameUTF8len);
+++ eventNameUTF8len: 38

so looking at it closer you have a good point here, the length calculation may be wrong.

I know :-)

for "í" it count 2 chars, but it is as one char only in debug

Could you try this patch
Also if anyone else could test this out that would be great

Attached Files

•  titlefix.tar.gz   1.4KB   10 downloads

[ims]

I have aplied your last patches from morning. This can be used for it ?

[awx]

I have aplied your last patches from morning. This can be used for it ?

Yes, you should be able to use that with it as well.
In the patch from the morning there are 3 new if statements added, maybe you can add a line in there like eDebug("short event descriptor is too short skipping");
This way we can also see if there is any bad data that is being thrown away.

[awx]

I have aplied your last patches from morning. This can be used for it ?

also add this

Attached Files

•  memleakfix.tar.gz   603bytes   6 downloads

[ims]

Same. Still returns for example 38, must be 36

Problem is in length really. When I change lenght -2, it helps for example top.

[awx]

one change to the first if in short event descriptor case
the if should be if( descr_len < 7 )

[awx]

Same. Still returns for example 38, must be 36

Problem is in length really. When I change lenght -2, it helps for example top.

Could you explain where you are chaining the length to -2
as I don't see that this would cause a problem of no titles

if your length was too long but its calculated like this everywhere then you end up wasting 2 bytes more and having garbage data at the end of your text but not an empty title

There are some short event descriptors that don't have a title at all, I have confirmed this much.

[ims]

same...

[ims]

it is strange.

All is displayed, when I changing length -2 (for some title is enought -1) after line:
std::string eventNameUTF8 = replace_all(replace_all(convertDVBUTF8((const char*)&descr[6], eventNameLen, table, tsidonid, &eventNameUTF8len), "\n", " "), "\t", " ");

of course, then are cutted others titles, but all titles are displayed.


Note: must not be in estring.cpp imho. Never saw eventNameUTF8len != eventNameLen:
if( NULL != return_byte_len )
*return_byte_len = t;
and then it must not be in header of fce.

[awx]

it is strange.

All is displayed, when I changing length -2 (for some title is enought -1) after line:
std::string eventNameUTF8 = replace_all(replace_all(convertDVBUTF8((const char*)&descr[6], eventNameLen, table, tsidonid, &eventNameUTF8len), "\n", " "), "\t", " ");

of course, then are cutted others titles, but all titles are displayed.


Note: must not be in estring.cpp imho. Never saw eventNameUTF8len != eventNameLen:
if( NULL != return_byte_len )
*return_byte_len = t;
and then it must not be in header of fce.

I don't think its in the header of the descriptor either as this seems to be fine.
So only place is the conversion and copying to new data array
Perhaps the rebuilding is wrong, but I can't see the error at the moment

[ims]

problem is, that is on several titles only (4-5 title in week)... it must be some with bad char coding or what ... this channels using TSID /ONID wroted there in encoding.conf file.