Jump to content


Photo

eepgcache and title searching


  • Please log in to reply
203 replies to this topic

Re: eepgcache and title searching #61 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 21 January 2012 - 20:04

problem is, that is on several titles only (4-5 title in week)... it must be some with bad char coding or what ... this channels using TSID /ONID wroted there in encoding.conf file.

Its strange because the statement is, with the changes to convert everything to utf8 reverted all is fine again, however we are converting to utf8 the same way we are in the event object, so if that is the case then we should see the same behaviour otherwise it points to a bug in this change.

Re: eepgcache and title searching #62 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 10:40

Here are screenshots with old (epgok) and new code (epgbad). You can see, what missing. May be, it helps you.

Attached Files


Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #63 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 10:56

Here are screenshots with old (epgok) and new code (epgbad). You can see, what missing. May be, it helps you.

Thanks, it looks like in the bad one you have one line of text that is not in the good one, any idea where this comes from?
Looking at that, it seems as if the entire short event descriptor is missing for that program

Re: eepgcache and title searching #64 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 11:45


Here are screenshots with old (epgok) and new code (epgbad). You can see, what missing. May be, it helps you.

Thanks, it looks like in the bad one you have one line of text that is not in the good one, any idea where this comes from?
Looking at that, it seems as if the entire short event descriptor is missing for that program

I've managed to confirm that for events that do not have a title listed, the short event descriptor is not available

Re: eepgcache and title searching #65 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 11:57

for same event as on pictures - there is debug:
eDebug("%s",eventNameUTF8.c_str());
eDebug("%s",textUTF8.c_str());


Sedmipírek
Mezi zloději ÅŸije chlapec s něşnÃœm jménem a tajemstvím. DobrodruÅŸná pohádka (1985). Hrají: A. Navrátil, S. Matyáš, V. Ráş, D. Patrasová, V. Brabec, J. Pleskot, M. Masopust a další. Scénář H. SÃœkorová a M. Kolařík.

=> stored is all OK.
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #66 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 12:25

for same event as on pictures - there is debug:
eDebug("%s",eventNameUTF8.c_str());
eDebug("%s",textUTF8.c_str());


Sedmipírek
Mezi zloději ÅŸije chlapec s něşnÃœm jménem a tajemstvím. DobrodruÅŸná pohádka (1985). Hrají: A. Navrátil, S. Matyáš, V. Ráş, D. Patrasová, V. Brabec, J. Pleskot, M. Masopust a další. Scénář H. SÃœkorová a M. Kolařík.

=> stored is all OK.

Just to be clear, with the modifications to convert the title to UTF8 the event is stored properly in the cache
Its just that later it is not displayed correctly

Re: eepgcache and title searching #67 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:31

it can be ... I think, for displaying will be still working with 2chars EPG and it will be still made conversion for it => strange results...
When I debug in estring.cpp len, t etc , i got still 2x more lines than lines for readed epg => displaying epg still goes into conversion, imho
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #68 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 12:38

it can be ... I think, for displaying will be still working with 2chars EPG and it will be still made conversion for it => strange results...
When I debug in estring.cpp len, t etc , i got still 2x more lines than lines for readed epg => displaying epg still goes into conversion, imho

Could you try a build with this


if( it->second.second[0] != SHORT_EVENT_DESCRIPTOR )
{
eDebug("eventData::eventData crc for short desc was found but is not the crc of a short desc for title '%s'", eventNameUTF8.c_str());


}

this goes in the else position of this if

descriptorMap::iterator it = descriptors.find(crc);
if ( it == descriptors.end() )
{
CacheSize+=len;
descriptors[crc] = descriptorPair(1, d);
}

Re: eepgcache and title searching #69 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 12:41


it can be ... I think, for displaying will be still working with 2chars EPG and it will be still made conversion for it => strange results...
When I debug in estring.cpp len, t etc , i got still 2x more lines than lines for readed epg => displaying epg still goes into conversion, imho

Could you try a build with this


if( it->second.second[0] != SHORT_EVENT_DESCRIPTOR )
{
eDebug("eventData::eventData crc for short desc was found but is not the crc of a short desc for title '%s'", eventNameUTF8.c_str());

}

this goes in the else position of this if

descriptorMap::iterator it = descriptors.find(crc);
if ( it == descriptors.end() )
{
CacheSize+=len;
descriptors[crc] = descriptorPair(1, d);
}

Also the casting in convert to UTF8 could be changed from const char * to const unsigned char *

Re: eepgcache and title searching #70 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:44

before: ++it->second.first; ?
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #71 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:45

Also the casting in convert to UTF8 could be changed from const char * to const unsigned char *


done long time...
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #72 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:48

before: ++it->second.first; ?


added, never displayed in debug log

Edited by ims, 22 January 2012 - 12:48.

Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #73 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 12:48

before: ++it->second.first; ?

it can be before or after, as long as its in the else portion

Re: eepgcache and title searching #74 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:53

as I wrote - never displayed this debug message in debug log
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #75 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 12:55

as I wrote - never displayed this debug message in debug log

ok, thanks

Re: eepgcache and title searching #76 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 12:57

may be it my wrong ideas, but must not be changes some for eventData there in enigma_python.cpp too, when was changed eventData ?
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #77 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 13:08

may be it my wrong ideas, but must not be changes some for eventData there in enigma_python.cpp too, when was changed eventData ?

where is this file, I can not find it

Re: eepgcache and title searching #78 ims

  • PLi® Core member
  • 13,806 posts

+214
Excellent

Posted 22 January 2012 - 13:13

git/lib/python
Kdo nic nedělá, nic nezkazí!

Re: eepgcache and title searching #79 blzr

  • PLi® Core member
  • 2,270 posts

+118
Excellent

Posted 22 January 2012 - 13:26

@awx if you'd like to have some 'test material' this problem occurs just now on Polish ;) TVPKultura...

Attached Files


True sarcasm doesn't need green font...

Re: eepgcache and title searching #80 awx

  • Senior Member
  • 297 posts

+17
Neutral

Posted 22 January 2012 - 13:29

@awx if you'd like to have some 'test material' this problem occurs just now on Polish ;) TVPKultura...

thanks, saved the cache file hopefully this can help track down where the issue is


6 user(s) are reading this topic

0 members, 6 guests, 0 anonymous users