203 replies to this topic

[pieterg]

I am not sure where an external epg is loaded for something like cross epg, so I will have to look into that. That being said the side affects of changing the data format are that previous dat may no longer be compatible.

I think we should not worry about breaking the epg.dat format.
external epg should not abuse the epg.dat dump to 'import' epg data, we have far better methods for that.

There is a small bug in the eventData desctructor
CacheSize -= it->second.second[1];
Should be
CacheSize -= (it->second.second[1] -2);

CacheSize is only cosmetic, isn't it?

[awx]

I am not sure where an external epg is loaded for something like cross epg, so I will have to look into that. That being said the side affects of changing the data format are that previous dat may no longer be compatible.

I think we should not worry about breaking the epg.dat format.
external epg should not abuse the epg.dat dump to 'import' epg data, we have far better methods for that.

There is a small bug in the eventData desctructor
CacheSize -= it->second.second[1];
Should be
CacheSize -= (it->second.second[1] -2);

CacheSize is only cosmetic, isn't it?

I think so, at least I havent seen any meaningful use for it.
I just think we should correct it at some point so that if it ever does have a meaningful use it will be correct.

I was thinking that about epg.dat as well, but I wasnt sure how that would go over.
The most important part for me right now is finding all the places that store eit data that are not related to epgcache, such as eit data for recordings.

With those in one clear format we will be free to change epg.dat format.

Edited by awx, 25 January 2012 - 12:09.

[awx]

For eit data in recordings is there any point in storing the linkage service data?
What about all the strings, is there a point in storing all languages for the strings or only the one the user currently seeing based on their language settings?
If acceptable I would only store the

event id
start time
duration
tiltle
short description
extended description

component data? Is this information not in the meta data for the recording? I dont know if we really need to save this

Edited by awx, 25 January 2012 - 12:15.

[pieterg]

For eit data in recordings is there any point in storing the linkage service data?
What about all the strings, is there a point in storing all languages for the strings or only the one the user currently seeing based on their language settings?

For me, it would be sufficient if we store title+description, in a single language.

[awx]

For eit data in recordings is there any point in storing the linkage service data?
What about all the strings, is there a point in storing all languages for the strings or only the one the user currently seeing based on their language settings?

For me, it would be sufficient if we store title+description, in a single language.

For eit data in recordings is there any point in storing the linkage service data?
What about all the strings, is there a point in storing all languages for the strings or only the one the user currently seeing based on their language settings?

For me, it would be sufficient if we store title+description, in a single language.

Ok, I will hopefully make a change in the next day or so for this, which can already be included in the current images.

To keep compatibility with old eit data recordings, should we change the extension of the filename?
This way all new recordings will use the new data and extension, but recordings with the old format and extension will still have there eit data read properly

[pieterg]

To keep compatibility with old eit data recordings, should we change the extension of the filename?

I think so, as the data will have no relation to 'eit' anymore

[awx]

Here are the latest patches of the new version, including the change to recorded eit data.
This should allow for backwards compatibility with old recorded eit data and decouple us from epgcache at the same time.
As with the previous change needs testing.

Attached Files

•  patches.recorded.eit.tar.gz   8.43KB   11 downloads

[ims]

if it was patches for PLi repository, then i can tell, that in EPG works all ok, but on cca 1/2 of my old recorded files missing all.

[awx]

if it was patches for PLi repository, then i can tell, that in EPG works all ok, but on cca 1/2 of my old recorded files missing all.

also patches are for testing not sure what you mean by the first part of your sentance
what is cca?

Edited by awx, 26 January 2012 - 09:56.

[ims]

patches is continuing of patches from 24 January or it is patches for clear PLi.

cca = circa. around ?

[awx]

patches is continuing of patches from 24 January or it is patches for clear PLi.

cca = circa. around ?

ahh, ok
patches are for the latest status of the pli repo, but they are a test right now
I will take a look and see if I can figure out whats wrong with recordings not showing any data

[awx]

if it was patches for PLi repository, then i can tell, that in EPG works all ok, but on cca 1/2 of my old recorded files missing all.

Could you provide any more details on this?

[ims]

excuse me - problem is on my side. It seems, for this item missing here .eit files. I dont know why, but missing...
For all others it works well.

[awx]

excuse me - problem is on my side. It seems, for this item missing here .eit files. I dont know why, but missing...
For all others it works well.

Ah, ok, thanks for the update

[ims]

I found one problem:

- try run recording, then go to list of recorded movies (video) and see on recorded file. Enigma crash with gdos.

I saw, nevly is created meit and not eit file ? When I tried saw into .meit with Krusader editor, then I got: " ... meit was opened with UTF-8 encoding but contained invalid characters."

After this gdos - enought go to list of files and enigma crashing always. Must be removed .meit and then is possible work woth movie list well.

Attached Files

•  20120126 1512 - Prima family HD - Closer I (5).meit.tar.gz   188bytes   2 downloads

Edited by ims, 26 January 2012 - 15:23.

[pieterg]

BTW, could we rename 'meit' to something like 'info'?
I assume you use plain (UTF-8) text in the file? Or is it some binary format? (haven't looked at the complete patch yet, in detail)

[ims]

Krusader editor and " ... was opened with UTF-8 encoding but contained invalid characters." is normal, ( same for working eit ).

But problem with meit exist.

BTW, why for recorded movie, when eit is missing, is not displayed existing info from meta file ?

[awx]

BTW, could we rename 'meit' to something like 'info'?
I assume you use plain (UTF-8) text in the file? Or is it some binary format? (haven't looked at the complete patch yet, in detail)

I can change it to info, this was just a quick change for the name to test if it works
Its actually not a plain UTF-8 format, its a binary format, but that was first draft, I may change this to a plain UTF-8 format

[awx]

Krusader editor and " ... was opened with UTF-8 encoding but contained invalid characters." is normal, ( same for working eit ).

But problem with meit exist.

BTW, why for recorded movie, when eit is missing, is not displayed existing info from meta file ?

Invalid characters are expected as its a binary format.
I haven't changed any of that code, so the behaviour if the file is missing still should be the same as before.

[ims]

I haven't changed any of that code, so the behaviour if the file is missing still should be the same as before.

...it was question for all, if we talking here about info for recorded files