132 replies to this topic

[sek1973]

I would like to suggest some enhancements for this plugin. It is very good already and has a lot useful features like playing music or pictures but there are still some features which can be added.
First thing: I've noticed that by browsing directory tree it does not remember parent directory. It is a little bit annoying when you go up and selection is moved to the first file instead of pointing the last browsed directory. I changed it. Please find the file attached - now the first file is selected only when you go down in directory tree. Going up moves selection to the already browsed folder.
If there are no complains I will commit it into GIT.
I am wandering if I shall entirely remove selecting first file in directory? In my opinion it is a little bit confusing - especially where there are a lot of directories.
Regards.

Attached Files

•  MovieList.zip   6.12KB   42 downloads

[littlesat]

Thanks for helping out!!! Great....

But could you please post a patch/diff... so we can see what you changed...? That helps to discuss to get it right the way we want...

Edited by littlesat, 17 January 2012 - 23:40.

[sek1973]

Yes, but I'm quite new to those thing, so forgive me if I'm doing something wrong.
Firstly I tried GIT GUI but there was no patch option, now I installed tortoisegit. I generated a Diff file. Please find it attached.

Attached Files

•  movielist.zip   1.41KB   23 downloads

[littlesat]

I think this might be a good idea...

As I understand it correctly... when you going up... (the ..) then in that directory the directory were you came from is auto selected instead of the first entry... If you did it by mistake you get back by simply pressing OK....

[sek1973]

Exactly. I left the functionality to select first file in directory only when you open it. For example:
When your folder contains:
..
dir1
dir2
dir3
file1
file2
opening it means selecting file1
But when you open dir2, going back (up) will cause dir2 to be selected.

[littlesat]

Good idea...

[andyblac]

i have just recode the trashcan in openvix it now supports multi devices, (i.e. every device has their own trashcan), i all so tweaked the coding for file copy/move to allow copy/moving between devices, if this is something you want in PLi i will point out my commits for you.

Edited by andyblac, 18 January 2012 - 17:25.

[littlesat]

In thought Milo did not want separate trashcans for each device... and he had a good reason for it - something I do not remember.

[MiLo]

Copy/move between devices has been possible on OpenPLi for many months, so your patch might apply directly.

[MiLo]

i have just recode the trashcan in openvix it now supports multi devices, (i.e. every device has their own trashcan)

That works for local devices. On network devices, this may result in unexpected behaviour when two boxes start managing it at the same time.
There's also the "keep alive" effect: The trashcan's probing for old data wakes up the drives when they're sleeping. The hooks into the recording service prevent that, but with multiple devices it cannot really tell which disk can be woken up without needlessly disturbing it.

[andyblac]

Copy/move between devices has been possible on OpenPLi for many months, so your patch might apply directly.

nope, you used an old slow copy behaviour, i have moved over to shutil with better results, and it supports symlinks too. and seems to be a lot quicker than than your byte for byte copy.

Edited by andyblac, 18 January 2012 - 20:39.

[andyblac]

i have just recode the trashcan in openvix it now supports multi devices, (i.e. every device has their own trashcan)

That works for local devices. On network devices, this may result in unexpected behaviour when two boxes start managing it at the same time.
There's also the "keep alive" effect: The trashcan's probing for old data wakes up the drives when they're sleeping. The hooks into the recording service prevent that, but with multiple devices it cannot really tell which disk can be woken up without needlessly disturbing it.

well our team has been testing for a few days now, with good results, the offer is there anyway.

[MiLo]

I looked at commit https://www.assembla...4b84945ceb99228 which I suppose is what you're talking about. Looks okay, but there were a few "border cases" that needed attention (such as other processes accessing the files being copied, which is why i passed filehandles around and not filenames). As far as I know, the "byte for byte" copy is just what "cp" and shutil do, I added the routine to be able to get progress feedback. It's probably not worth it, but my measurements showed only a few percent speed difference between the cp command and the copy loop (not surprising).

[sek1973]

Next modification / fix. I've changed the name of configuration class for movie selection module. I've noticed that in new Pli-HD skin the previous name (Config) conflicted with autobackup settings screen. As a result window with title "AutoBackup Configuration" was displayed and MovieSelection setting items didn't fit the list which didn't use the whole screen size.
I've checked and in my opinion there aren't any plugins calling that class directly, so there should be no conflict - the appriopriate config section in skin.xmlis is already present - "MovieBrowserConfiguration". I think it was intended to be like that but perhaps someone forgot to change that class name.
Unfortunatelly there is a mistake in my native language - the screen title should be "Konfiguracja listy nagrań" instead of "Konfiguracja listy kanałów". If somebody can fix it I will appreciate it.
Please find the patch attached.
Regards.

Attached Files

•  0002-Class-MovieSelection.Config-change-compatibility-with-Pli-HD-skin.zip   1.15KB   12 downloads

[sjlouis]

Good idea for the travels in the directories . I try it and I like it.

Is it possible to add other improvements as :
- To use the touch "DirectionUp" to go from the top of the list to the last file. It's possible in some screens.
- All my movies are classified alphabetically, I have a lot of files and It's long to reach a file. It would be convenient to use the numeric touches which are bound to the alphabetical touches. it's possible in the lists of channels where you can select a satellite, an operator...

Thank you for your job .

[sek1973]

@sjlouis: And thank you for your sugestions. I'll analyze it - I think it should be possible and it is a good idea.
Now I'm working on settable colour buttons for sorting and changing list type directly from the Movie Player main screen. I takes long because I'm very time limitted at present.
I'm also wandering if it is good idea to select first file in directory - as it designed currently. For me it is a little bit confusing but I have a lot of subfolders and the list allways rolls down to show that file item. Perhaps I'll also prepare it as a settable option...
Regards.

[sjlouis]

Excuse me, I haven't received an alert for your response. As I don't understand english very well, I'm not sure of your response. I have several folders and the one for the movies contains a lot of files. When i am on the first file, I should want to go to the last one. On some screens you can use the NavigationUp to go to the last element of the list. I should want to have some opportunities to move easily in the list .

If you want, I have a lot of ideas to improve OpenPli nad the current (usual) plugins.

What is the langage used to develop these products please?

[sek1973]

@sjlouis:I have prepared solution where there is possibility to loop through the list up and down. I mean when the first item (this with "..") is selected then the next pressing [up] key moves the selection to the last item (file or directory). When you have the last item selected then pressing [down] key moves the selection back to first item (".."). Please a little bit more patience - I would like to test it. If everything works fine, I'll attach modified files tomorrow.
Additionally I'm modifying sorting funcitionality - I'll describe it in details later.
I am also thinking about this "alphabetic bound" similar to channels selection. It seems to be possible, too.
Regards.

[sek1973]

It seems than everything is working. Plefe files attached.
What I changed:
- MovieSelection Config class name change to adjust to New Pli HD Skin
- Sorting and List type option can now be assigned to color or TV or RADIO keys - it is more convenient for users who have the option save setting per folder activated - no need to go
Menu - Settings - Sort each time
- If sorting is assigned to color key the description of chosen sorting type is displayed (as button label) for 1,5 sec after sorting change
- Directories are now sorted case-insensitive
- When user goes list up or down is looped. Pressing [up] key on the first item moves selection to the last, pressing [down] key on the last item moves selection to the first one.

Can someone from OpenPli Team put it into repository - it seems I don't have the authorisation.
Thanks.

@sjlouis: Jumping to items which begin with appropriate letters will be the next change.

Regards.

Attached Files

•  0001-Modifications-of-Movie-Player-MovieSelection.zip   3.82KB   15 downloads
•  MovieList.zip   5.9KB   8 downloads
•  MovieSelection.zip   13.71KB   12 downloads

[littlesat]

There are some whitespacis in your patch (so lines with only spaces see the -/+ lines with no code in your patch)... And also I see some "defend" comments in your patch that may not be required later - So I suggest they can be revoved and e.g. replaced by the description of your patch.

For the rest I suggest this might indeed be a good idea..
.
Personally I would like to have the sort toggleling on the tags/markers (blue button).... as I never use these

Edited by littlesat, 12 February 2012 - 09:47.