132 replies to this topic

[sek1973]

Hmm, blank lines... I am not an experienced git user. I removed the comments but I have no idea about those lines...
Plese find modified files attached. Could you apply the patch to main repository?
I can check the philosophy of tags - perhaps it will be possible to add new sorting option - if it is what you mean.
Regards.

Attached Files

•  0001-Modifications-of-Movie-Player-MovieSelection.zip   3.78KB   16 downloads
•  MovieList.zip   5.85KB   5 downloads
•  MovieSelection.zip   13.71KB   9 downloads

[sek1973]

What is the langage used to develop these products please?

I forgot to answer this question - sorry.
Enigma2 is designed for linux operation system. It is written in c and python. The main programming language for plugins is python.
Plugins are placed in /usr/lib/enigma2/python/Plugins folder.
Other components written in python you can find in /usr/lib/enigma2/python/ folder. Movie player was designed as a component so its modules are placed in:
/usr/lib/enigma2/python/Components/MovieList.py
and
/usr/lib/enigma2/python/Screens/MovieSelection.py
By developing them you must be very careful because there are other plugins which use Movie Player classes.
If my explanation is not clear to you feel free to ask - my English isn't perfect, eiter...
Regards.

[sjlouis]

Sek, thank you for your work.

Perhaps, I'm going to learn Java. So I thought I should be able to improve tools. If I can find time, I should go to see Python.

For the sorting functions, I think you use the possibility to allocate functions to the buttons in the "Menu" with the last function. Is not it?

Sek, are you French ?

I don't know why I don't receive any warning for the responses on my Email address while I marked the good option. Anyone knows? Because I'm new on the forum?

[littlesat]

In the background we'll discuss this first before it get committed..... Xqq for this so please be a bit more patient.

Edited by littlesat, 13 February 2012 - 17:26.

[sek1973]

In the background we'll discuss this first before it get committed..... Xqq for this so please be a bit more patient.

It's no problem - I'll wait. I hope you'll like my changes but I'm open for a discussion to alter something.
Could you also tell me what do you think about changes proposed by sjlouis:

Is it possible to add other improvements as :
- All my movies are classified alphabetically, I have a lot of files and It's long to reach a file. It would be convenient to use the numeric touches which are bound to the alphabetical touches. it's possible in the lists of channels where you can select a satellite, an operator....

In my opinion it is a good idea although there are some issues that have to be clarified first. For example I have a lot of directories and it would be to very convenient to jump between them according to chosen letter. Moreover items can be sorted by date or shuffled, there could be both files and directories in the list...
Functionality mentioned by sjlouis is realized by eListboxServiceContent component in listboxservice.cpp (function getNextBeginningWithChar). Personaly I would prefer to write the solution for movielist in python - if you don't mind.
And one more thing. Number keys are now assigned to othe actions:

self["NumberActions"] =  HelpableActionMap(self, "NumberActions",
   {
	"0": (self.preview, _("Preview")),
	"2": (self.list.moveToFirst, _("Go to top of list")),
	"5": (self.list.moveToFirstMovie, _("Go to first movie")),
	"8": (self.list.moveToLast, _("Go to last item")),
   })

So what to do:
- change it
- add an option for user in setup?
Regards.

[littlesat]

Please hold on....

[MiLo]

The 1/3/4/6/7/9 keys are also mapped to jumping around while preview is running.

I'd suggest to try and find new keys for the top/first/last keys, leave 0 the preview (because some remotes don't have a play button at all), or find something else that the dm7025/dm800 remotes could use. Or add "preview" as an assignable item. Be creative

During playback, keep using the numbers for jumping around. When playback is not running, use them to locate items as you suggested. You can enable/disable an ActionMap, and layer them to get different functionality based on status.

[MiLo]

I'd merge first before you continue

[sek1973]

For the sorting functions, I think you use the possibility to allocate functions to the buttons in the "Menu" with the last function. Is not it?

Sek, are you French ?

No, I'm from Poland.So we can speak Polish. Apart from that I know German, so if it fits you better, no problem.
Regards.

[sjlouis]

Waoow, I prefer English .

Now in the movielist, if I press "8," I go to the last movie of the list, if I press "2" I go to the directory, if I press "5", I go to the first movie, it's convenient.

And if I press "0", I see the movie in the little window with the different possibilities of jump with the numeric touches instead of the current channel. It's funny.

[sek1973]

I'd merge first before you continue

Thanks - I can see the channges are already there. Good idea with short descriptions for sorting. I would suggest one minor change - it seems that most common "sort by date" means from newest to older - descending. It is currently described as 01/02/03. In my opinion it should be 03/02/01 and "reverse by date" which actualy means descending - 01/02/03.
Regards.

[sek1973]

I prepared a small patch with sorting description corrections. Please find files attached,
Regards.

Attached Files

•  0019-Small-change-in-sorting-description-and-list-order.-.zip   1.04KB   2 downloads
•  MovieSelection.zip   13.67KB   2 downloads

[sek1973]

Hello, this time I would like to offer you more changes. Generally they are connected with adding moveToChar functionality but I had to do some keys remapping and added some minor ehancements: Key points are:[list]
[*]fix for small bug in moveToFirstFile functionality - I wrongly interpreted firstFileEntry variable - my fault, sorry for that.
[*]remapped keys for moveToFirst, MoveToLast and MoveToFirstMovie functions - used ChannelUp and ChannelDown keys (move to first item - first movie - last item in a loop, direction depends on the key)
[*]mapped keys for zap history as move to next / previous song or movie when playing in preview mode - if user goes directory tree and is browsing another folder, selection comes back to played item (listing its folder) and then next or previous item is selected and being previewed
[*]"move to char" functionality added - when user presses number keys appropriate letter is chosen, selection goes to the item which name begins with this letter. Taking into account that we can have different sorting types and both subfolders and files in browsed folder, selection goes always to the next item with this letter instead of first from the top (as it is in channel selection). Additionaly chosen letter is displayed in the screen for 1 sec as an information.
[*]the behavior of number keys can be set in configuration screen (old behavior (move top, first movie, bottom) or "move to char" - as default). It could be also switched at any time by using audio key.
[/list]
I also added functionality "move to char" by ascii as it is in channel selection. Unfortunately I don't have the keyboard to test it, so I'll apreciate any help.

Generally there are quite many changes. I tried to test it as entirely as I could but if somebody is willing to check it would be advisable.

Please find files attached. I had to edit both movielist and movieselection modules but also keymap.xml and skin. Please find patch for skin-PliHD attached.
Regards.

Attached Files

•  0001-Adding-moveToChar-functionality-and-remapping-keys.zip   6.27KB   7 downloads
•  0001-Changed-MovieSelection-skin-to-support-MoveToChar-hi.zip   1.07KB   9 downloads
•  MoviePlayer_MoveToChar.zip   58.91KB   9 downloads

[MiLo]

Sounds good... I'd even like to see the option to get the old behavior removed, just use the new key behavior. Simpler for everyone, there are far too many settings already.

[MiLo]

Please, first, tell your editor to stop adding that UTF-8 header to all the files it saves. It hinders version control.

[MiLo]

There's also something strange with the comment you added, it comes out as a single line of text, I assume you wanted it to be multiple lines.

[sek1973]

Hmm, it's strange. I'm mainly using Notepad++ in Unix/UTF-8 mode. Patch is generated by TortoiseGit (Windows in both cases).The problems you mentioned are with python files or patches? I cannot see this so please suggest what I should do.
About those number keys - I agree and can remove "old behavior" assignment if you really don't mind.

[sek1973]

And small change / fix in MovieSelection (I updated patch).
I suppose the problem with UTF-8 header is still there - sorry for that.
Regards.

Attached Files

•  0001-Adding-moveToChar-functionality-and-remapping-keys.zip   6.26KB   6 downloads
•  0001-Changed-MovieSelection-skin-to-support-MoveToChar-hi.zip   1.07KB   7 downloads
•  MoviePlayer_MoveToChar.zip   58.92KB   11 downloads

[MiLo]

The editor adds two bytes to the start of the file. Tell it to stop doing that. You can even see them in the patch files (you can open them with tortoise and see what I mean).

[sfasf]

Some hints to stop Notepad++ adding these two bytes;

Preferences -> New Document/Default Directory -> Encoding
Check 'UTF-8 without BOM'

Encoding Menu -> 'Encode in UTF-8 without BOM' and/or 'Convert to UTF-8 without BOM'