132 replies to this topic

[sek1973]

@sfasf: Thanks a lot. I reconfigured my notepad++. Hopefully my next patches won't have this problem.
Regards.

[MiLo]

Awaiting your patch...

[sek1973]

Sorry MiLo, it didn't help... I think I know now what you ment - there is indeed difference in first lines of MovieList.py and MovieSelection.py showed by git as change although it shouldn't be...
I tried everything I could - changing modes, formats etc. in Notepad++, I tried also several other editors, even created new empty files in ubuntu (gedit) and copied the contents there. Nothing helped.
If you could suggest something, I'll be gratefull. Otherwise I'm afraid I won't be able to produce a "clean" patch...
Perhaps I damaged those files by previous change and that's the reason for the problem - I tried to edit other files using Notepad++ and then check git Diff - there wasn't any problem similar to this one...

[sek1973]

It seems that the last theory is true - I took unchanged MovieList.py from the repository and Notepad++ showed that it's UTF-8 coded. When I changed to UTF-8 without BOM, git found a difference in first line. Other modules from the repository don't seem to have such a problem. Naturally comming back to UTF-8 in MovieList.py makes the difference to disappear...
I'll take care of it in the future. Tomorrow I'll prepare a new patch but It seems for me that git is not able to correct such a difference by itself, so I think I'll have to ask you to replace the whole MovieList.py file in the repository - I'll prepare it in proper format and attach in the same post tomorrow.
Regards.

[sek1973]

Please find the pach attached.
All files are saved in UNIX, UTF-8 wihout BOM format, so I hope there won't be any problem. Please replace the whole MovieList.py file in the repository.
Additionaly there is a file with patch for Skin-PLiHD but I don't have the link for the right repository, so I used https://github.com/n...skin-PLiHD.git.
If you can give me the proper link I'll check and if it is necessary correct the skin patch. The change in skin is required for char hint displaying.
Thanks and regards.

Attached Files

•  0001-Adding-moveToChar-functionality-and-remapping-keys.zip   6.24KB   7 downloads
•  MoviePlayer_MoveToChar.zip   35.32KB   8 downloads
•  0001-Skin-PLiHD-patch.zip   923bytes   6 downloads

[littlesat]

I see also patches for the skin.... can I apply this or do I need to synchronize these

[sek1973]

@littlesat: Please give the link for the up-to-date skin repository. Is it yours: https://github.com/l...skin-PLiHD.git?
The one from nobody9 seems to be old...

[littlesat]

Git is already upgraded...

[sek1973]

@littlesat: thanks for skin git.
@Pli Team: please find the patch attached. I updated it to include the last changes in MovieSelection.py and skin_default.xml. In my opinion everything is working fine. The only thing I wasn't able to check is extended keyboard ("gotAsciiCode": self.keyAsciiCode) but the solution is copied from ChannelSelection so I don't expect any problems there. Please remember that updating git would require replacing whole MovieList.py file because of UTF-8 BOM format.
Regards.

Attached Files

•  0001-Adding-moveToChar-functionality-and-remapping-keys.zip   6.24KB   2 downloads
•  MoviePlayer_MoveToChar.zip   35.35KB   1 downloads

[ims]

good works :-)

note:
- preview play with < > is well, but when is moved selector to some item, then < > play prev/next item of last item and not item under selector.
- if there in list is little file ( f.eg. 9MB - i know, it is nonsence), then < > dont know skip it.
- TV button does not stop preview playback ... under preview playback it is used as: InfobarActions-showTv instead as MoviePlayerActions-leavePlayer

Edited by ims, 25 February 2012 - 23:45.

[daddelfalk]

Hi sek,

see here for reported GS-issue:

http://openpli.org/f...nduser-support/

Due to your commit:
http://openpli.git.s...83f3025c1c3015e

+ self.numericalTextInput = NumericalTextInput.NumericalTextInput(mapping=NumericalTextInput.MAP_SEARCH_UPCASE)

[sek1973]

Thanks IMS and thanks MiLo.

- preview play with < > is well, but when is moved selector to some item, then < > play prev/next item of last item and not item under selector.

In my intention < > keys enable playing next / previous item relatively to currently played song / movie (in preview). MiLo added starting preview functionality when there is nothing previewed. Mainly because for some STBs we don't have any other key left to assign to... I know what to expect so I like the feature as it is but you are right - for some users it could be confusing. Two possibilities: 1. I can prepare a patch, where < > will only jump to next / previous item when previewed item is still selected. Audio key could be used for jumping to currently previewed item.
2. Resigning of use > key as preview command.
Additionaly I consider overriding << >> keys in preview mode - they will do seeking actions as they do already but additionaly the selection will come back to previewed item.
Later I can add an icon similar to currently being recorded item which will indicate played one.

- if there in list is little file ( f.eg. 9MB - i know, it is nonsence), then < > dont know skip it.

I'm not sure I understand what you mean. Music files are usually smaller so the feature should at least behave defferently for them... I think more desirable feature will be ignoring starting tags in preview mode.

- TV button does not stop preview playback ... under preview playback it is used as: InfobarActions-showTv instead as MoviePlayerActions-leavePlayer

Strange - for sure there is a bug: TV key is by default assigned to "gohome", but at the same time is defined in keymap.xml as "leaveplayer"...
In my opinion the first functionality overrides the other and the simplest way is to clear keymap.xml.
Remember that preview key only stops previewed item if selection is pointing it. Otherwise (by selecting folders) it works similar to OK button - I think, I'll change it - preview button will only start / stop preview - If a folder is selected and any item is previewed it will stop it instead of browsing the folder.
MiLo and other users: if you have any suggestions I'll appreciate it.
Regards.

[MiLo]

see here for reported GS-issue:
http://openpli.org/f...nduser-support/
Due to your commit:
http://openpli.git.s...83f3025c1c3015e
+ self.numericalTextInput = NumericalTextInput.NumericalTextInput(mapping=NumericalTextInput.MAP_SEARCH_UPCASE)

No idea what's wrong - works just fine here after a clean rebuild & install. Maybe some plugin that hacks the NumericalTextInput script?

[MiLo]

Remember that preview key only stops previewed item if selection is pointing it. Otherwise (by selecting folders) it works similar to OK button - I think, I'll change it - preview button will only start / stop preview - If a folder is selected and any item is previewed it will stop it instead of browsing the folder.
MiLo and other users: if you have any suggestions I'll appreciate it.

Using "Preview" on a folder currently lets you go into a folder that would otherwise be played, like the VIDEO_TS folder of a DVD. That's why it behaves like "OK" on a folder instead of stopping playback.

[ims]

- preview play with < > is well, but when is moved selector to some item, then < > play prev/next item of last item and not item under selector.

... and before preview playback with getCurrent() to know, which next/prev item from list will be play in preview ?

- if there in list is little file ( f.eg. 9MB - i know, it is nonsence), then < > dont know skip it.

it is rest of some video file. It plays cca 2sec. But preview playback dont know play it or with next ">" skip it

- TV button does not stop preview playback ... under preview playback it is used as: InfobarActions-showTv instead as MoviePlayerActions-leavePlayer

from Helpmenu it is possible stop, but from RC is used showTv

[sek1973]

@MiLo: To be honest - it was'nt my patch which caused those problems but perhaps you already know it... Never mind - I attached temporary solution for users in both threads.
It is as follows (MovieSelection.py):

@@ -436,7 +436,12 @@ class MovieSelection(Screen, HelpableScreen, SelectionEventInfo, InfoBarBase):
		 self.delayTimer.callback.append(self.updateHDDData)
		 self.feedbackTimer = None
 
-		self.numericalTextInput = NumericalTextInput.NumericalTextInput(mapping=NumericalTextInput.MAP_SEARCH_UPCASE)
+		try:
+			self.numericalTextInput = NumericalTextInput.NumericalTextInput(mapping=NumericalTextInput.MAP_SEARCH_UPCASE)
+		except: #temporary solution for problems with NumericalTextInput
+			self.numericalTextInput = NumericalTextInput()
+			self.numericalTextInput.setUseableChars(u'1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ')
+		
		 self["chosenletter"] = Label("")
		 self["chosenletter"].visible = False

If you want a patch for it, please let me know.
Regards.

[pieterg]

My opinion:
We've always been strongly opposed to skins and plugins which patch/replace system files, and todays problems are a perfect illustration of what we've been warning people against.
I'd say get rid of the problem itself, no need to work around it.

We don't need that ugly 3rd-party stuff in our feed.

Edited by pieterg, 26 February 2012 - 15:04.

[sek1973]

@pieterg: True, I agree - that's the right attitude, I'll remember it.
Thanks a lot for information and help in solving this problem, especially to MiLo and daddelfalk.
Is there any way to be quickly informed in such cases (SMS etc.)?
@ims I'll analyse those issues.
Regards.

[ims]

about "- if there in list is little file ( f.eg. 9MB - i know, it is nonsence), then < > dont know skip it.":

in some cases helps "remove playback position"

[ims]

about "leavePlayer" ... I think, there are active in same time both keymaps with KEY_TV in:
InfobarActions
playbackActions

When I tried it with DMkeyboard, only with STOP button it works. With RC it works only, if I set prio=-1 for InfobarActions, ( then does not work "showTv")