25 replies to this topic

[lolly]

How can I move the progress bar in the channel selection?

Is this in the python or C++ Code?

Attached Files

•  channellisteue3.png   559.2KB   98 downloads

[littlesat]

This is in python code....

But why do you need to change it? Because DMM did put it on the left after we had it for a longer time and you're used to it....?

When we want to make this (e.g. configurable) a setting is required and therefore we need an extra setting, which we should also avoid.... But it can indeed be tried to make it configurable in the same setting... (off or no progressbar, left, right).... Let me think about this.... (config.usage.show_event_progress_in_servicelist now yes no, default = yes could be changed in no, left, right, default right)

Edited by littlesat, 10 July 2012 - 14:03.

[littlesat]

But i just verified some code.... I saw we put it on the left as you wish... so I suggest your skin does overrule it...?

236		 def setMode(self, mode):
237				 self.mode = mode
238				 self.l.setItemHeight(self.ItemHeight)
239				 self.l.setVisualMode(eListboxServiceContent.visModeComplex)
240				 if mode == self.MODE_NORMAL or not config.usage.show_channel_numbers_in_servicelist.value:
241						 channelNumberWidth = 0
242						 channelNumberSpace = 0
243				 else:
244						 channelNumberWidth = 50
245						 channelNumberSpace = 10
246
247				 if config.usage.show_event_progress_in_servicelist.value:
248						 self.l.setElementPosition(self.l.celServiceEventProgressbar, eRect(channelNumberWidth+channelNumberSpace, 0, 52, self.ItemHeight))
249				 else:
250						 self.l.setElementPosition(self.l.celServiceEventProgressbar, eRect(channelNumberWidth+channelNumberSpace, 0, 0, 0))
251				 self.l.setElementFont(self.l.celServiceName, self.ServiceNameFont)
252				 self.l.setElementFont(self.l.celServiceNumber, self.ServiceNumberFont)
253				 self.l.setElementPosition(self.l.celServiceNumber, eRect(0, 0, channelNumberWidth, self.ItemHeight))
254				 self.l.setElementPosition(self.l.celServiceName, eRect(channelNumberWidth+channelNumberSpace, 0, self.instance.size().width() - (channelNumberWidth+channelNumberSpace), self.ItemHeight))
255				 self.l.setElementFont(self.l.celServiceInfo, self.ServiceInfoFont)

Edited by littlesat, 10 July 2012 - 14:10.

[lolly]

I want to change that because I'm used to it

I will show at the afternoon in my skin and the code.

[littlesat]

I would like if someone else changes the code - as that is the intend of opensource software.. but please post it here and make at configurable as I did suggest regards the way to make it configurable.

[lolly]

OK i give my best

And when i have an good result then post i the changes

[littlesat]

Good luck

[Bernado]

This topic reminds me on another 'petition':

http://openpli.org/f...post__p__265535

I still don´t get the point why this approved patch is not integrated in openpli - only disadvantage for user who prefer progress bar on right side is two additional menuentries ...

[Rob van der Does]

But i just verified some code.... I saw we put it on the left as you wish... so I suggest your skin does overrule it...?

A skin cannot overrule this: the list is just one widget, calling 'list'.

[littlesat]

A skin cannot overrule this: the list is just one widget, calling 'list'

In a skin you can relocate/resize stuff by putting additional python code in a skin... see what is e.g. done in the message boxes (and in more places).

Edited by littlesat, 11 July 2012 - 09:04.

[lolly]

My Skin has no python Code in the list widget.

In the Moment have i no idea how can i mak this configurable but i will try my luck @the Weekend

[littlesat]

De plek waar uiteindelijk die progress bar komt staat in c++.... het wordt nogal ingrijpend om dit te veranderen...

http://openpli.git.s...1449d6a;hb=HEAD

[lolly]

Yes it was chabged by this commit.

http://openpli.git.s...66e725e2c8c1448

[littlesat]

You found the exact commit..... but based on the arguments I think it is indeed better to just keep them on the right side as this was intended by us for a long time....

[lolly]

Yes its a number too high for my.

I cant c++

But i will look in my cloned repo an make some test in the next weeks

[lolly]

Big Thanks

http://openpli.git.s...e45d803d9de5d13

Edited by lolly, 12 July 2012 - 21:07.

[ims]

- when are progressbars set left, then is text of event shorter ( seems as text width is reduced with progressbar's width once more )

- could be set right edge cca 5 pixels ? Is not nice, if progressbar or text ending same as selectbar.

[littlesat]

seems as text width is reduced with progressbar's width once more

This could indeed be the fact.... I suggest I need some more finetuning...

What should be adjusted 5 pixels... I do not understand this fully?

Edited by littlesat, 12 July 2012 - 22:11.

[littlesat]

Thanks for reporting. I already fixed that - but please note that this is very unstructured code here....... principally it needs to be partly rewritten for better structure....

[ims]

i

What should be adjusted 5 pixels... I do not understand this fully?

red - text ending in same position as select bar. May be, would be better ending text several pixels before selectbar ( or on character - dont know, if in e2 is function for cut text on character ), same, as text on begin is some pixels left
green - better would be ending on last character

Attached Files

•  text1.jpg   14.78KB   61 downloads
•  text2.jpg   9.33KB   58 downloads