95 replies to this topic

[ims]

@littlesat - I found little bug in zap/prev in EPGSelection. Patch will be soon.

Edited by ims, 15 August 2012 - 15:34.

[littlesat]

I did not discover that yet.... I did just perform some commits....

[ims]

patch is for new status of git.

yes, there was called closeScreen() and then after zap was set old service again

Attached Files

•  0001-repair-bug-in-zap-preview-less-code.patch.tar.gz   810bytes   9 downloads

[littlesat]

Another one... WHen you press TV in MGE the current played service is not high lighted...

Edited by littlesat, 15 August 2012 - 16:03.

[ims]

it was in my Q no2:

"2) when is used in GMEPG preview, change focus in epg list or no (as is with ZAP now) ?"

I made it witthout it - it is ok imho, because TV is preview only and highted will be still current service, imho - you still know, when you use exit, what will be on TV.

If must be hilighted, then it is add 2 lines into def preview(self) - after last line ( in condition)

self["list"].setCurrentlyPlaying(ref.ref)
self["list"].l.invalidate()

Edited by ims, 15 August 2012 - 16:28.

[Dimitrij]

In my opinion you have done something wrong!

open ChannelSelection->key INFO/CUDE->EpgSelection(SINGLE)
change service(EPG)->key Exit->close ChannelSelection
Why?

	    def SingleServiceEPGClosed(self, ret=False):
-			   self.setCurrentSelection(self.savedService)
+			   service = self.getCurrentSelection()
+			   if service is not None:
+					   self.saveChannel(service)
+					   self.addToHistory(service)
+					   self.close()

self.close()-No

IMHO this is my opinion

[ims]

yes, you have truth. I will repair it - close after zap only...

[littlesat]

From the Multi EPG it does not do the zap with RED....

[littlesat]

FYI...

 def zapTo(self):
  if self.key_red_choice == self.ZAP:
   lst = self["list"]
   print lst
   count = lst.getCurrentChangeCount()
   prnt count
   if count == 0:
	ref = lst.getCurrent()[1]
	print ref
	if ref is None:
	 return
	if self.zapFunc: # just used in multiepg
	 self.zapFunc(ref.ref)
	else:
	 self.session.nav.playService(ref.ref)
	self.close(True)

Here was first self.closeScreen called at the end and that rolls back to the service you had before....

[ims]

I will see on it. Here is repair, as wroted Dima73

Attached Files

•  0001-repair-do-not-close-chanelselection.patch.tar.gz   681bytes   7 downloads

[ims]

From the Multi EPG it does not do the zap with RED....

tried, works...

[littlesat]

Forget it... I made a mistake...

[ims]

nothing happens...

[littlesat]

Now another one to the never ending story... when zapping from EPG with RED a service does not get a service number....

[Dimitrij]

I wanted to tell you that it is better to remove the ZAP (red button) from a single EPG.
In my opinion it is absolutely unnecessary.
Leave only the preview.

Edited by Dima73, 15 August 2012 - 20:25.

[ims]

I dont think that it is for nothing... when you browse over channelEPG's and you want zap, you use red.
Before, when you saw some interesant, you must then: Exit, and look for channel with up/down and then ZAP. I made it therefore and I used it long time ago...

[ims]

Now another one to the never ending story... when zapping from EPG with RED a service does not get a service number....

Last movie Never ending story was nr 3... do you think, it will be more ?
It was not well made in e2 before. I think, you'll make it perfect.

Edited by ims, 15 August 2012 - 20:41.

[littlesat]

In addition I discovered another mistake.... WHen in PIPZAP this is not taken in account anywere here... So there is more research required... That pipzap stuff cost me the most time on the channelselection screen....

Currently I leave it now as it is.... time is up....

Edited by littlesat, 15 August 2012 - 20:52.

[ims]

unfortunately, on my 800se with USB DBV-T I cannot test it, i think ...

[Dimitrij]

I dont think that it is for nothing... when you browse over channelEPG's and you want zap, you use red.
Before, when you saw some interesant, you must then: Exit, and look for channel with up/down and then ZAP. I made it therefore and I used it long time ago...

I also used the ZAP.
Only a little differently.

def enterDateTime(self):
  if self.type == EPG_TYPE_MULTI:
   global mepg_config_initialized
   if not mepg_config_initialized:
    config.misc.prev_mepg_time=ConfigClock(default = time())
    mepg_config_initialized = True
   self.session.openWithCallback(self.onDateTimeInputClosed, TimeDateInput, config.misc.prev_mepg_time )
  elif self.type == EPG_TYPE_SINGLE:
   service = self.currentService
   next_service = self.session.nav.getCurrentlyPlayingServiceReference()
   if service and service.ref != next_service:
    name = service.getServiceName()
    self.session.openWithCallback(self.zapConfirmed, MessageBox, _("Zap to %s?") % (name), MessageBox.TYPE_YESNO)
   
def zapConfirmed(self, answer):
  if answer:
   service = self.currentService
   if service:
    InfoBarInstance = Screens.InfoBar.InfoBar.instance
    if InfoBarInstance is not None:
	 CurServiceList = InfoBarInstance.servicelist
	 if CurServiceList is not None:
	  CurServiceList.setCurrentSelection(service.ref)
	  CurServiceList.zap()
	  return True
    self.session.nav.playService(service.ref)

That is, unless I really need it.