260 replies to this topic

[littlesat]

Looks good..... ... when it is completed and it looks for about the original Pli-HD skin I suggest we should adapt it as the standard PLi-HD skin....

[BuGless]

Looks good..... ... when it is completed and it looks for about the original Pli-HD skin I suggest we should adapt it as the standard PLi-HD skin....

I tried to keep the PLi-HD look and feel as much as possible.
Since it is easier to maintain than the original, using it as the default skin would not be a bad idea.
I still have to find a solution for the numerous warnings though; single template works fine, but it should not warn about all the missing elements all the time.

[theparasol]

Bugless, I want to help you but I'm doing something wrong I think. Copied the posted skin.xml to this location and restarted enigma2.

/usr/share/enigma2/PLi-HD/skin.xml

Statusbar is now on top, instead on bottom. Titel now/next is missing. (Or is this what you mean work in progress?)

[BuGless]

Bugless, I want to help you but I'm doing something wrong I think. Copied the posted skin.xml to this location and restarted enigma2.

/usr/share/enigma2/PLi-HD/skin.xml

Statusbar is now on top, instead on bottom. Titel now/next is missing. (Or is this what you mean work in progress?)

The location is fine. Or make a new directory in /usr/share/enigma2 and put it in there, so you can switch between the real PLi-HD and the new one.

As far as missing now/next, no, that should not be the case. All the normal screens you see when using it as a TV/EPG/movieplayer/radio should be fine, no missing parts.
I suspect I have a hidden dependency on some kind of other plugin which I happen to have loaded, which provides some of the information I use in the skin, and which causes problems if the plugin is not loaded. I'll throw away some of the extra modules and check what happens with the infobar, if any parts go missing.

[theparasol]

Perhaps this helps:

my opkg list-installed from my xp1000 box (running openpl3.0 latest)

 xp1000theparasol.zip   2.94KB   6 downloads

[BuGless]

What would help most is the console output of the enigma2 process.
init 4
enigma2 >/var/log/enigma2.log 2>&1

(While logged into the box using telnet or ssh).

[theparasol]

Here you are:

Attached Files

•  enigma2.zip   4.68KB   10 downloads

[BuGless]

Thanks. Looking through it though, I don't seem to see any errors related to the skin.
Is this with the new skin loaded? Does it actually show an InfoBar after booting (and is that part of the log included here)?

[littlesat]

If you mean these two rows...

warning, skin is missing element From in <class 'Screens.Dish.Dish'>
warning, skin is missing element Goto in <class 'Screens.Dish.Dish'>

It's in there for a long time. A From and Goto element could be added in the skin while the dish on a rotor is turning. As I do not own a turnable dish anymore (I'm on T90 now!!!) I cannot test it.

So we need someone with a rotor who is also capable of adding stuff to a skin (xml format) so these two elements could be added to the skin in a proper tested way...

[pieterg]

BTW, I think we should also get rid of all eLabel elements in the skin.
These are not (properly) translatable.
We might consider replacing them by new widgets (with label renderer), which are filled by e2.

This would then of course introduce more 'missing elements' in skins, but I think we could simply get rid of those warnings.

[BuGless]

I cleaned up the other patches, added more explanation, split up patches that should be in separate changesets, fixed some minor issues with the new skin.
Please pickup the patch strain from:

git clone git://devel.cuci.nl/enigma2
cd enigma2
git branch publicb origin/publicb
git checkout -f publicb

The one patch that is mandatory for anyone trying to use the skin is 7ef217c9f "Fix Button and Label classes".

But, I invite any OpenPLi member that has commit rights to examine and cherry-pick patches from the publicb branch and apply them to the enigma2 repository, all rights to the patches are given to OpenPLi, no questions asked.

I attach the latest version of the skin (which is also in the publicb git branch). The hidden dependency on some module which has not been identified as of yet (and which causes empty rectangles in the InfoBar) is still in this version.

Attached Files

•  PLi-Scale-HD.zip   26.66KB   23 downloads

[BuGless]

This would then of course introduce more 'missing elements' in skins, but I think we could simply get rid of those warnings.

Perhaps allow a runtime, or compile time warning level/debug level switch which disables/enables these warnings?

[BuGless]

If you mean these two rows...

warning, skin is missing element From in <class 'Screens.Dish.Dish'>
warning, skin is missing element Goto in <class 'Screens.Dish.Dish'>

Well, not quite. My skin generates a whole boatload of those kind of warnings due to the single-template-fits-all policy.
So since the console log only reports two skin errors, it makes me suspect that this box did not load the new skin.
In loading the new skin, I'm looking for some specific errors which are present there, but not on my own box, which would explain the empty rectangles on theparasol's box.

Edited by BuGless, 13 December 2012 - 11:37.

[Rob van der Does]

It's in there for a long time. A From and Goto element could be added in the skin while the dish on a rotor is turning. As I do not own a turnable dish anymore (I'm on T90 now!!!) I cannot test it.
So we need someone with a rotor who is also capable of adding stuff to a skin (xml format) so these two elements could be added to the skin in a proper tested way...

You don't need to have the motor actually attached; just tell the box it's connected to a motor and you can test it. The box is not going to look if you're telling a lie!

[littlesat]

You don't need to have the motor actually attached; just tell the box it's connected to a motor and you can test it. The box is not going to look if you're telling a lie!

If you know it so well, then please give me the fix....

Edited by littlesat, 13 December 2012 - 12:09.

[BuGless]

But, I invite any OpenPLi member that has commit rights to examine and cherry-pick patches from the publicb branch and apply them to the enigma2 repository, all rights to the patches are given to OpenPLi, no questions asked.

To make it easier to determine if it is worth your while, git log publicb shows the following:

commit 8854788b05228090a052745836d74d4c2973de5f
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Tue Nov 13 23:12:22 2012 +0100

	PLi-Scale-HD skin.  Currently depends on pictures from the PLi-HD skin.

	The look and feel of this skin is roughly equivalent to the original PLi-HD
	skin.

	The main reasons this skin exists:
	- Less filling.
	- Easy modification of screen size/resolution
	  (e.g. it will work on native HD and native SD if so configured).
	- Easy modification of (overscan)margins.
	- Easy modification of font sizes.
	- Easily adjustable/editable layout due to dynamic screen content.
	- Automatically resizing widgets due to changes in screen resolution,
	  margins, font sizes or content.

	TODO;
	- Simplify and unify references to all colours.
	- Weed out unused fonts.
	- Translate the few remaining old-style screens.

commit f68088b03d450b64962a5ec9cf3a0e1c04ad836c
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:05:24 2012 +0100

	GMEPG Fix forgotten repaint background colour.

commit 7310754c261402981b1cae324f9d51fafbcb0c5c
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:18:40 2012 +0100

	GMEPG More consistent up/down arrows when moving between channels.

	The previous behaviour was erratic or chaotic at best.  Moving down and up
	again now allows you to stay in the same column vertically.

commit 07267036b75f8f8983ae0b4464e6acc954441aae
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:23:23 2012 +0100

	GMEPG Center time-labels above columns.

	This means that the date cannot be shown at the upperlefthand corner anymore
	(there is no room left).  The date should be visible in the detail info
	already (or can be made visible at some other available spot on the screen).

commit d04bc4d9284c2dbec125bd534001f41f2781d560
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:25:00 2012 +0100

	GMEPG When pressing Ok, change channel, but don't drop to fullscreen just yet.

	This allows for a smoother search and zap experience, in which you preview
	channels before actually dropping to fullscreen.
	To drop to fullscreen subsequently press exit.  It might be an option to
	map Long-Ok to zap and drop to fullscreen too (not implemented yet).

commit bc6f21c6895749994649599110b1d9f593729e5e
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:21:19 2012 +0100

	GMEPG Align service entries to the left to ease finding where it starts.

	Also turn off line wrap in those entries, because the display can get really
	cluttered otherwise.

commit 85ca334d5eb89497a465d9855d15c6e37e65afa5
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Thu Dec 13 03:15:49 2012 +0100

	GMEPG Increase enforced limits to support bigger screens.

commit 321050698a323946ce5d89ec0beb1401d6c79c48
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Tue Oct 30 00:52:39 2012 +0100

	Condense repeated stdout/stderr line output.

commit cf8f889d1b571b46a871cdf6670f5c2bb0778191
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Fri Dec 7 23:16:46 2012 +0100

	Disable overcommit for non-workstations.

	This allows the STB to reliably report how much memory (including swap)
	is available at all times, and consequently means that the OOM-killer
	is never invoked (and thus no unexpected crashes due to that).

commit b314528ea2ac5cf1dfcff671ce27cee5ed8575af
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Sat Dec 8 23:41:06 2012 +0100

	Record ECM by default.

	It should not hurt (the extra wasted space in the recorded file is negligible
	compared to the total file length), it just increases reliability for those
	boxes that are able to make use of the extra information afterward.

commit 42d7c57d9515f45b47d530af1131367201567e70
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Sun Nov 18 03:11:03 2012 +0100

	Shave off some ms from parsing.

commit 7ef217c9faa66ecb30263aa2916729411a0810e4
Author: Stephen R. van den Berg <srb@cuci.nl>
Date:   Fri Nov 30 00:44:43 2012 +0100

	Fix Button and Label classes to mimick Source to support generic templates in skins.

[Rob van der Does]

You don't need to have the motor actually attached; just tell the box it's connected to a motor and you can test it. The box is not going to look if you're telling a lie!

If you know it so well, then please give me the fix....

Sorry, was only trying to help making things easier for you......

[theparasol]

Thanks. Looking through it though, I don't seem to see any errors related to the skin.
Is this with the new skin loaded? Does it actually show an InfoBar after booting (and is that part of the log included here)?

Sorry for late reaction, was very busy day at work

No, this is not with your skin.xml loaded, its a log from pli-hd skin. I'll post a new log tomorrow (I hope) with your latest skin.xml

[littlesat]

Sorry, was only trying to help making things easier for you......

When you really make it easy for me.... I would like to see a commit patch pushed to the skin on github...
But let's go further on topic here instead of continue a "war"...

[theparasol]

Here the log with your latest skin.xml you posted in this topic. (I never used git before, so dont know how to put that in action!)

Also some screenshots to clear things up!

Attached Files

•  screenshot1.jpg   196.18KB   151 downloads
•  screenshot2.jpg   76KB   154 downloads
•  enigma2.zip   5.83KB   2 downloads