Jump to content


Photo

How to skin a cat?


  • Please log in to reply
260 replies to this topic

Re: How to skin a cat? #141 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 12:13

Do note that the font sizes in the current skin are the same as in the standard PLi-HD. As soon as the few remaining screens have been translated, the font sizes can be tuned (down).

Re: How to skin a cat? #142 littlesat

  • PLi® Core member
  • 57,058 posts

+698
Excellent

Posted 12 February 2013 - 12:19

At least until a commit via a bb file on our sources the ipk will be available from the 3rd party feed from the next builds....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: How to skin a cat? #143 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 13:28

This skin is, as of now, publicly available on permanent repository:

git://devel.cuci.nl/enigma-plugin-skins-pli-scale-hd

Because getting it ready for inclusion in mainstream OpenPLi meant some small changes to the way things are wrapped, I had to change the source URL to:
git://devel.cuci.nl/enigma2-skin-pli-scale-hd;protocol=git;branch=master
instead, or
git://devel.cuci.nl/enigma2-skin-pli-scale-hd
for short.

Edited by BuGless, 12 February 2013 - 13:29.


Re: How to skin a cat? #144 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 12 February 2013 - 15:13

The tuning has reached a stage where it can be published. It's still a WIP (Work In Progress), but it already is very usable and in order to allow others to more easily use it and/or provide feedback, I submitted the patches to OpenPLi now for mainstream inclusion.

Thanks for letting us try your new skin.
First (general) remark: All screens show all colourbuttons, regardless the fact if they can be used in that screen (experienced on UNO on today's PLi).

Re: How to skin a cat? #145 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 15:37

First (general) remark: All screens show all colourbuttons, regardless the fact if they can be used in that screen (experienced on UNO on today's PLi).

Yes, it's a known issue. It's a logical consequence of the fact that there is only a single template for most/all screens. I'd probably need to add support for that in enigma2 first to actually make displaying of the buttons conditional on the button actually being assigned or not. It has a low priority though, other things need to be fixed/changed first.

Re: How to skin a cat? #146 theparasol

  • Senior Member
  • 4,157 posts

+198
Excellent

Posted 12 February 2013 - 16:20

Just cosmetics:

If I press mute I'm getting this:

Seems to me half the text of "Geluid" readable.

Attached Files


@Camping: ZGemma H.2S, Technisat Multytenne 4-in-1 @Home: Edision Mini 4K, Wave Frontier T55, EMP Centauri EMP DiSEqC 8/1 switch, 4x Inverto Ultra Black single LNB


Re: How to skin a cat? #147 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 12 February 2013 - 16:36

Just cosmetics:
If I press mute I'm getting this:
Seems to me half the text of "Geluid" readable.

Actually all text in all screens is too far to the right. I didn't report that, as I have no idea how the 'scaling' will take place (I take it that this scaling is not yet available; is that correct?).

Re: How to skin a cat? #148 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 16:41

Just cosmetics:

LOL... It's a skin, of course, at least 50% is cosmetics.

If I press mute I'm getting this:
Seems to me half the text of "Geluid" readable.


Thanks. Fixed.

Re: How to skin a cat? #149 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 16:46

Actually all text in all screens is too far to the right. I didn't report that, as I have no idea how the 'scaling' will take place (I take it that this scaling is not yet available; is that correct?).

Partly.

You can (manually) simply change the following line to taste:

 <alias name="Overscan"   font="Regular" size="1"  height="20" width="10" />

The 10 means, that the skin currently leaves 10 pixels to the left and 10 pixels to the right "unused". If your texts are running off-screen to the right, increase it to 15 or 20 or 30, whatever you think looks best.
The 20 refers to the number of pixels skipped at the bottom and top, BTW.
The screen as such now, does not have a single lever to adjust overscan at the left and right sides independently. That would be easy to implement though.

Re: How to skin a cat? #150 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 12 February 2013 - 16:49

Ahh, but manually editing files is not what I mean by 'scaling'. I thought scaling would be a GUI option. Or is that WiP as well?

Re: How to skin a cat? #151 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 16:50

Ahh, but manually editing files is not what I mean by 'scaling'. I thought scaling would be a GUI option. Or is that WiP as well?

That is WIP, yes, but not an option until other issues have been resolved first.

Edited by BuGless, 12 February 2013 - 16:50.


Re: How to skin a cat? #152 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 12 February 2013 - 16:54


Ahh, but manually editing files is not what I mean by 'scaling'. I thought scaling would be a GUI option. Or is that WiP as well?

That is WIP, yes, but not an option until other issues have been resolved first.

OK, clear.
Any other (important) issues on the WiP-list (to prevent useless reporting)?

Re: How to skin a cat? #153 littlesat

  • PLi® Core member
  • 57,058 posts

+698
Excellent

Posted 12 February 2013 - 17:00

At least the ET boxes can do scaling with the help of a plugin..... Without changing the skin at all...
I do not know if other boxes can do the same... it might be...

But indeed later this skin can be extended with some config plugin were you can finetune fonts, borders and more... as it is by design extreme flexible...

Edited by littlesat, 12 February 2013 - 17:02.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: How to skin a cat? #154 theparasol

  • Senior Member
  • 4,157 posts

+198
Excellent

Posted 12 February 2013 - 17:01

Give Bugless some usefull feedback Satkiekerd or even better: ............

@Camping: ZGemma H.2S, Technisat Multytenne 4-in-1 @Home: Edision Mini 4K, Wave Frontier T55, EMP Centauri EMP DiSEqC 8/1 switch, 4x Inverto Ultra Black single LNB


Re: How to skin a cat? #155 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 12 February 2013 - 17:02

Any other (important) issues on the WiP-list (to prevent useless reporting)?

The timeline bar at the top of the two GMEPG screens is being worked on. The idea is that it is transparent, but with black lining around the characters, and that the Pig shows through and the description too (on the normal GMEPG screen), and on the GMEPG-listmode screen, I'm still not quite happy with the useless space below the Picon and friends on the right.

It turns out though, that the layout of the timeline is currently being restricted by inadequacies in the C++ parts of enigma2. They're likely to be fixed within a week though.

Re: How to skin a cat? #156 Pale-Rider

  • Senior Member
  • 126 posts

+6
Neutral

Posted 12 February 2013 - 19:18

Give Bugless some usefull feedback Satkiekerd or even better: .......................


Is that not what he's doing ?.

after all in order to understand how something works you must first ask questions or do you just want people to leave comments like WOW or GREAT SKIN ??. This way people gain a working knowledge of the inner workings of the skin and in turn that could inspire others to take up the challenge of creating their own skin, which is a win win for all involved. for example i am finding a lot of SatKiekerd's and BuGless's replies both interesting and informative.

Edited by Frenske, 12 February 2013 - 22:11.
I removed the last lines as I stated in my PM to you. ;)


Re: How to skin a cat? #157 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 12 February 2013 - 21:32


Any other (important) issues on the WiP-list (to prevent useless reporting)?

The timeline bar at the top of the two GMEPG screens is being worked on. The idea is that it is transparent, but with black lining around the characters, and that the Pig shows through and the description too (on the normal GMEPG screen), and on the GMEPG-listmode screen, I'm still not quite happy with the useless space below the Picon and friends on the right.

It turns out though, that the layout of the timeline is currently being restricted by inadequacies in the C++ parts of enigma2. They're likely to be fixed within a week though.

OK; and I take it you're not interested in comments about cosmetic issues?

Re: How to skin a cat? #158 hemertje

  • Forum Moderator
    PLi® Core member
  • 33,503 posts

+118
Excellent

Posted 12 February 2013 - 21:34



Any other (important) issues on the WiP-list (to prevent useless reporting)?

The timeline bar at the top of the two GMEPG screens is being worked on. The idea is that it is transparent, but with black lining around the characters, and that the Pig shows through and the description too (on the normal GMEPG screen), and on the GMEPG-listmode screen, I'm still not quite happy with the useless space below the Picon and friends on the right.

It turns out though, that the layout of the timeline is currently being restricted by inadequacies in the C++ parts of enigma2. They're likely to be fixed within a week though.

OK; and I take it you're not interested in comments about cosmetic issues?


not only about cosmetics...

on the Glassfibre 1GB DVB-C...


Re: How to skin a cat? #159 BuGless

  • Senior Member
  • 539 posts

+16
Neutral

Posted 13 February 2013 - 01:01

OK; and I take it you're not interested in comments about cosmetic issues?


It's a skin, so cosmetics are at least half of the deal (of course).
So, yes, if you have suggestions or questions about cosmetics, please feel free to speak up.

It's just that a skin is at least 50% programming, which deals with the art of programming, so sometimes when a cosmetic change is wanted, it requires structural changes in enigma before the change can be made. Which implies that we are *also* interested in pure cosmetic suggestions which *cannot* be done in any existing skin due to missing support in enigma. If the suggestions/complaints are deemed important enough, I'll add the tools instead of settling for less in the skin.

Which is not to say, if you have suggestions about the actual way the skin.xml is written, i.e. you have suggestions to alter/improve upon the way the skin is programmed, those suggestions are more than welcome too.

Edited by BuGless, 13 February 2013 - 01:03.


Re: How to skin a cat? #160 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 13 February 2013 - 07:27

OK, my first remarks/questions then:
1- You are using a generic template for colour-buttons, using all the usual commands (such as 'name', 'source' and several others). Of course this simplifies the skin code enormously, but at the same time it generates a huge amount of skin-error reports on openeing every single screen. Isn't this an extra load for E2? Anyway: it makes E2 feedback difficult to read.
But even this generic template doesn't show all labels: e.g. the green button in the about-screen has none.

2- You told me you're now working on a way that only those colour-buttons that actually apply to a specific screen will show up. Is that also going to work for the extra buttons several screens need (such as the buttons 'menu', 'info' and 'text')? I already noticed a 'ConditionalShowHide' for the textbutton: is that a first step in that direction?

3- Maybe it will also be possible to create a generic way to display the title? As it is now some screens need a hard 'title="XXXXX", while others generate (translatable) titles with the widget 'source="Title" render="Label" '

4- I take it that all commonly used functionality will get skinned screens? atm several (such as Device Manager and positioner setup) are not skinned.

5- The length (heigth) of the widgets list/config etc is not correct: the length should be a multiple of the item height to be displayed properly. As I understand it fontsize will be configurable: will that take into account the itemheight and height of the widget ( I hope I expressed myself clear enough).

6- General remarks: the distribution over the available space doesn't seem to be optimal (yet).
See e.g. the channel-list: the list is very small (might be widened a bit to the left), and the description area (under the PiG) is too wide: it almost touches the channels.
Also the top bar (with the title etc) is very small (low in height), while at the same time the colour-buttons are still far away from the bottom.


10 user(s) are reading this topic

0 members, 10 guests, 0 anonymous users