198 replies to this topic

[delagroov]

I don't think it was smart to change the name of the skin...... now it was added to our feeds....

Hmm...Erik asked me to use a better name so one knows it is full hd

and I asked about it and he said I could change it om github so all equals then..

So perhaps he misunderstood, but i also pointed that out.

Edited by delagroov, 10 November 2012 - 16:47.

[littlesat]

OK....

[Erik Slagter]

Not exactly like that... Delagroov wanted to change the name of the skin, personally I don't care at all. What I did say, is that if you're going to change the name of the skin, you will need to change it on github as well. Apparently he didn't realise we need to make changes at our side as well, for that. I only got back a few moments a ago, I've applied the changes to my local tree, it's test-compiling now, it'll probably in the repo for tonight's build.

But next time, delagroov, please do this in mutual agreement, especially the exact time...

[delagroov]

Then read your PM again from this morning were we talked...because ypu pointed out to use a name that meakes it clear its an full hd skin.

You sugested EHD what was used in the past and i choose Pli-ful-hd-night and changed it on github..

So we have a slight misundestanding and i realize that the bb files have to be renamed.
But thats only changing names and github..so next time you have to be more clear

[Erik Slagter]

The bb files determine the name of the package. Other bb files depend on this name and need to changed as well, with or without change in github repo name.

[delagroov]

I already understand that part... as far as i can see three files had to be changed with the new name..

But after all I had the impression from you i needed to change it then on github also, so the github name is equel to the package name..
so thats what i did after our PM this morning and reported it also

But really...I got a bit annoyed ...but it sorted out well now...

Edited by delagroov, 10 November 2012 - 20:55.

[pieterg]

and now we'll have two conflicting packages in the feed (renamed packages are not automatically removed / updated)

[littlesat]

That were exactly my concerns....

[littlesat]

P.S.

Bovendien is de skin (nog) niet beschikbaar voor de DM800HD.... (die nog als enige HD box op OpenPLi-2.1 zit)

[hemertje]

english here

[Erik Slagter]

Yes I didn't explain the consequences, indeed. Tomorrow there will be probably two packages excluding each other, and then we will get it right for the day after that.

[littlesat]

On this skin the top is totally black... it would nice to have it grey as the orriginal... then finally it might be a real EHD version of the orriginal PLi-HD skin....

And in fact full HD is also not correct.... EHD was better

Edited by littlesat, 10 November 2012 - 23:34.

[kocus37]

Hi i update openpli 3.0 today and try this new skin from delagroov and is great but as someone refers before in my tv the background apears in grey, i like it more in black like in the original PLI-HD, or a soft black, and in epg in the description of the program, in the bottom left it apears in bouble. But its great, more detailed, good job. Thanks

[theparasol]

Bovendien is de skin (nog) niet beschikbaar voor de DM800HD.... (die nog als enige HD box op OpenPLi-2.1 zit)

I already noticed that and I'm waiting for a nice openpli teammember to add it to the DM800 HD PVR feeds

[MiLo]

One request to delagroov: Please remove the "version number" in the top of the file. That line also contains the licensing information, so if you change that line, you change the license, and then the build fails because it won't build until someone manually checks the licensing terms...

[littlesat]

I would recommend simply remove a version number in the xml itself...

[Erik Slagter]

I can understand why someone would have a version number in the contents, because the author doesn't have influence on the version number in package (other than git commit hash).

[littlesat]

For version revision you use github So why is it needed?

[Erik Slagter]

For end-users...

[littlesat]

Then you can use the date the image was installed/upgraded....