747 replies to this topic

[umtauscher]

I have a new issue with todays update (2013-02-10) to the pts plugin.
There is a new dialog/warning when you switch away form an active timeshift which would destroy the buffer. Unfortunately this dialog is shown, even when the program is live.
I really like the warning, when I'm in the buffer but it is really not necessary when the program is live.

I think the warning is programmed for normal timeshift, where you have to start timeshift manually. When using PTS -as the background recording is started automatically- I get a warning with every channel change which is not how it's supposed to work.
Additionally all zap options of the pts plugin are ignored when the warning is shown.

I hope you can understand what I mean.
Thanks
Umtauscher

Edited by umtauscher, 10 February 2013 - 17:52.

[littlesat]

When the program is live and timeshifting it is required... as you can also break the timeshift - and therefore drop the buffer. The PTS plugin can also be changed so it steal the new warning and do other thinks with that instead of hacking into several zapping instructions.... Now PTS could hack into one place.... .....

Edited by littlesat, 10 February 2013 - 17:55.

[Dimitrij]

I have a new issue with todays update (2013-02-10) to the pts plugin.
There is a new dialog/warning when you switch away form an active timeshift which would destroy the buffer. Unfortunately this dialog is shown, even when the program is live.
I really like the warning, when I'm in the buffer but it is really not necessary when the program is live.

I think the warning is programmed for normal timeshift, where you have to start timeshift manually. When using PTS -as the background recording is started automatically- I get a warning with every channel change which is not how it's supposed to work.
Additionally all zap options of the pts plugin are ignored when the warning is shown.

I hope you can understand what I mean.
Thanks
Umtauscher

only test
http://openpli.org/f...post__p__333370

Edited by Dima73, 10 February 2013 - 18:10.

[umtauscher]

As I said, I would like the warning very much, when I'm back.
It's just not necessary when live.
Aditionally it cannot be switched off, even if you don't care at all.
Cheers

Edited by umtauscher, 10 February 2013 - 18:34.

[littlesat]

Then you do not understand that even with live the timeshift recording is "gone".... At least normally...

But again.... the PTS should be changed... Instead of giving the warning screen it should take it over and use auto recording, manual choice etc.... All the zapping hacks can be removed from PTS now.... Finally it can be made better....

Dima73 is busy with that as far I understand. He already has an experimantal new PTS plugin... (I'm happy he wants to do this).

Edited by littlesat, 10 February 2013 - 18:45.

[malakudi]

Until the Permanent timeshift plugin is changed, please add an option for this "warning". Something like "Show warning when zapping and timeshift is on", even defaulting to "Yes" if you think it is better. I personally don't want to see this warning (with or without PTS), I understand that when zapping, I will loose the timeshift buffer. Don't treat all users as ignorants.

[littlesat]

Until the Permanent timeshift plugin is changed, please add an option for this "warning".

I will not do that right away... Try the experimantal PTS from the link above.... It was a big request for a lot of other guests on the forum...

P.S. you cannot make it perfect for everyone...

Edited by littlesat, 10 February 2013 - 18:51.

[malakudi]

Until the Permanent timeshift plugin is changed, please add an option for this "warning".

I will not do that right away... Try the experimantal PTS from the link above.... It was a big request for a lot of other guests on the forum...

It's not about the PTS plugin. I don't want this warning even in normal timeshift. Why should I accept your way of thinking? An option is needed, not all people are the same.

edit: Yes, you can make it, just put the option to disable this warning. Then anyone can configure it the ways he wants it. I don't understand why this is a big issue. I could prepare the patch for you if you don't want to spend the time for it. But an option is definitely needed. Defaulting to "Yes" wil be as it is now, user can change it to skip warning.

Edited by malakudi, 10 February 2013 - 18:56.

[littlesat]

Then use an image from before friday.... We first want to avoid extra settings and configurations....

Why should I accept your way of thinking?

Because we cannot make it right for everyone...

An option is needed, not all people are the same.

I agree....

Edited by littlesat, 10 February 2013 - 18:55.

[malakudi]

Great attitude. Well done.

[littlesat]

Who has a great attitude here?

But your wish is my command .... see the commit coming in a few minutes...

[littlesat]

Just committed.....

http://openpli.git.s...e16e186f64179fa

Edited by littlesat, 10 February 2013 - 19:30.

[MrKappa]

As I understood this "warning" when you change the channel can be removed in the next update, right? thanks

PS: I just saw the new commit....

Edited by MrKappa, 10 February 2013 - 19:54.

[littlesat]

Yep... Indeed...

[betacentauri]

1)et9000
2)problem only permanent timeshift plugin,standart timeshift work fine
3)activate permanent timeshift plugin -> switch to any service -> press button rewind(<<) -> 80% black screen

I have debugged it without the plugin. I have started timeshift and switched back to live tv. After pressing rewind the black screen is shown and then e2 switches back to live tv. This is what happens:
Rewind starts activateTimeshiftEnd in python which calls switchToTimeshift in c++ part. switchToTimeshift seeks back(-1000) to the end of timeshift file. After seeking "wait for driver eof ok" is shown in the log. That means EOF event is generated. After seeking switchToTimeshift pauses the playback. Back in python another seek (-90000) is executed. A little bit later activateTimeshiftEnd is called a second time. This time timeshift is active and so the playback is unpaused(see python code). Afterwards event processing of EOF event starts. EOF in play mode causes a switch to live tv!
Sometimes event processing starts before unpausing and then rewind works properly.
@pieterg: Is it possible to start event processing manually?
If I comment out the seek in switchToTimeshift, it works properly. Or when I seek after pausing. But this is only by accident. It would be better to process the events after pausing manually. Or do you have another (better) idea?

[littlesat]

So removing the seek in python fix it?

I know it is tricky code there... I found also a way to do a stepskip back from livemode... But this needs finetuning too.... Work in progress from my side... Rewind back i never use... I usually do a pauze and unpauze get restart timeshift when it became in livemode.

Edited by littlesat, 10 February 2013 - 20:12.

[malakudi]

Just committed.....

http://openpli.git.s...e16e186f64179fa

Thank you very much. After all it was indeed possible to "make it right for everyone".

[littlesat]

Sure... And thanks for the thanks... Please next time don't push it as a have to... The config was already in preparation here, but usually we want to avoid extra configs so i didn't commit yet... I thought everyone was happy with the warning.

As far i remember that seek in python was added there in the past for the pts plugin.

Edited by littlesat, 10 February 2013 - 20:17.

[malakudi]

Sure... And thanks for the thanks... Please next time don't push it as a have to... The config was already in preparation here, but usually we want to avoid extra configs so i didn't commit yet... I thought everyone was happy with the warning.

My intension was not to say "do it now, you have to". I even suggested to prepare the patch myself if you couldn't afford time on that. Maybe we were "lost" in translation (english is not my native language).

Thank you again.

[littlesat]

No problem.... let's continue our hobby.....
Now we need some finetuning to get the "playback" right when timeshift is in livemode...

And than probably some finetuning in the PTS plugin....
But still the way timeshift is implemented in E2 is terrible....we have to make the best of it...

Today for me no coding anymore...

Edited by littlesat, 10 February 2013 - 20:40.