747 replies to this topic

[Dimitrij]

great attitude!

Thanks

I did not mean to offend you, but ...
We probably do not understand each other.
The very name of the plugin says it all - the permanent timeshift.
Permanent =automatic
Why do we need a warning every time you zap it works?
It is automatic!!!
Then by your logic, every time you zap, it is necessary to ask the user to enable timeshift(yes/no)?
Warning function in openPli made ​​for standard timeshift we manually enabled before.
That's a warning makes sense.
Logic plugin not mine and I do not change it.

P.S.Ask other people what they think of your logic...

[Dimitrij]

I have a simple question about the patch:
1) Enable timeshift
2) rewind Live TV
3) choose to save timeshift
4) zap
5) no save timeshift

Who can check out?

[betacentauri]

Did you test with or without the pts plugin?

I think I have tested this scenario and it worked for me. I'm currently at work and can't test.

[Dimitrij]

Did you test with or without the pts plugin?

Yes.
Without the pts plugin.

[mik9]

I still do not understand how it does cover overlay as EPG times are not equal. I suggest his must be extreme tricky or this is not done at all... But if it is done it must start dual recordings or something like that.

It uses standard user defined time in config.recording.margin_after.

[littlesat]

Why do we need a warning every time you zap it works?

I see you complete patched this warning out... leave it to the user...
And in addition in the PTS plugin you can better "steal" this function as zap detector instead of using the several zap detectors that are currently in the PTS plugin.
But hopefully the PTS plugin will be not required anymore in the near future...

It uses standard user defined time in config.recording.margin_after.

And what about the dual recordings? During "the overlap" it must do something...

Edited by littlesat, 25 February 2013 - 09:49.

[nietgiftig]

I did no tests with permanent timeshift plugin, but normally there should be no problems using it.
It would be great if someone can test it. If there are problems please inform me.

I did a short test.
I have always PTS active, it does not show up as PTS is active, I think this according to your plan

After I removed PTS from the box, i had to make timeshift active.
I'm not sure if standard timeshift always is running, but i had to start timeshift manually.

Then the 2 menu items you discribe are in the recording menu.
I tried "Save timeshift file in movie directory", and after 2 minutes I zapped away.
Then I got the question "stop timeshift?"
After I clicked yes, the program was put in the movie directory.

I do not know if all of this is according to you plan.

Personal I think that time shifting must always run on the channel that your watching, no need for manual starting timeshift.
In the recording menu there should be an option to save the timeshift, by that I mean the program you are watching from the moment you zapped to it (maybe limited to the last 2 hours or so) until the moment you click "save timeshift".
The timeshift must keep running after the save.
There don't have to be any warnings, if you zap away you probably do not want to save the timeshift, otherwise you have a useful Learning Moment, "THINK before you zap"

If you got this working, then you can think about working with markers and / or to be able to save a part of the active timeshift file or to build a small library (say the last 5 channel timeshifts, auto save after zap and remove the oldest) and the possibility to save individual files from that "library".
More option possible, the sky is the limit.
But this is my opinion about this subject, others may differ

[littlesat]

With the new saving options we could e.g. add...

1. start timeshift automatically (e.g.) 5 seconds after a zap... -> ON/OFF (why should we make this seconds programmable?)
2. automatically store a timeshift recording when you zap... (with the markers of service events included)

Indeed when you program the warning screen OFF... (and I can understand when you permanently do a timeshift this is not wanted) Zap means "Think before"... but when you record all timeshifts you disk can get easily full...

So whan addition can also be done... only give that warning in case the timeshift is not saved yet...

3. Warning screen on zap when timeshift enabled -> Yes, Never, Only when timeshift is not stored...

Just to add to the "brainstorm"

[SpaceRat]

1. start timeshift automatically (e.g.) 5 seconds after a zap... -> ON/OFF (why should we make this seconds programmable?)

Because zapping behaviour differs. Some people zap very quickly through the channels and will want a short waiting time before automatic timeshift is started. Others may take quite some time until they decide on which program they want to stay, a short waiting time would fire recording uselessly often for them.

[littlesat]

What is a short waiting time.... ??????
I suggest it is not recommendable to make too much configurable.... I know it is easy to make, (OFF, 5, 10, 20 ... 60 seconds) but here again we should think more than twice.....
And the checkiftimeshiftisrunning can be (mis)used to detect a zap and start an auto timeshift start timer....

Edited by littlesat, 25 February 2013 - 14:18.

[SpaceRat]

What is a short waiting time.... ??????

For me, 15 sec for example would be pretty short ... too short. But for "quick zappers" it might be just great.

I think I would set it somewhere in between 1 and 2 min.

[Dimitrij]

Just to add to the "brainstorm"

My opinion ...
1)аs the basis of the functional plugin PTS
2)type timeshift-automatic or manual

[umtauscher]

Just to add my setting.
I always use the minimum 5sec to start recording.

So you are right, everyone has his own pace.

@Dima73
Thanks, probably you are right, we misunderstood each other. Let me try again:
I certainly don't suggest a warning with every zap. That would certainly annoy everone.
What I was suggesting was the warning, when you are not at the live point and you accidentally zap away. After that, the buffer is deleted and you have no chance to see the missing part when switching back. So it would be better to have a warning before the zap gets executed so you can change your mind before the buffer is destroyed.
Sometimes I am in timeshift and someone else enters the room and zaps away, not knowing that I was watching timeshiftet. If a warning would be issued then, he or she could "reconsider" before destroying my timeshift buffer.
I hope that explains what I mean.
Thanks

Edited by umtauscher, 25 February 2013 - 16:24.

[littlesat]

аs the basis of the functional plugin PTS

That is what you're used to.... I think PTS should not be rebuilded....

Edited by littlesat, 25 February 2013 - 16:47.

[Meega]

With the new saving options we could e.g. add...

1. start timeshift automatically (e.g.) 5 seconds after a zap... -> ON/OFF (why should we make this seconds programmable?)
2. automatically store a timeshift recording when you zap... (with the markers of service events included)

Indeed when you program the warning screen OFF... (and I can understand when you permanently do a timeshift this is not wanted) Zap means "Think before"... but when you record all timeshifts you disk can get easily full...

So whan addition can also be done... only give that warning in case the timeshift is not saved yet...

3. Warning screen on zap when timeshift enabled -> Yes, Never, Only when timeshift is not stored...

Just to add to the "brainstorm"

I don't know what you all want to do with timeshift but i don't think it's a good idea to save the hole timeshift automaticly.
Because in some cases people are timeshifting on usb and it takes a lot of time to save the timeshift to the moviedir on the hdd.
It has to be selectable and by event.(i think)

And about the zapping when you're watching timeshift,i thought that when you press the numbers on the remote that would only skip the shift?

So when you want to zap you first have to press the stop button.(just like a recording)

If i am able to shut down the timeshifting in Pli then there's no problem for me because i will use pts further because that plugin works perfectly for me.

Now pts works like this

1 automatic timeshift within 5 sec.
2 you can zap when you are watching live.
3 when you watch timeshift ,the skipping buttons work.
4 also the rewind and forward buttons(dm8000) works and the play and stop and pauze buttons works.
5 press the rec button and you can choose which event you want to save,so you don't have to record like 4 hours.

[Dimitrij]

That is what you're used to.... I think PTS should not be rebuilded....

Save timeshift by events ideal option...

[betacentauri]

I have a simple question about the patch:
1) Enable timeshift
2) rewind Live TV
3) choose to save timeshift
4) zap
5) no save timeshift

Who can check out?

Hi Dima73,

I have tested it here again and it works. Can you post a log. Or better (I haven't added proper log entries) can you put a debug log message in __serviceEnd, so that we can see whether the procedure is called? Then you can also output the new filename and the old one.
Perhaps then we can see what's wrong.

[betacentauri]

I did a short test.
I have always PTS active, it does not show up as PTS is active, I think this according to your plan

Not really , but it's good that you don't see the entries while pts plugin is active.

After I removed PTS from the box, i had to make timeshift active.
I'm not sure if standard timeshift always is running, but i had to start timeshift manually.

Then the 2 menu items you discribe are in the recording menu.
I tried "Save timeshift file in movie directory", and after 2 minutes I zapped away.
Then I got the question "stop timeshift?"
After I clicked yes, the program was put in the movie directory.

I do not know if all of this is according to you plan.

Yes, that's my plan. And thanks for the test!!

[betacentauri]

To all the other mentioned things:
I personally don't have the time to rewrite the whole timeshift sources. From my side we should add step by step little new features which go in the right direction. Storing timeshift file is one of the things. Automatic start of timeshift another. Perhaps also an event driven timeshift or using markers while timeshifting.
Many things are possible(so let's brainstorm), but we also have some challanges.
E.g. if we have only one timeshift file and timeshift starts automatically, how can we avoid filling up the whole hard disk space when the receiver accidently didn't go to standby after a recording (this happens in my case 1-2 times in a year). Stop and start timeshift every x hours automatically is not a really good idea. And 2 timeshift recordings at the same time is currently not possible... (also not for PTS plugin).

[littlesat]

By storing timeshift recordings to the trashcan as standard the oldest will be automatically be deleted...