747 replies to this topic

[betacentauri]

I think pts plugin does merging, or?
I don't know how difficult it is.

It would be better if backend could handle it without copying afterwards ...

[Dimitrij]

I think pts plugin does merging, or?
I don't know how difficult it is.

pts plugin not merge.
This is the last thing i want to do for timeshift.
and correct these errors http://openpli.org/f...post__p__337494

[betacentauri]

and correct these errors http://openpli.org/f...post__p__337494

To 1: I'll try to test whether my suggestion works. If it works, I'll provide a patch.
To 2: As said before pieterg tried to tune it with no success: http://openpli.org/f...post__p__332900
To 3: If I have time (not very likely) I'll look at it.

[Dimitrij]

To 1: I'll try to test whether my suggestion works. If it works, I'll provide a patch.
To 2: As said before pieterg tried to tune it with no success: http://openpli.org/f...post__p__332900
To 3: If I have time (not very likely) I'll look at it.

Thank you.
to 3 ...
it is more a problem for pts plugin(automatic /permanent mode) than for standard timeshift.

[betacentauri]

Hi pieterg,

it's regarding this bug http://openpli.org/f...post__p__335405.
I have patched tstools.cpp in this way:

diff --git a/lib/dvb/tstools.cpp b/lib/dvb/tstools.cpp
index 8f5e3c9..fa3a913 100644
--- a/lib/dvb/tstools.cpp
+++ b/lib/dvb/tstools.cpp
@@ -807,6 +807,9 @@ int eDVBTSTools::findFrame(off_t &_offset, size_t &len, int &direction, int fram
				}
		}

+	   // found frame must be after/before given offset
+	   if ((direction >= 0 && start < _offset) || (direction < 0 && start > _offset)) return -1;
+
		len = offset - start;
		_offset = start;
		if (direction < 0)

I have tested this:
- Fast forwarding with > 8x speed while timeshifting SD and HD -> at end of timeshift it switches without problems to live tv
- Fast forward in radio timeshift -> not working, but also don't work without my patch
- Fast forwarding with > 8x speed in normal recording -> no problems
- Fast forwarding with > 8x speed in normal recording without .ap and .sc file -> no problems
- Fast forwarding with > 8x speed in normal recording without .ap but with .sc file -> no problems
Also fast rewinding works without problems.

Can you please take a look at it and change it in git??

[pieterg]

I'm just a bit worried about what happens when callers ignore the return value of findFrame, and expect to be returned a valid frame at all times.
Did you check who uses this function, and whether they should handle this correctly?

[betacentauri]

No, I didn't check callers. Didn't thought about this, because there are a couple of "return -1" in the procedure.
Well, wait some minutes. I'll check all callers....

[betacentauri]

findFrame is only called twice (one time in tstools.cpp and one time in dvb.cpp). Both times return value is checked.

[pieterg]

I have no time to test things right now, but as you have given it thorough testing, I've applied it.

[betacentauri]

Thanks!

[littlesat]

You thanks for this suggestion....

[Dimitrij]

littlesat
Please help me.
Where does this information here?

self.session.nav.getCurrentService()

and

def getTimeshift(self):
  service = self.session.nav.getCurrentService()
  return service and service.timeshift()

Edited by Dima73, 5 March 2013 - 08:15.

[littlesat]

Where is it?

[Dimitrij]

Where is it?

InfoBarGenerics.py
class InfoBarTimeshift

[littlesat]

And why is that quationable?
(or do you have suggestions?)

[Dimitrij]

And why is that quationable?
(or do you have suggestions?)

I do not know why.
Therefore, I want to ask you.
You are an expert in Enigma.

No signal from the satellite.
Start timeshift(standart)
And it works, how can this be???

item 3(log)
http://openpli.org/f...post__p__337494

[littlesat]

Could be somehow related... This function just get the reference to the currently played service.... and when this is not playing it takes a service from self.pnav in Navigation.py.. (even when it is not really playing yet).

Probably we need to add a function getCurrentService (without Ref) in Navigation and get simply self.getCurrentService back there...

But as far I understand as soon that the service is tuned... the timeshift will go-on...
So the big question here... is this really a bug?

Edited by littlesat, 5 March 2013 - 12:08.

[Dimitrij]

So the big question here... is this really a bug?

Who else should check out.
Log.
Two channels, where there is no signal at the moment.
Timeshift but it works.

[littlesat]

But if this bad.???

The same could happen when you do timeshift and timeshift works and you have a real bad stormy rain??? As far I undrestood you slimply get an empty timeshift recording because there is no data yet...

Edited by littlesat, 5 March 2013 - 13:53.

[kocus37]

In that way timeshift could work with IPTV, streaming channels....