747 replies to this topic

[littlesat]

There cannot be a boolean returned there... I should be stop, continue, save or save_movie..... Even with stop timeshift....

I suggest you did not use the complete patch....

Edited by littlesat, 18 April 2013 - 08:34.

[Dimitrij]

Version PTS 1.3c

-fix icon seekstate if PTS not enabled(for standart timeshift)

[Dimitrij]

There cannot be a boolean returned there... I should be stop, continue, save or save_movie..... Even with stop timeshift....

I suggest you did not use the complete patch....

You probably did not understand me?
Press exit when the message about stopping timeshift on the screen.

Who can confirm the error?

[Dimitrij]

    def checkTimeshiftRunningCallback(self, returnFunction, answer):
+        if answer:
            if "movie" in answer:
                self.save_timeshift_in_movie_dir = True
            if "save" in answer:
                self.save_timeshift_file = True
                self.saveTimeshiftFiles()
            returnFunction(answer != "continue")
+        else:
+            returnFunction(False)

[littlesat]

Why is this required? I do not see the problem...

The only values we get there should be stop, continue, save and save_movie...? So answer should always have a value..? Answer should be a string here...

 

When/Where will there be a bool returned?

Edited by littlesat, 19 April 2013 - 07:58.

[Dimitrij]

Why is this required? I do not see the problem...

The only values we get there should be stop, continue, save and save_movie...? So answer should always have a value..?

No press OK=  stop, continue, save and save_movie

Press exit

[Dimitrij]

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 192, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Tools/BoundFunction.py", line 9, in __call__
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1607, in checkTimeshiftRunningCallback
    if "movie" in answer:
TypeError: argument of type 'bool' is not iterable
(PyObject_CallObject(<bound method Session.processDelay of <__main__.Session instance at 0x2391508>>,()) failed)
wait for driver eof timeout
 

[littlesat]

Thanks.... Indeed... I missed that...

Better give me something how to trigger an issue

Edited by littlesat, 19 April 2013 - 08:15.

[Dimitrij]

Done

[littlesat]

Can you chech this....?

 

 def checkTimeshiftRunningCallback(self, returnFunction, answer):
  if answer:
   if "movie" in answer:
    self.save_timeshift_in_movie_dir = True
   if "save" in answer:
    self.save_timeshift_file = True
    ts = self.getTimeshift()
    if ts:
     ts.saveTimeshiftFile()
     del ts
   self.saveTimeshiftFiles()
  returnFunction(answer and answer != "continue")

[Dimitrij]

Can you chech this....?

 

 

 def checkTimeshiftRunningCallback(self, returnFunction, answer):
  if answer:
   if "movie" in answer:
    self.save_timeshift_in_movie_dir = True
   if "save" in answer:
    self.save_timeshift_file = True
    ts = self.getTimeshift()
    if ts:
     ts.saveTimeshiftFile()
     del ts
   self.saveTimeshiftFiles()
  returnFunction(answer and answer != "continue")

Everything is OK.

[littlesat]

Hopefully I did not make approx the same mistake this morning in recordQuestionCallback.... (e.g. it is cached up by this row.... if answer is None or answer[1] == "no":) So I'll wait before committing...

Edited by littlesat, 19 April 2013 - 08:43.

[Dimitrij]

del

Edited by Dima73, 19 April 2013 - 08:54.

[Dimitrij]

Version PTS 1.3d

-Fix GSOD when press save and save movie dir checkTimeshiftRunning message

-add save and save movie file timeshift for checkTimeshiftRunning message if not PTS save

Edited by Dima73, 20 April 2013 - 18:45.

[jakey]

There seems to be a problem with 1.3d.

 

On zapping it is randomly saving timeshift events which take up space on the timeshift device which in my case is a USB stick.

 

 

 

[Dimitrij]

*.ts and *.ts.sc= user selected save timeshift

pts_livebuffer.* will be removed when changing service

[jakey]

But I didn't select to save them and anyway shouldn't they be saved to /hdd/movie and not the timeshift device ?

 

Yes I know about pts_livebuffer

 

I think I narrowed down the problem, It happens when you look at 'Timeshift save recording(Select event)' but DO NOT press ok to select something.

 

So just looking at an event to save evokes a save.

[Dimitrij]

But I didn't select to save them and anyway shouldn't they be saved to /hdd/movie and not the timeshift device ?

 

Yes I know about pts_livebuffer

 

I think I narrowed down the problem, It happens when you look at 'Timeshift save recording(Select event)' but DO NOT press ok to select something.

 

So just looking at an event to save evokes a save.

Ok, I saw.
Now let's see what's up.

[Dimitrij]

Version PTS 1.3e

- fix save  timeshift if not answer(required to re-configure setup "Timeshift-save action on zap")

-add setup Behavior key long record(start/stop instant record  /  open list timeshift event)

[jakey]

@Dima73, thanks for the update all seems to be ok now as far as I can see. Although Long press record does nothing here.

Edited by jakey, 21 April 2013 - 18:34.