8 replies to this topic

[Dimitrij]

Open the channel selector.
Event on the current service ended and started a new one.
Detailed description is left of the old event.
patch...
ServiceEvent.py

def newService(self, ref):
  #if not self.service or not ref or self.service != ref:
  self.service = ref
  if not ref:
   self.changed((self.CHANGED_CLEAR,))
  else:
   self.changed((self.CHANGED_ALL,))

[Dimitrij]

No one answered ...
And leave the bug is not corrected?

[littlesat]

We do not understand what has been corrected.... At least use +/- or some indicators please so we understand.....

[Dimitrij]

--- a/ServiceEvent.py

+++ b/ServiceEvent.py

@@ -23,9 +23,8 @@

  info = property(getInfo)



  def newService(self, ref):

-  if not self.service or not ref or self.service != ref:

-   self.service = ref

-   if not ref:

-    self.changed((self.CHANGED_CLEAR,))

-   else:

-    self.changed((self.CHANGED_ALL,))

+  self.service = ref

+  if not ref:

+   self.changed((self.CHANGED_CLEAR,))

+  else:

+   self.changed((self.CHANGED_ALL,))

[Dimitrij]

or

--- a/ChannelSelection.py
+++ b/ChannelSelection.py
@@ -403,7 +403,7 @@
  def updateEventInfo(self):
   cur = self.getCurrentSelection()
   service = self["Service"]
-  service.newService(cur)
+  service.newService(cur, force = True)
   self["Event"].newEvent(service.event)

class ChannelSelectionEPG:
--- a/ServiceEvent.py
+++ b/ServiceEvent.py
@@ -22,8 +22,8 @@
  event = property(getCurrentEvent)
  info = property(getInfo)

- def newService(self, ref):
-  if not self.service or not ref or self.service != ref:
+ def newService(self, ref, force = False):
+  if force or not self.service or not ref or self.service != ref:
    self.service = ref
    if not ref:
	 self.changed((self.CHANGED_CLEAR,))

[littlesat]

Is this one patch or the other solving the same issue

I suggest the first patch is even making the code more readable (than it ever was before)... so the first is enough to fix what you want?

[Dimitrij]

Is this one patch or the other solving the same issue

I suggest the first patch is even making the code more readable (than it ever was before)... so the first is enough to fix what you want?

yes

Edited by Dima73, 12 February 2013 - 10:30.

[littlesat]

Can you post your complete patched ServiceEvent.py... as I'm lazy....

[Dimitrij]

Can you post your complete patched ServiceEvent.py... as I'm lazy....

Leave as is.
It is no necessary.