In theory:
- The amount of extra wasted space is negligible.
- It only adds information which some boxes cannot do anything with, but it shouldn't hurt either (or does it?).
- It puts in extra robustness for those boxes that can make use of the extra information.
Suggested patch:
commit 61e3a4fc877f9fcad610dc6a487492bc68598cf3 Author: Stephen R. van den Berg <srb@cuci.nl> Date: Sat Dec 8 23:41:06 2012 +0100 Record ECM by default. It should not hurt (the extra wasted space in the recorded file is negligible compared to the total file length), it just increases reliability for those boxes that are able to make use of the extra information afterward. diff --git a/RecordTimer.py b/RecordTimer.py index 7dfd705..046126c 100644 --- a/RecordTimer.py +++ b/RecordTimer.py @@ -110,7 +110,7 @@ class RecordTimerEntry(timer.TimerEntry, object): Notifications.AddNotification(Screens.Standby.TryQuitMainloop, 1, onSessionOpenCallback=RecordTimerEntry.stopTryQuitMainloop, default_yes = default_yes) ################################################################# - def __init__(self, serviceref, begin, end, name, description, eit, disabled = False, justplay = False, afterEvent = AFTEREVENT.AUTO, checkOldTimers = False, dirname = None, tags = None, descramble = True, record_ecm = False): + def __init__(self, serviceref, begin, end, name, description, eit, disabled = False, justplay = False, afterEvent = AFTEREVENT.AUTO, checkOldTimers = False, dirname = None, tags = None, descramble = True, record_ecm = True): timer.TimerEntry.__init__(self, int(begin), int(end)) if checkOldTimers == True: @@ -471,7 +471,7 @@ def createTimer(xml): else: tags = None descramble = int(xml.get("descramble") or "1") - record_ecm = int(xml.get("record_ecm") or "0") + record_ecm = int(xml.get("record_ecm") or "1") name = xml.get("name").encode("utf-8") #filename = xml.get("filename").encode("utf-8") diff --git a/lib/python/Screens/TimerEntry.py b/lib/python/Screens/TimerEntry.py index 05c3e5b..120c1f3 100644 --- a/lib/python/Screens/TimerEntry.py +++ b/lib/python/Screens/TimerEntry.py @@ -108,7 +108,7 @@ class TimerEntry(Screen, ConfigListScreen): else: shutdownString = _("shut down") self.timerentry_afterevent = ConfigSelection(choices = [("nothing", _("do nothing")), ("standby", _("go to standby")), ("deepstandby", shutdownString), ("auto", _("auto"))], default = afterevent) - self.timerentry_recordingtype = ConfigSelection(choices = [("normal", _("normal")), ("descrambled+ecm", _("descramble and record ecm")), ("scrambled+ecm", _("don't descramble, record ecm"))], default = recordingtype) + self.timerentry_recordingtype = ConfigSelection(choices = [("descrambled+ecm", _("descramble and record ecm")), ("normal", _("normal")), ("scrambled+ecm", _("don't descramble, record ecm"))], default = recordingtype) self.timerentry_type = ConfigSelection(choices = [("once",_("once")), ("repeated", _("repeated"))], default = type) self.timerentry_name = ConfigText(default = self.timer.name, visible_width = 50, fixed_size = False) self.timerentry_description = ConfigText(default = self.timer.description, visible_width = 50, fixed_size = False) diff --git a/lib/service/servicedvbrecord.cpp b/lib/service/servicedvbrecord.cpp index 75355ab..fb2b075 100644 --- a/lib/service/servicedvbrecord.cpp +++ b/lib/service/servicedvbrecord.cpp @@ -18,7 +18,7 @@ eDVBServiceRecord::eDVBServiceRecord(const eServiceReferenceDVB &ref, bool isstr CONNECT(m_event_handler.m_eit_changed, eDVBServiceRecord::gotNewEvent); m_state = stateIdle; m_want_record = 0; - m_record_ecm = false; + m_record_ecm = true; m_descramble = true; m_is_stream_client = isstreamclient; m_tuned = 0;