3 replies to this topic

[scp]

Running a channel search in (First) Install Wizard crashes at checkTimeshiftRunning on non existing InfoBar, patch attached.

 

Attached Files

•  enigma2-20130507-ScanSetup.zip   497bytes   12 downloads

[littlesat]

 def keyGo(self):
   infoBarInstance = InfoBar.instance
-  if infoBarInstance:
+  if infoBarInstance is not None:
    infoBarInstance.checkTimeshiftRunning(self.keyGoCheckTimeshiftCallback)
   else:
    self.keyGoCheckTimeshiftCallback(True)
@@ -954,10 +954,10 @@
 
  def keyGo(self):
   InfoBarInstance = InfoBar.instance
-  if InfoBarInstance:
+  if InfoBarInstance is not None:
    InfoBarInstance.checkTimeshiftRunning(self.keyGoCheckTimeshiftCallback)
   else:
-   InfoBarInstance.checkTimeshiftRunning(True)
+   self.keyGoCheckTimeshiftCallback(True)
 
  def keyGoCheckTimeshiftCallback(self, answer):
   if answer:

The mistake in the second part has already being changed... That was a "Typo" from me..

 

http://sourceforge.n...19d5d4edf194e4/

 

And adding the "is not None" make no difference... This is really not required added code...

When it is not None then simply it is already always True  

(I know we see this still on different locations in Enigma2)...

Edited by littlesat, 8 April 2013 - 06:56.

[scp]

Sorry, it was my fault (or sf?)

I did not know that there is a difference between

http://openpli.git.s...i/enigma2;a=log

and
http://sourceforge.n...penpli/enigma2/
 

gitweb still says [e30c97] is master.

[betacentauri]

Regarding sourceforge see this thread
http://openpli.org/f...view=getnewpost