First thing I can judged and I did merge it.
merge requests for PLi's git
Started by Persian Prince, 16 Apr 2013 12:12
1748 replies to this topic
Re: merge requests for PLi's git #1341
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 27 July 2019 - 18:18
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1342
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 5 August 2019 - 13:08
https://github.com/O...e-core/pull/719 (Add FileCommander e2openplugins)
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1343
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 5 August 2019 - 13:25
Done...
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1344
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 5 August 2019 - 16:54
https://github.com/O...e-core/pull/720 (packagegroup-openplugins.bb: Add FileCommander)
https://github.com/O...e-core/pull/690 [Avoid PAK archive (application/x-pak)]
It's safe and if you check OE itself I sent them too and they merged them.
https://github.com/O...e-core/pull/687 (DLNAServer & ReadyMedia)
You need to squash merge this one, we're using this in Open Vision so tested.
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1345
-
- PLi® Core member
- 70,485 posts
+1,810
Excellent
Posted 5 August 2019 - 17:33
Done.
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: merge requests for PLi's git #1346
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 26 August 2019 - 10:06
https://github.com/O...e-core/pull/728 (Don't hardcode path)
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1347
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1348
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 6 September 2019 - 01:03
JFI still there are some "os.system" in enigma2 instead of "Console.ePopen":
https://github.com/O...ter/main.py#L21
https://github.com/O...arddisk.py#L242
https://github.com/O...arddisk.py#L247
https://github.com/O...arddisk.py#L273
https://github.com/O...arddisk.py#L279
https://github.com/O...ageInfo.py#L370
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1349
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 6 September 2019 - 06:49
Terrible... should indeed be fixed... can you help?
Edited by littlesat, 6 September 2019 - 06:49.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1350
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 6 September 2019 - 08:48
The first one is not running in E2....
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1351
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 6 September 2019 - 09:06
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1352
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 15 September 2019 - 15:03
https://github.com/O...igma2/pull/2274 [Harddisk.py: Replace missing os.system with Console().ePopen]
What about these kind of calls which are in enigma2-plugins:
os.system("cp /tmp/bouquet/"+item[1]+" /etc/enigma2/"+item[1])
os_system("cp '%s' '%s'" %(target[1],plugin_path+"/"+file))
os.system("echo "+ choice[1] +" > /tmp/.webselect | wget -O /tmp/index.html "+ radirl +""+ choice[1])
os.system("wget -O '"+ mcpath +"radio/"+ selection[1] +"' '"+ radirl +""+ gen[0] +""+ selection[1].replace(" ", "%20") +"'")
os.system("echo '"+ str(title) +"' > /tmp/.oldplaying | echo '"+ str(title) +"' > /tmp/.curplaying ")
os.system("echo '"+ str(title) +"' > /tmp/.curplaying")
What's the correct form?
Edited by Persian Prince, 15 September 2019 - 15:04.
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1353
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 15 September 2019 - 15:08
Replace them by Console.ePopen and then instead of building the command with + try using %s instead.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1354
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 15 September 2019 - 15:13
Yeah I know that but isn't it just ugly to have so many hardcoded things like "/tmp/.oldplaying" or "/tmp/.curplaying" which we can define them once in the plugin.
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1355
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 15 September 2019 - 15:17
E.g.
-os.system("wget -O '"+ mcpath +"radio/"+ selection[1] +"' '"+ radirl +""+ gen[0] +""+ selection[1].replace(" ", "%20") +"'")
+Consile().ePopen("wget -O '$sradio/%s' '$s%s%s'" % (mcpath, selection[1], radirl, gen[0], selection[1].replace(" ", "%20") ))
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1356
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 15 September 2019 - 15:19
os.system("echo '"+ str(title) +"' > /tmp/.curplaying")
->
Console().ePopen("echo '%s' >/tmp/.curplaying" % str(title))
Console().ePopen("echo '%s' >%s" % (str(title), self.TMP_CUR_PLAYING)) ??
Edited by littlesat, 15 September 2019 - 15:20.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1357
-
- PLi® Core member
- 8,458 posts
+327
Excellent
Posted 15 September 2019 - 19:35
ePopen/os.system to spawn a shell in order to echo something and redirect this to a file?
What happened to old good open(x).write(y)??
Finaly those os.system calls most probably are not sanitized, so a special command can be created to take over control of the box.
Just replacing os.system with ePopen is not making things way more efficient.
Also plugins relaying on blocking behavior of system call with fail once switch to ePopen.
What happened to old good open(x).write(y)??
Finaly those os.system calls most probably are not sanitized, so a special command can be created to take over control of the box.
Just replacing os.system with ePopen is not making things way more efficient.
Also plugins relaying on blocking behavior of system call with fail once switch to ePopen.
Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916
Re: merge requests for PLi's git #1358
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 15 September 2019 - 19:39
...
Edited by littlesat, 15 September 2019 - 19:40.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1359
-
- PLi® Core member
- 57,154 posts
+698
Excellent
Posted 15 September 2019 - 19:41
Also for copy you have funtions in the python library... looks like these plug-ins are badddddd
Also for wget you can use urllib ot twisted
Also for wget you can use urllib ot twisted
Edited by littlesat, 15 September 2019 - 19:42.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1360
-
- PLi® Core member
- 10,323 posts
+350
Excellent
Posted 16 September 2019 - 05:15
res = Console().ePopen(cmd)
please test
ePopen not answer
res = os.system(cmd)
return (res >> 8)
GigaBlue UHD Quad 4K /Lunix3-4K/Duo 4K
6 user(s) are reading this topic
0 members, 6 guests, 0 anonymous users
