Forums

I’m saying working more together is better then working separately in different forks. E.g. regarding the integrated multi epg... agree something and get it integrated there where you did fork from.... (use a fork for development and push it back)... the point is that you have forks due to miss agreement. At the and indeed the users can choose but do they really benefit? (Devs need work twice on same stuff, images do not have all features so you need to swap for features,!less flash room due to multiboot - lol).
Edited by littlesat, 18 April 2021 - 08:54.

@pp
You’re currently pushing so match stuff that it might be better to start a pp-merge request thread

@pp
You’re currently pushing so match stuff that it might be better to start a pp-merge request thread

 

This is my thread

 

You missed https://github.com/O...gimport/pull/52 I think.

Indeed it is your thread .....

Wierd.... here it is open AND merged???

 Knipsel.JPG   78.13KB   1 downloads

That "merged" label refers to PR 2921 in the Enigma2 repo...

Kan you do it?

Kan you do it?

 

Nobody can when there's a conflict unless someone fix it.

 

The way you merge PRs is wrong as you need to check PR numbers first.

 

You need to go with older PR first, now take a look at what happened, because of one file a PR with more than 40 files is ruined and I need to send it again

Sorry!

I just sent again:

 

https://github.com/O...gimport/pull/54

 

https://github.com/O...igma2/pull/2932

Merged

Thanks!

https://github.com/O...igma2/pull/2941 (1 week old PR)

 

https://github.com/O...igma2/pull/2962 (cherry-pick jbleyel commit from ATV, currently available in OV)

Plese delete this line

https://github.com/O...e9294eb0a105dR4

or

echo "PEP8 double aggressive safe cleanup"

 

Edited by Dimitrij, 30 April 2021 - 06:41.

 

Plese delete this line

https://github.com/O...e9294eb0a105dR4

or

echo "PEP8 double aggressive safe cleanup"

That's a message and won't be in commit logs, see Open WebIF and you'll understand my script won't add any names to the commits: https://github.com/E.../commits/master

 

This tool won't be running by users remember it.

Edited by Persian Prince, 30 April 2021 - 07:07.

Firstly, I don't see any problems here at all.

Why is this necessary?

 

Secondly, this is the decision of the openPli team.

Edited by Dimitrij, 30 April 2021 - 08:05.

https://github.com/O...igma2/pull/2962 (cherry-pick jbleyel commit from ATV, currently available in OV)

 

Edited by Taapat, 30 April 2021 - 08:08.

 

https://github.com/O...igma2/pull/2962 (cherry-pick jbleyel commit from ATV, currently available in OV)

 

I think this is the wrong solution.

Relying on the fact that the source code is installed does not mean that the plugin is working properly.

I think if you need some functionality from plugin, you need to check this with a specific function import from plugin and not just with the existence of source code.

 

Your idea may be better but this a replacement for https://github.com/O...tup.py#L96~L108 pyo checks that's all.

Can somebody please merge this?

https://github.com/E...Webif/pull/1601

Done