1748 replies to this topic

[neo]

Merged

[Dimitrij]

Please apply

[werbezapper] update - thanks @Stan

[epgimport] add option "Execute shell command before import EPG"

[littlesat]

I will merge but for embedded screens with different resolutions we have a much easier system…. Without tripling the skin code

Edited by littlesat, 16 July 2023 - 09:42.

[Dimitrij]

I will merge but for embedded screens with different resolutions we have a much easier system…. Without tripling the skin code

Agree.

And thanks.

[tension]

Division error.

diff --git a/filebrowser/src/ui.py b/filebrowser/src/ui.py
index 5999a4de..265e0429 100644
--- a/filebrowser/src/ui.py
+++ b/filebrowser/src/ui.py
@@ -438,10 +438,10 @@ class FilebrowserScreenInfo(Screen):
                 x, y = self.getLineSize()
                 wsize = (x + 2 * mx, 4 * y)
                 self.instance.resize(eSize(*wsize))
-                self["path"].instance.move(ePoint(mx, y - y / 4))
-                self["size"].instance.move(ePoint(mx, 2 * y + y / 4))
-                wx = (w - wsize[0]) / 2
-                wy = (h - wsize[1]) / 2
+                self["path"].instance.move(ePoint(mx, int(y - y / 4)))
+                self["size"].instance.move(ePoint(mx, int(2 * y + y / 4)))
+                wx = int((w - wsize[0]) / 2)
+                wy = int((h - wsize[1]) / 2)
                 self.instance.move(ePoint(wx, wy))
 
         def getLineSize(self):

 

[littlesat]

Do we need two times // here due to py3? Maybe better than force to integer.

Edited by littlesat, 22 July 2023 - 10:23.

[Huevos]

Do we need two times // here due to py3? Maybe better than force to integer.

Yes, if your c++ code can't handle floats.

[littlesat]

In the py2 to py3 conversion it should be simply //. It is not mandatory to make changes to c++ code. Forwarding floats to c++ here does not have any real added value beside you can work a round missed stuff around the py2 to py3 change. At the end with // and no change in c++ you force more structured code.

Edited by littlesat, 22 July 2023 - 12:33.

[WanWizard]

That is what Huevos says?  Fix it in python, as you can't pass a float to ePoint?

[littlesat]

He points to we cannot fix it in c++… that is how I read it

[WanWizard]

Oh. I didn't.

 

I've pusht a fix using integer division.

[littlesat]

[littlesat]

Oeps! Looks like you missed two lines

 

https://github.com/O...68fb5aa36716355

 

Lines 441 and 442 do still miss the integer division '//'....

Edited by littlesat, 24 July 2023 - 15:08.

[Huevos]

 the integer division '//'....

'//' is not integer division, it is floor division.

>>> 4.1 / 2
2.05
>>>
>>> 4.1 // 2
2.0
>>>

If all your inputs are integers the return value will be an integer too, otherwise a floored float.

 

If you are not sure what your inputs are you need to use int().

Edited by Huevos, 24 July 2023 - 16:38.

[WanWizard]

How did python2 do implicit conversion from float, internally?

[WanWizard]

'//' is not integer division, it is floor division.

 

integer devision is the same as floor devision, both don't round but truncate.

 

And:

Python 2.7.18 (default, May 25 2023, 00:00:00) 
[GCC 13.1.1 20230511 (Red Hat 13.1.1-2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> int(5/2)
2

so in these cases using // is fine.

[WanWizard]

Oeps! Looks like you missed two lines

 

https://github.com/O...68fb5aa36716355

 

Lines 441 and 442 do still miss the integer division '//'....

 

I didn't check the entire file, I just addressed the issue that was posted by @tension.

[littlesat]

Integer devision is the same as floor devision, both don't round but truncate.https://www.learndat...loor() function.actually it is the same

Edited by littlesat, 24 July 2023 - 21:28.

[mrvica]

The link above won´t open, I corrected it

https://www.learndat...floor()function

[littlesat]

Thanks to fix the link...