1748 replies to this topic

[captnoord]

but some things in the E2 code fail to compile when C++ exceptions are enabled.

 

I don't think that would be hard to fix for anyone, I wonder why it hasn't been fixed yet.

[ims]

gst-plugins-good: fixed mp4 parser bug here

[ims]

patch for PLi

Attached Files

•  0001-gst-plugin-good-fixed-mp4-parser-bug-by-Andreas-Monz.patch   2.12KB   8 downloads

[littlesat]

Does it work on openpli?

[ims]

do not know where it shows exactly, but when I saw into its qtdemux.c under PLi, there f.eg. is  

demux->upstream_size = seekable ? stop : -1;

and then it cannot be boolean, imho

[zakalibit]

I have a question regarding some recent httpstream changes, I see a fix for chunked transfer for the code 200, then it was reverted back with a comment saying that it breaks some other streams, could I get some more details, I see no problem doing a chunked transfer if response code is 200 and there is a chunked transfer header.

probably pieterg can answer this ?

[pieterg]

I don't have any more details.
Malakudi suggested to check for chunked transfer for status code 200 as well, which lead to d318d544cf76ea58c4f12bccc0541d888af7570c, but after two days he reported this broke some of his other streams, so we reverted the change.

[zakalibit]

that change looks very reasonable, I have seen few providers doing chunked with 200 code, do not see how it can break other streams, only if chunked header is present but it is not chunked. as well I do not see those streams working wit ffmpeg for example

[zakalibit]

I found where is the problem

 

this wont work anyway due to the incorrect string comparison expected value:

 

if (statuscode == 206 && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")))
 

 

 

it needs to be changed to:

 

if (statuscode == 206 && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
 

 

 

so to make it work for 200 and 206, we should simply do:

 

if (strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}
 

Edited by zakalibit, 7 August 2014 - 21:45.

[hemertje]

Please use the [code ] tags

[zakalibit]

a bit better impl would be:

if (!isChunked && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}

to avoid excessive string comparisons 

[littlesat]

Thnaks ims for the gstreamer patch.... Mp4 that did not work here are working here now!

[Erik Slagter]

a bit better impl would be:

if (!isChunked && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}

to avoid excessive string comparisons 

This sounds very reasonable, thanks!

[Erik Slagter]

Zakalibit, comitted. I forgot to mention your credit, excuse!

[Erik Slagter]

do not know where it shows exactly, but when I saw into its qtdemux.c under PLi, there f.eg. is  

demux->upstream_size = seekable ? stop : -1;

and then it cannot be boolean, imho

 

AFAIK Littlesat has committed this. Littlesat can you please acknowledge patches you have committed?

[zakalibit]

Zakalibit, comitted. I forgot to mention your credit, excuse!

 

Not a problem, very good that it is done quickly  

[zakalibit]

Zakalibit, comitted. I forgot to mention your credit, excuse!

I think there is no need to check for status code, I think the code should be as I posted above, it will work as is now as well, but code checking does not give anything useful there.

And could you please bring all strcmp() to the same form, i.e. !strcmp(), as we have strcmp() == 0 variation as well

Edited by zakalibit, 8 August 2014 - 10:24.

[littlesat]

Erik, what do you mean?

[Erik Slagter]

I mean if you apply/commit/push something, that you leave a message in the relevant thread that it's done, so others (from the team AND the contributor) can see in a blink of an eye whether it's done or not.

[littlesat]

Xqq