Jump to content


Adblock Plus
Advertising seems to be blocked by your browser.

Please notice that advertising helps us to cover the cost of hosting the project.

If you find these ads displayed intrusive or inappropriate, please contact the webmaster.
Photo

merge requests for PLi's git


  • Please log in to reply
1748 replies to this topic

Re: merge requests for PLi's git #601 captnoord

  • Member
  • 22 posts

+10
Neutral

Posted 4 August 2014 - 19:09

but some things in the E2 code fail to compile when C++ exceptions are enabled.

 

I don't think that would be hard to fix for anyone, I wonder why it hasn't been fixed yet.



Re: merge requests for PLi's git #602 ims

  • PLi® Core member
  • 13,949 posts

+215
Excellent

Posted 5 August 2014 - 12:29

gst-plugins-good: fixed mp4 parser bug here


Kdo nic nedělá, nic nezkazí!

Re: merge requests for PLi's git #603 ims

  • PLi® Core member
  • 13,949 posts

+215
Excellent

Posted 5 August 2014 - 13:48

patch for PLi

Attached Files


Kdo nic nedělá, nic nezkazí!

Re: merge requests for PLi's git #604 littlesat

  • PLi® Core member
  • 57,468 posts

+708
Excellent

Posted 5 August 2014 - 14:12

Does it work on openpli?

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #605 ims

  • PLi® Core member
  • 13,949 posts

+215
Excellent

Posted 5 August 2014 - 14:25

do not know where it shows exactly, but when I saw into its qtdemux.c under PLi, there f.eg. is  

demux->upstream_size = seekable ? stop : -1;

and then it cannot be boolean, imho


Kdo nic nedělá, nic nezkazí!

Re: merge requests for PLi's git #606 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 7 August 2014 - 19:05

I have a question regarding some recent httpstream changes, I see a fix for chunked transfer for the code 200, then it was reverted back with a comment saying that it breaks some other streams, could I get some more details, I see no problem doing a chunked transfer if response code is 200 and there is a chunked transfer header.

probably pieterg can answer this ?



Re: merge requests for PLi's git #607 pieterg

  • PLi® Core member
  • 32,766 posts

+245
Excellent

Posted 7 August 2014 - 19:23

I don't have any more details.
Malakudi suggested to check for chunked transfer for status code 200 as well, which lead to d318d544cf76ea58c4f12bccc0541d888af7570c, but after two days he reported this broke some of his other streams, so we reverted the change.

Re: merge requests for PLi's git #608 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 7 August 2014 - 20:08

that change looks very reasonable, I have seen few providers doing chunked with 200 code, do not see how it can break other streams, only if chunked header is present but it is not chunked. as well I do not see those streams working wit ffmpeg for example



Re: merge requests for PLi's git #609 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 7 August 2014 - 21:41

I found where is the problem :)

 

this wont work anyway due to the incorrect string comparison expected value:

 

if (statuscode == 206 && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")))
 

 

 

it needs to be changed to:

 

if (statuscode == 206 && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
 

 

 

so to make it work for 200 and 206, we should simply do:

 

if (strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}
 

Edited by zakalibit, 7 August 2014 - 21:45.


Re: merge requests for PLi's git #610 hemertje

  • Forum Moderator
    PLi® Core member
  • 33,506 posts

+118
Excellent

Posted 7 August 2014 - 21:43

Please use the [code ] tags

on the Glassfibre 1GB DVB-C...


Re: merge requests for PLi's git #611 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 8 August 2014 - 07:35

a bit better impl would be:

if (!isChunked && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}

to avoid excessive string comparisons 



Re: merge requests for PLi's git #612 littlesat

  • PLi® Core member
  • 57,468 posts

+708
Excellent

Posted 8 August 2014 - 08:28

Thnaks ims for the gstreamer patch.... Mp4 that did not work here are working here now!

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #613 Erik Slagter

  • PLi® Core member
  • 46,969 posts

+542
Excellent

Posted 8 August 2014 - 09:39

a bit better impl would be:

if (!isChunked && strncasecmp(linebuf, "transfer-encoding: chunked", strlen("transfer-encoding: chunked")) == 0)
{
    isChunked = true;
}

to avoid excessive string comparisons 

This sounds very reasonable, thanks!


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #614 Erik Slagter

  • PLi® Core member
  • 46,969 posts

+542
Excellent

Posted 8 August 2014 - 09:57

Zakalibit, comitted. I forgot to mention your credit, excuse!


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #615 Erik Slagter

  • PLi® Core member
  • 46,969 posts

+542
Excellent

Posted 8 August 2014 - 09:58

do not know where it shows exactly, but when I saw into its qtdemux.c under PLi, there f.eg. is  

demux->upstream_size = seekable ? stop : -1;

and then it cannot be boolean, imho

 

AFAIK Littlesat has committed this. Littlesat can you please acknowledge patches you have committed?


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #616 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 8 August 2014 - 10:17

Zakalibit, comitted. I forgot to mention your credit, excuse!

 

Not a problem, very good that it is done quickly :) 



Re: merge requests for PLi's git #617 zakalibit

  • Senior Member
  • 51 posts

+5
Neutral

Posted 8 August 2014 - 10:22

Zakalibit, comitted. I forgot to mention your credit, excuse!

I think there is no need to check for status code, I think the code should be as I posted above, it will work as is now as well, but code checking does not give anything useful there.

And could you please bring all strcmp() to the same form, i.e. !strcmp(), as we have strcmp() == 0 variation as well


Edited by zakalibit, 8 August 2014 - 10:24.


Re: merge requests for PLi's git #618 littlesat

  • PLi® Core member
  • 57,468 posts

+708
Excellent

Posted 8 August 2014 - 12:27

Erik, what do you mean?

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #619 Erik Slagter

  • PLi® Core member
  • 46,969 posts

+542
Excellent

Posted 8 August 2014 - 14:29

I mean if you apply/commit/push something, that you leave a message in the relevant thread that it's done, so others (from the team AND the contributor) can see in a blink of an eye whether it's done or not.


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #620 littlesat

  • PLi® Core member
  • 57,468 posts

+708
Excellent

Posted 8 August 2014 - 16:07

Xqq

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users