Also https://github.com/O...nigma2/pull/660
merge requests for PLi's git
Started by Persian Prince, 16 Apr 2013 12:12
1748 replies to this topic
Re: merge requests for PLi's git #1041
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1042
-
- Senior Member
- 1,982 posts
+247
Excellent
Re: merge requests for PLi's git #1043
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 14 February 2017 - 06:58
https://github.com/O...nigma2/pull/664
https://github.com/O...nigma2/pull/665
https://github.com/O...nigma2/pull/666
https://github.com/O...nigma2/pull/667
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1044
-
- PLi® Core member
- 57,233 posts
+701
Excellent
Posted 14 February 2017 - 07:25
There are still some aspects here that are not improvements and they are still not fuilly splitted....
Edited by littlesat, 14 February 2017 - 07:26.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1045
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 14 February 2017 - 08:52
Should I give up these cleanups ? Seems that way to me 
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1046
-
- PLi® Core member
- 57,233 posts
+701
Excellent
Posted 14 February 2017 - 15:14
You should not stop of course...
I'm a bit 'scared' to 'blindly' merge them as I also see some fixes.
And some of them (e.g. the one with the file open thing) isn't an improvement...
In addition we have a lot of improvements in one and the same improvement/cleanup request.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1047
-
- PLi® Core member
- 57,233 posts
+701
Excellent
Posted 14 February 2017 - 15:30
I could merge one of the 4.... on the other 3 I've comments... sorry....
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1048
-
- PLi® Core member
- 46,969 posts
+542
Excellent
Posted 14 February 2017 - 19:46
PP: recommendations to get your patches included:
- tackle one issue at a time, per patch, per PR
- describe the issue ALSO on the forum, we don't want to have to click all links to know what it's all about (don't include a link only)
- don't mix cosmetic and functional changes
Especially if it's core enigma or core OE code, describe VERY clearly what it does, we don't want to have spend hours of debugging coming to the conclusion one of those hazy patches was the cause.
* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.
Re: merge requests for PLi's git #1049
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 15 February 2017 - 10:55
You mean I have to send a merge requset for each py cleanup ? 16 merge requests for 16 files ?
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1050
-
- PLi® Core member
- 57,233 posts
+701
Excellent
Posted 15 February 2017 - 10:59
If you did that I did accept more of them... ...
Some of them are no improvements... -or- even might indicate they are not really tested. And they are also sometimes let's say in "deep code"... so I have no idea how to test them and/or trigger/challenge mistakes. See my comments on github...
Most of them can easily be checked by looking at the code.... not required () and ; etc... are easy to verify....
P.S. cleanups are always good!!!
Edited by littlesat, 15 February 2017 - 11:03.
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1051
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 15 February 2017 - 11:10
OK I will send new merge requests one by one since now 
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1052
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 15 February 2017 - 15:13
One more question:
Why do we need these files ?
https://github.com/O...aster/ChangeLog
https://github.com/O...lob/master/NEWS
Open Vision sources: https://github.com/OpenVisionE2
Re: merge requests for PLi's git #1053
-
- PLi® Core member
- 70,563 posts
+1,816
Excellent
Posted 15 February 2017 - 16:15
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Re: merge requests for PLi's git #1054
-
- PLi® Core member
- 57,233 posts
+701
Excellent
Posted 15 February 2017 - 16:43
Old ghost's files?
WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W
Re: merge requests for PLi's git #1055
-
- PLi® Core member
- 2,345 posts
+121
Excellent
Posted 15 February 2017 - 17:04
Try compile without them .
Re: merge requests for PLi's git #1056
-
- PLi® Core member
- 46,969 posts
+542
Excellent
Posted 15 February 2017 - 17:48
One more question:
Why do we need these files ?
https://github.com/O...aster/ChangeLog
https://github.com/O...lob/master/NEWS
These are probably created by autmake long ago. There is a chance that if you remove them, they automatically re-appear. But they don't belong in git, then, anyway.
* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.
Re: merge requests for PLi's git #1057
-
- PLi® Core member
- 2,345 posts
+121
Excellent
Posted 15 February 2017 - 18:30
There is a chance that if you remove them, they automatically re-appear.
They are not re-appeare. Without them compilation stop with error.
Edited by Taapat, 15 February 2017 - 18:31.
Re: merge requests for PLi's git #1058
-
- PLi® Core member
- 7,185 posts
+323
Excellent
Posted 15 February 2017 - 18:31
automake need these files
http://stackoverflow...ror-in-automake
But it seems there are "workarounds" so that you can remove them...
http://stackoverflow...ror-in-automake
But it seems there are "workarounds" so that you can remove them...
Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04
Re: merge requests for PLi's git #1059
-
- PLi® Core member
- 46,969 posts
+542
Excellent
Posted 15 February 2017 - 18:35
When you run autoreconf, which the building SHOULD use, they should re-appear. But of course they didn't.... There is a whole lot of other autoconf violations.
Edited by Erik Slagter, 15 February 2017 - 18:36.
* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.
Re: merge requests for PLi's git #1060
-
- Senior Member
- 1,982 posts
+247
Excellent
Posted 18 February 2017 - 09:36
Check the new cleanups
And do you have any idea about this : https://forums.openp...update-request/ ?
Edited by Persian Prince, 18 February 2017 - 09:36.
Open Vision sources: https://github.com/OpenVisionE2
9 user(s) are reading this topic
0 members, 9 guests, 0 anonymous users
