1748 replies to this topic

[littlesat]

Thanks....

What you did with some parameters setting to None and then later when it is None catch the default I did not except... Sorry..

[tension]

Typo?

--- openpli4/openpli-enigma2/lib/python/Screens/RecordPaths.py
+++ openpli4/openpli-enigma2/lib/python/Screens/RecordPaths.py
@@ -168,7 +168,7 @@
 				self.entrydirname.value = res
 			if config.usage.allowed_timeshift_paths.value != self.lasttimeshiftdirs:
 				tmp = config.usage.allowed_timeshift_paths.value
-				default = self.instantrec_dirname.value
+				default = self.timeshift_dirname.value
 				if default not in tmp:
 					tmp = tmp[:]
 					tmp.append(default)

[littlesat]

No....

[Persian Prince]

Check out the new cleanups

[littlesat]

Omh...(£o£)

Edited by littlesat, 19 February 2017 - 09:00.

[Persian Prince]

And again more

[littlesat]

It takes a lot of time..... Please "break" or calm down...

What you also can do is make one commit that just removes the ; at the end...

And one commit that just cleans the if's from not required ( )....

And one commit that contains if x != None to of x is not None:

And one commit for not required imports...

We just told you to make separate.... but somehow we have to get in the middle.... Now we clean up different types .... and by file we could have multiply cleanuptypes...

 

Keep it at one type of clean up..... and all that differs but in separate...

Edited by littlesat, 19 February 2017 - 10:50.

[Erik Slagter]

pp, I am still not seeing patches broken down into small chunks AND DESCRIBED HERE. What you're doing here is "throwing over the fence".

Edited by Erik Slagter, 19 February 2017 - 11:28.

[tension]

Why not?

 

 1_0_1_2197_5_13E_EEEE0000_0_0_0.jpg   75.34KB   4 downloads

 

 

[littlesat]

Are you sure this is a bug?

[tension]

Yes. It should not get as timeshift dirname the style <default> which if selected crashes enigma.

I never used this timeshift setting, i looked for the bug after reading the code .

[littlesat]

So it is OK as it is now?

[tension]

Yes. After that little fix playing with locationbox for adding or removing new/old timeshift paths, no more ends up with a fake entry in

timeshift dirname configselection box (fake named <default>, originating by a default value for instant rec dirname i presume).

Hi.

Edited by tension, 20 February 2017 - 13:06.

[Persian Prince]

https://github.com/O...nigma2/pull/799

https://github.com/O...lugins/pull/248

https://github.com/O...plugins/pull/11

 

Use 'is' and 'is not' instead of '==' and '!=' for 'None' values

[fairbird]

Hello all my friends ...

Can you please add some option to allow to change value of (self.progressBarWidth) in ServiceList.py ?!

As photos shown 

 

self.progressBarWidth = 100

 

 1.jpg   289.5KB   3 downloads

 

self.progressBarWidth = 52

 

 2.jpg   250.16KB   3 downloads

 

Because the default value is 52 and that value with some FHD skin if choose percentage doesn't appear correctly ..

 

 3.jpg   134.83KB   3 downloads

 

Thank you

[littlesat]

self.progressBarWidth can be defined by the skin... so the skin could reserve more room...

[fairbird]

Thank you my friend ..

Yes I know that .. But I'm ask if possible to add option and we can control of progressBarWidth.

Such as (Number of channels shown in channel selection list)

Edited by fairbird, 28 February 2017 - 17:55.

[littlesat]

Another config is not preferable... especially because the skin defines the space

[fairbird]

Thank you my friend

[littlesat]

No real thanks I think because I'm in the withhold mode...