1748 replies to this topic

[arn354]

You need to run enigma2 in console - then you see.

Traceback (most recent call last):
File "/usr/lib/enigma2/python/Components/ActionMap.py", line 65, in action
return ActionMap.action(self, contexts, action)
File "/usr/lib/enigma2/python/Components/ActionMap.py", line 46, in action
res = self.actions[action]()
File "/usr/lib/enigma2/python/Screens/Wizard.py", line 376, in ok
self.finished()
File "/usr/lib/enigma2/python/Screens/Wizard.py", line 331, in finished
print "current:", self["list"].current
File "/usr/lib/enigma2/python/Components/Element.py", line 13, in wrapper
return f(self)
File "/usr/lib/enigma2/python/Components/Sources/List.py", line 53, in getCurrent
return self.master is not None and self.master.current
AttributeError: 'StringListSelection' object has no attribute 'current'


TemplatedMultiContent.py is the culprit

[Erik Slagter]

If a commit (either manual or from a PR) empties a complete file (unintentionally), I think it's clear what needs to be done? Revert and only then look further? This also mean the PR lacked TWO steps of verification, by the author and by the committer!

[fairbird]

Hello friends ..

Please If can add (fade-out) 

https://github.com/O...2373ccc4fad9b88

 

Thank you

Edited by fairbird, 6 April 2017 - 19:42.

[ims]

Pls, merge this fix

 

thx

[littlesat]

Done....


And the fade out of osd is a note done patch... It works-a-round a fade out effect by playing with transparancy of thr OSD just for a x-mass tree effect.... I would say please keep it simple...

[SpaceRat]

Your gstplayer-recipe https://github.com/O...stplayer_0.1.bb has a bug:
 

do_compile() {
    cd ${S}/gstplayer/gst-1.0
    ${CC} *.c ../common/*.c -I../common/ `pkg-config --cflags --libs gstreamer-1.0 gstreamer-pbutils-1.0` -o gstplayer_gst-1.0 ${LDFLAGS}
}

without an "inherit pkgconfig" inside the recipe will invoke pkg-config with the host/build machine's /usr/include, /usr/lib etc.

The recipe fails if no gstreamer-dev packages are installed on the build machine and if it has different versions installed, it might result in a borked binary.

Simply adding

inherit pkgconfig

to the recipe will fix that.

https://github.com/o...a87362f6ca54829

[athoik]

Already handled on pyro branch: https://github.com/O...50449c5ec62c900

[WanWizard]

I think it should be in develop too, Pyro is still a bit off a release. Can if be cherry picked, or does it need to be added?

[athoik]

Cherry pick should work fine, although on our build servers we don't install gstreamer-dev packages and we never had that problem.

Indeed going on pyro, the depends are more strict now.

[WanWizard]

This is all a bit above my head. Could you backport anything that needs backporting from Pyro to develop?

[athoik]

Cherry picking from pyro branch into develop is fine?

Later merging from develop to pyro will create duplicates?

[WanWizard]

Yes, that is the downside of cherry picking, and the reason I don't like it. But sometimes it can't be avoided.

[athoik]

What if we use rebase? like described here: https://davitenio.wo...licate-commits/

[WanWizard]

Maybe Erik can comment, I'm not the best in advanced git wizardry.

[Erik Slagter]

Rebase can only ever be done on a non-public branch. I am a great fan of rebasing branches, to clean out all sorts of mess, but in this case it's impossible.

 

The pyro branch will be cleaned out anyway, it will be taken offline at some point, cleaned up (using rebasing) and then commits that make it different from develop will be added cleanly.

 

Anyway, just say which commit to cherry pick or @athoik do it yourself.

[athoik]

Most of my commits apply on develop.

So will cherry-pick them to develop.

[athoik]

Most of my commits apply on develop.

So will cherry-pick them to develop.

Commits without conflicts cherry-picked to develop.

Two two left out due to conflicts (will handle them later).

0a8e4526883e952719ac3df3f03236cbb22226d8
f4fe30d1e9a9dce6fa49be24c8b9988d708dafe3

Also few more seem "pyro" only specific so I didn't cherry-pick them.

Edited by athoik, 6 October 2017 - 17:25.

[Persian Prince]

https://github.com/O...io-grab/pull/10

[Persian Prince]

Is vuzero4k build ok or you didn't start the build yet?

[Erik Slagter]

https://github.com/O...io-grab/pull/10

athoik is taking care of it.