Jump to content


Photo

merge requests for PLi's git

Started by Persian Prince, 16 Apr 2013 12:12

  • Please log in to reply
1748 replies to this topic

Re: merge requests for PLi's git #1141 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 20 January 2018 - 11:43

https://github.com/O...e-core/pull/400 :)


Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1142 pzanone

  • Senior Member
  • 212 posts

+13
Neutral

Posted 23 January 2018 - 22:35

is it possible to update it in the feeds?

https://forums.openp...pgimport-in-it/

 

thanks


Re: merge requests for PLi's git #1143 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 2 February 2018 - 06:56

https://github.com/O...e-core/pull/404 :)

Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1144 WanWizard

  • PLi® Core member
  • 70,220 posts

+1,798
Excellent

Posted 2 February 2018 - 11:18

Merged. Next build of 6.1 is on Monday.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.

Re: merge requests for PLi's git #1145 pzanone

  • Senior Member
  • 212 posts

+13
Neutral

Posted 2 February 2018 - 11:56

please locale .po It :)

Attached Files


Re: merge requests for PLi's git #1146 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 4 February 2018 - 08:51

https://github.com/O...e-core/pull/394

https://github.com/O...e-core/pull/405

https://github.com/O...io-grab/pull/15

 

:)


Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1147 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 4 February 2018 - 11:10

Also https://github.com/O...e-core/pull/406 :)

 

Please merge https://github.com/O...e-core/pull/405 as soon as possible to be on monday updates ;)


Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1148 WanWizard

  • PLi® Core member
  • 70,220 posts

+1,798
Excellent

Posted 4 February 2018 - 11:13

Done, apart from aoi-grab, someone else needs to check that one.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.

Re: merge requests for PLi's git #1149 foxbob

  • Senior Member
  • 624 posts

+18
Neutral

Posted 4 February 2018 - 12:01

Error build

| ../git/main.c: In function 'main':
| ../git/main.c:127:7: warning: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]
|    if (strcasestr(buf,"VULCAN")) stb_type=VULCAN;
|        ^~~~~~~~~~
|        strcasecmp
| ../git/main.c:331:17: error: 'BRCM7439' undeclared (first use in this function); did you mean 'BRCM7435'?
|       stb_type = BRCM7439;
|                  ^~~~~~~~
|                  BRCM7435
| ../git/main.c:331:17: note: each undeclared identifier is reported only once for each function it appears in
| Makefile:388: recipe for target 'grab-main.o' failed

Re: merge requests for PLi's git #1150 Erik Slagter

  • PLi® Core member
  • 46,969 posts

+541
Excellent

Posted 4 February 2018 - 12:02

Also done.


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: merge requests for PLi's git #1151 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 4 February 2018 - 12:17

 

Error build

| ../git/main.c: In function 'main':
| ../git/main.c:127:7: warning: implicit declaration of function 'strcasestr'; did you mean 'strcasecmp'? [-Wimplicit-function-declaration]
|    if (strcasestr(buf,"VULCAN")) stb_type=VULCAN;
|        ^~~~~~~~~~
|        strcasecmp
| ../git/main.c:331:17: error: 'BRCM7439' undeclared (first use in this function); did you mean 'BRCM7435'?
|       stb_type = BRCM7439;
|                  ^~~~~~~~
|                  BRCM7435
| ../git/main.c:331:17: note: each undeclared identifier is reported only once for each function it appears in
| Makefile:388: recipe for target 'grab-main.o' failed

 

Yeah it was missed: https://github.com/O...io-grab/pull/16


Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1152 athoik

  • PLi® Core member
  • 8,458 posts

+327
Excellent

Posted 4 February 2018 - 12:25

Those are very common mistakes from someone not testing (not even building) his code.

I think you should at least build before commit.
Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1153 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 4 February 2018 - 12:29

Actually I do with https://github.com/DMM-PLi but sometimes I do things locally and I forget to commit them on github :(


Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1154 WanWizard

  • PLi® Core member
  • 70,220 posts

+1,798
Excellent

Posted 4 February 2018 - 12:47

I would urge you to clean up your act a little bit, and please test properly before you create a PR. This sloppyness costs everyone else quite a bit of time, because we can't build until your bugs have been fixed.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.

Re: merge requests for PLi's git #1155 foxbob

  • Senior Member
  • 624 posts

+18
Neutral

Posted 4 February 2018 - 12:54

Build ok.


Re: merge requests for PLi's git #1156 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 4 February 2018 - 13:13

I'm really sorry :(
 
It's ok on develop. Don't forget if you want to benefit from https://github.com/O...701b9fdb64eceb3 you need to remove your "build" directory and build again.
 
Again sorry for any inconvenience :(

Open Vision sources: https://github.com/OpenVisionE2

Re: merge requests for PLi's git #1157 athoik

  • PLi® Core member
  • 8,458 posts

+327
Excellent

Posted 4 February 2018 - 13:37

I guess integrating some projects with travis-ci (or any other CI) would make things much easier for all.

PR will fail after CI triggers, so nobody will merge a failed PR.

Anyone with experience to assist?

Edited by athoik, 4 February 2018 - 13:37.

Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1158 SpaceRat

  • Senior Member
  • 1,030 posts

+65
Good

Posted 4 February 2018 - 13:45

OpenWebif uses Travis CI: https://travis-ci.or...um=notification
I also use Travis CI for oscam-smod: https://travis-ci.or...um=notification

The problem with enigma2 is, that it will likely not build as-is, as it has dependencies within the oe-core, and building the whole image will take eternities.
1st box: Vu+ Ultimo 4k 4xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
2nd box: Gigablue Quad 4k 2xDVB-S2 FBC / 2xDVB-C / 1.8 TB HDD / OpenATV 6.2
testing boxes: Vu+ Duo² + AX Quadbox HD2400 + 2x Vu+ Solo² + Octagon SF4008
Sats & Pay-TV: Astra 19.2°E + Hotbird 13°E with Redlight / SCT HD / SES Astra HD- / Sky V14 / 4th empire propaganda TV
Card-Server: Raspberry Pi + IPv6-capable oscam
Router: Linksys WRT1900ACS w/ LEDE + Fritz!Box 7390

Re: merge requests for PLi's git #1159 athoik

  • PLi® Core member
  • 8,458 posts

+327
Excellent

Posted 4 February 2018 - 13:47

Better to avoid at least common errors, than nothing.

OE also can be triggered by a commit, some people are using toaster.

PS, can you post a guide, yml for that?

Edited by athoik, 4 February 2018 - 13:48.

Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1160 WanWizard

  • PLi® Core member
  • 70,220 posts

+1,798
Excellent

Posted 4 February 2018 - 13:48

I've been using travis-ci for years, for different projects. 

 

For enigma, there isn't only a dependency issue, but also the fact that a test build takes ages, as travis doesn't have any history it can work with, it spins up a new VM for every test build.

 

Ihmo it isn't too much to ask to verify your code, at least for the most obvious bugs, before you commit something. Logic errors may escape scrutiny, but syntax errors are plainly embasassing...

 

Once buildserver #1 has been upgraded and is back into service, we can use that for our own CI builds, as well as for feature branch builds.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.

Back to [EN] Third-Party Development

11 user(s) are reading this topic

0 members, 11 guests, 0 anonymous users

  1. Forums
  2. → PLi® Development
  3. → [EN] Third-Party Development